From 958ab2af7c5c42364d7b71ce2165a983cc54a15b Mon Sep 17 00:00:00 2001 From: Brian Faust Date: Wed, 17 Jul 2019 07:04:47 +0300 Subject: [PATCH 1/2] fix: ignore ParsedUrlQuery modification for serve --- libs/badgen-serve.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/libs/badgen-serve.ts b/libs/badgen-serve.ts index 3f6b017..760d537 100644 --- a/libs/badgen-serve.ts +++ b/libs/badgen-serve.ts @@ -69,6 +69,7 @@ export function badgenServe (handlers: BadgenServeHandlers): Function { params.subject = simpleDecode(params.subject) params.status = simpleDecode(params.status) + // @ts-ignore query.icon = icon === '' ? params.subject : icon if (query.style === undefined) { From 2615fb8ef3eb5493045261ed3cd97b1545462a52 Mon Sep 17 00:00:00 2001 From: Brian Faust Date: Thu, 18 Jul 2019 10:01:37 +0300 Subject: [PATCH 2/2] fix: check if icon is undefined before trying to set it --- libs/badgen-serve.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libs/badgen-serve.ts b/libs/badgen-serve.ts index 760d537..09a8569 100644 --- a/libs/badgen-serve.ts +++ b/libs/badgen-serve.ts @@ -69,8 +69,9 @@ export function badgenServe (handlers: BadgenServeHandlers): Function { params.subject = simpleDecode(params.subject) params.status = simpleDecode(params.status) - // @ts-ignore - query.icon = icon === '' ? params.subject : icon + if (icon !== undefined) { + query.icon = icon === '' ? params.subject : icon + } if (query.style === undefined) { const host = req.headers['x-forwarded-host'] || req.headers.host