BugFix for invalid hexes in the hex index

app/src/main/java/com/vitorpamplona/amethyst/model/LocalCache.kt

@@ -72,11 +72,11 @@ object LocalCache {
         if (isValidHex(key)) {
             val note = getOrCreateNote(key)
             val noteEvent = note.event
-            if (noteEvent is AddressableEvent) {
+            return if (noteEvent is AddressableEvent) {
                 // upgrade to the latest
-                return checkGetOrCreateAddressableNote(noteEvent.address().toTag())
+                checkGetOrCreateAddressableNote(noteEvent.address().toTag())
             } else {
-                return note
+                note
             }
         }
         return null

app/src/main/java/com/vitorpamplona/amethyst/model/ThreadAssembler.kt

@@ -1,7 +1,6 @@
 package com.vitorpamplona.amethyst.model
 
 import com.vitorpamplona.amethyst.service.checkNotInMainThread
-import com.vitorpamplona.amethyst.service.model.ATag
 import com.vitorpamplona.amethyst.service.model.GenericRepostEvent
 import com.vitorpamplona.amethyst.service.model.RepostEvent
 import kotlin.time.ExperimentalTime
@@ -43,16 +42,7 @@ class ThreadAssembler {
         checkNotInMainThread()
 
         val (result, elapsed) = measureTimedValue {
-            val note = if (noteId.contains(":")) {
-                val aTag = ATag.parse(noteId, null)
-                if (aTag != null) {
-                    LocalCache.getOrCreateAddressableNote(aTag)
-                } else {
-                    return emptySet()
-                }
-            } else {
-                LocalCache.getOrCreateNote(noteId)
-            }
+            val note = LocalCache.checkGetOrCreateNote(noteId) ?: return emptySet<Note>()
 
             if (note.event != null) {
                 val thread = mutableSetOf<Note>()

app/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedIn/ProfileScreen.kt

@@ -1148,7 +1148,7 @@ private fun LoadAndRenderBadge(badgeAwardEventHex: String, nav: (String) -> Unit
     LaunchedEffect(key1 = badgeAwardEventHex) {
         if (baseNote == null) {
             launch(Dispatchers.IO) {
-                baseNote = LocalCache.getOrCreateNote(badgeAwardEventHex)
+                baseNote = LocalCache.checkGetOrCreateNote(badgeAwardEventHex)
             }
         }
     }