From 49fb16e2c6528ddc98cccc352cc8f0d4a5f62a13 Mon Sep 17 00:00:00 2001
From: Wouter Gritter <wouter@gritter.me>
Date: Thu, 21 Nov 2024 10:52:22 +0100
Subject: [PATCH] Introduce printSetInputMaxlength to properly set an inputs
 maxlength variable

---
 wled00/fcn_declare.h | 1 +
 wled00/util.cpp      | 4 ++++
 wled00/xml.cpp       | 5 +++--
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/wled00/fcn_declare.h b/wled00/fcn_declare.h
index 1855a8b63..91176160f 100644
--- a/wled00/fcn_declare.h
+++ b/wled00/fcn_declare.h
@@ -380,6 +380,7 @@ size_t printSetFormValue(Print& settingsScript, const char* key, int val);
 size_t printSetFormValue(Print& settingsScript, const char* key, const char* val);
 size_t printSetFormIndex(Print& settingsScript, const char* key, int index);
 size_t printSetClassElementHTML(Print& settingsScript, const char* key, const int index, const char* val);
+size_t printSetInputMaxLength(Print& settingsScript, const char* key, int val);
 void prepareHostname(char* hostname);
 bool isAsterisksOnly(const char* str, byte maxLen);
 bool requestJSONBufferLock(uint8_t module=255);
diff --git a/wled00/util.cpp b/wled00/util.cpp
index 0b78a4646..1c1282eda 100644
--- a/wled00/util.cpp
+++ b/wled00/util.cpp
@@ -109,6 +109,10 @@ size_t printSetClassElementHTML(Print& settingsScript, const char* key, const in
   return settingsScript.printf_P(PSTR("d.getElementsByClassName(\"%s\")[%d].innerHTML=\"%s\";"), key, index, val);
 }
 
+size_t printSetInputMaxLength(Print& settingsScript, const char* key, int val) {
+  return settingsScript.printf_P(PSTR("d.Sf.%s.setAttribute(\"maxlength\", %d);"),key,val);
+}
+
 
 
 void prepareHostname(char* hostname)
diff --git a/wled00/xml.cpp b/wled00/xml.cpp
index dc2673271..6f837a9b6 100644
--- a/wled00/xml.cpp
+++ b/wled00/xml.cpp
@@ -465,8 +465,9 @@ void getSettingsJS(byte subPage, Print& settingsScript)
     printSetFormValue(settingsScript,PSTR("MG"),mqttGroupTopic);
     printSetFormCheckbox(settingsScript,PSTR("BM"),buttonPublishMqtt);
     printSetFormCheckbox(settingsScript,PSTR("RT"),retainMqttMsg);
-    settingsScript.printf_P(PSTR("d.Sf.MD.maxlength=%d;d.Sf.MG.maxlength=%d;d.Sf.MS.maxlength=%d;"),
-                  MQTT_MAX_TOPIC_LEN, MQTT_MAX_TOPIC_LEN, MQTT_MAX_SERVER_LEN);
+    printSetInputMaxLength(settingsScript, PSTR("MD"), MQTT_MAX_TOPIC_LEN);
+    printSetInputMaxLength(settingsScript, PSTR("MG"), MQTT_MAX_TOPIC_LEN);
+    printSetInputMaxLength(settingsScript, PSTR("MS"), MQTT_MAX_SERVER_LEN);
     #else
     settingsScript.print(F("toggle('MQTT');"));    // hide MQTT settings
     #endif