From e82b0a6c8f3f8f119209f3cc76da1ad0788f06b8 Mon Sep 17 00:00:00 2001
From: Steve Ruiz <steveruizok@gmail.com>
Date: Tue, 23 Apr 2024 11:23:01 +0100
Subject: [PATCH] Make note handles show only one when zoomed out (#3562)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This PR will only show the bottom handle on a sticky note when zoomed
out.

### Change Type

- [x] `sdk` — Changes the tldraw SDK
- [x] `improvement` — Improving existing features

### Test Plan

1. Zoom out to 45%.
2. The bottom handle should be visible.
3. The bottom handle should work as expected.

### Release Notes

- Show only the bottom handle on notes when zoomed between .25 and .5
---
 .../src/lib/shapes/note/NoteShapeUtil.tsx     | 12 +++++
 .../tldraw/src/lib/shapes/note/noteHelpers.ts | 44 ++++++++++---------
 .../SelectTool/childStates/PointingHandle.ts  |  5 +--
 3 files changed, 38 insertions(+), 23 deletions(-)

diff --git a/packages/tldraw/src/lib/shapes/note/NoteShapeUtil.tsx b/packages/tldraw/src/lib/shapes/note/NoteShapeUtil.tsx
index 89ae4a330..5c8ed5825 100644
--- a/packages/tldraw/src/lib/shapes/note/NoteShapeUtil.tsx
+++ b/packages/tldraw/src/lib/shapes/note/NoteShapeUtil.tsx
@@ -106,6 +106,18 @@ export class NoteShapeUtil extends ShapeUtil<TLNoteShape> {
 
 		if (zoom < 0.25 || isCoarsePointer) return []
 
+		if (zoom < 0.5) {
+			return [
+				{
+					id: 'bottom',
+					index: 'a3' as IndexKey,
+					type: 'clone',
+					x: NOTE_SIZE / 2,
+					y: noteHeight + offset,
+				},
+			]
+		}
+
 		return [
 			{
 				id: 'top',
diff --git a/packages/tldraw/src/lib/shapes/note/noteHelpers.ts b/packages/tldraw/src/lib/shapes/note/noteHelpers.ts
index dabf4bf33..e9e822dfd 100644
--- a/packages/tldraw/src/lib/shapes/note/noteHelpers.ts
+++ b/packages/tldraw/src/lib/shapes/note/noteHelpers.ts
@@ -1,4 +1,4 @@
-import { Editor, TLNoteShape, TLShape, Vec, compact, createShapeId } from '@tldraw/editor'
+import { Editor, IndexKey, TLNoteShape, TLShape, Vec, compact, createShapeId } from '@tldraw/editor'
 import { zoomToShapeIfOffscreen } from '../../tools/SelectTool/selectHelpers'
 
 /** @internal */
@@ -12,12 +12,12 @@ export const NOTE_CENTER_OFFSET = { x: NOTE_SIZE / 2, y: NOTE_SIZE / 2 }
 /** @internal */
 export const NOTE_PIT_RADIUS = 10
 
-const DEFAULT_PITS = [
-	new Vec(NOTE_SIZE * 0.5, NOTE_SIZE * -0.5 - ADJACENT_NOTE_MARGIN), // t
-	new Vec(NOTE_SIZE * 1.5 + ADJACENT_NOTE_MARGIN, NOTE_SIZE * 0.5), // r
-	new Vec(NOTE_SIZE * 0.5, NOTE_SIZE * 1.5 + ADJACENT_NOTE_MARGIN), // b
-	new Vec(NOTE_SIZE * -0.5 - ADJACENT_NOTE_MARGIN, NOTE_SIZE * 0.5), // l
-]
+const DEFAULT_PITS = {
+	['a1' as IndexKey]: new Vec(NOTE_SIZE * 0.5, NOTE_SIZE * -0.5 - ADJACENT_NOTE_MARGIN), // t
+	['a2' as IndexKey]: new Vec(NOTE_SIZE * 1.5 + ADJACENT_NOTE_MARGIN, NOTE_SIZE * 0.5), // r
+	['a3' as IndexKey]: new Vec(NOTE_SIZE * 0.5, NOTE_SIZE * 1.5 + ADJACENT_NOTE_MARGIN), // b
+	['a4' as IndexKey]: new Vec(NOTE_SIZE * -0.5 - ADJACENT_NOTE_MARGIN, NOTE_SIZE * 0.5), // l
+}
 
 /**
  * Get the adjacent positions for a particular note shape.
@@ -33,18 +33,20 @@ export function getNoteAdjacentPositions(
 	pageRotation: number,
 	growY: number,
 	extraHeight: number
-) {
-	return DEFAULT_PITS.map((v, i) => {
-		const point = v.clone()
-		if (i === 0 && extraHeight) {
-			// apply top margin (the growY of the moving note shape)
-			point.y -= extraHeight
-		} else if (i === 2 && growY) {
-			// apply bottom margin (the growY of this note shape)
-			point.y += growY
-		}
-		return point.rot(pageRotation).add(pagePoint)
-	})
+): Record<IndexKey, Vec> {
+	return Object.fromEntries(
+		Object.entries(DEFAULT_PITS).map(([id, v], i) => {
+			const point = v.clone()
+			if (i === 0 && extraHeight) {
+				// apply top margin (the growY of the moving note shape)
+				point.y -= extraHeight
+			} else if (i === 2 && growY) {
+				// apply bottom margin (the growY of this note shape)
+				point.y += growY
+			}
+			return [id, point.rot(pageRotation).add(pagePoint)]
+		})
+	)
 }
 
 /**
@@ -81,7 +83,9 @@ export function getAvailableNoteAdjacentPositions(
 
 		// And push its position to the positions array
 		positions.push(
-			...getNoteAdjacentPositions(transform.point(), rotation, shape.props.growY, extraHeight)
+			...Object.values(
+				getNoteAdjacentPositions(transform.point(), rotation, shape.props.growY, extraHeight)
+			)
 		)
 	}
 
diff --git a/packages/tldraw/src/lib/tools/SelectTool/childStates/PointingHandle.ts b/packages/tldraw/src/lib/tools/SelectTool/childStates/PointingHandle.ts
index 138253371..239b1a45c 100644
--- a/packages/tldraw/src/lib/tools/SelectTool/childStates/PointingHandle.ts
+++ b/packages/tldraw/src/lib/tools/SelectTool/childStates/PointingHandle.ts
@@ -130,9 +130,8 @@ function getNoteForPit(editor: Editor, shape: TLNoteShape, handle: TLHandle, for
 	const pagePoint = pageTransform.point()
 	const pageRotation = pageTransform.rotation()
 	const pits = getNoteAdjacentPositions(pagePoint, pageRotation, shape.props.growY, 0)
-	const index = editor.getShapeHandles(shape.id)!.findIndex((h) => h.id === handle.id)
-	if (pits[index]) {
-		const pit = pits[index]
+	const pit = pits[handle.index]
+	if (pit) {
 		return getNoteShapeForAdjacentPosition(editor, shape, pit, pageRotation, forceNew)
 	}
 }