Fix in KISS frame encoding

Fix in ax.25 address portion encoding
KISS to TNC2 decoding
pull/3/head
Łukasz Nidecki 2021-02-11 18:26:42 +01:00
rodzic 544db5b987
commit 20722282af
2 zmienionych plików z 116 dodań i 19 usunięć

Wyświetl plik

@ -2,7 +2,14 @@
bool validateTNC2Frame(const String &tnc2FormattedFrame);
String encode_address_kiss(String tnc2Address, bool isLast);
String encode_address_ax25(String tnc2Address);
String decode_address_ax25(const String& ax25Address, bool &isLast);
bool validateKISSFrame(const String &kissFormattedFrame);
String encapsulateKISS(const String &ax25Frame);
String decapsulateKISS(const String& frame);
/*
* https://ham.zmailer.org/oh2mqk/aprx/PROTOCOLS
@ -33,36 +40,46 @@ String encode_kiss(const String& tnc2FormattedFrame) {
if (validateTNC2Frame(tnc2FormattedFrame)){
String address = "";
for (int p=0;p<tnc2FormattedFrame.indexOf(':');p++){
bool dst_addres_written = false;
for (int p=0;p<=tnc2FormattedFrame.indexOf(':');p++){
char currentChar = tnc2FormattedFrame.charAt(p);
if (currentChar == ':' || currentChar == '>' || currentChar == ','){
if (currentChar == '>'){
if (!dst_addres_written && (currentChar == ',' || currentChar == ':')){
// ax25 frame DST SRC
// tnc2 frame SRC DST
ax25Frame = encode_address_kiss(address, currentChar == ':') + ax25Frame;
ax25Frame = encode_address_ax25(address) + ax25Frame;
dst_addres_written = true;
} else {
ax25Frame += encode_address_kiss(address, currentChar == ':');
ax25Frame += encode_address_ax25(address);
}
address = "";
} else {
address += currentChar;
}
}
auto lastAddressChar = (uint8_t)ax25Frame.charAt(ax25Frame.length() - 1);
ax25Frame.setCharAt(ax25Frame.length() - 1, (char)(lastAddressChar | IS_LAST_ADDRESS_POSITION_MASK));
ax25Frame += (char)APRS_CONTROL_FIELD;
ax25Frame += (char)APRS_INFORMATION_FIELD;
ax25Frame += tnc2FormattedFrame.substring(tnc2FormattedFrame.indexOf(':')+1);
}
String kissFrame = encapsulateKISS(ax25Frame);
return kissFrame;
}
String encapsulateKISS(const String &ax25Frame) {
String kissFrame = "";
kissFrame += (char)FEND; // start of frame
kissFrame += (char)CMD_DATA; // TNC0, DATA
for (int i = 0; i < ax25Frame.length(); ++i) {
char currentChar = ax25Frame.charAt(i);
if (currentChar == (char)FEND) {
kissFrame += FESC;
kissFrame += TFEND;
if (currentChar == (char)FEND){
kissFrame += (char)FESC;
kissFrame += (char)TFEND;
} else if (currentChar == (char)FESC){
kissFrame += FESC;
kissFrame += TFESC;
kissFrame += (char)FESC;
kissFrame += (char)TFESC;
} else {
kissFrame += currentChar;
}
@ -71,30 +88,107 @@ String encode_kiss(const String& tnc2FormattedFrame) {
return kissFrame;
}
String decapsulateKISS(const String& frame) {
String ax25Frame = "";
for (int i = 2; i < frame.length() - 1; ++i) {
char currentChar = frame.charAt(i);
if (currentChar == (char)FESC){
char nextChar = frame.charAt(i+1);
if (nextChar == (char)TFEND){
ax25Frame += (char)FEND;
} else if (nextChar == (char)TFESC){
ax25Frame += (char)FESC;
}
i++;
} else {
ax25Frame += currentChar;
}
}
return ax25Frame;
}
String decode_kiss(const String& kissFormattedFrame) {
String TNC2Frame = "";
if (validateKISSFrame(kissFormattedFrame)){
String ax25Frame = decapsulateKISS(kissFormattedFrame);
bool isLast = false;
String dst_addr = decode_address_ax25(ax25Frame.substring(0, 7), isLast);
String src_addr = decode_address_ax25(ax25Frame.substring(7, 14), isLast);
TNC2Frame = src_addr + ">" + dst_addr;
int digi_info_index = 14;
while (!isLast && digi_info_index + 7 < ax25Frame.length()){
String digi_addr = decode_address_ax25(ax25Frame.substring(digi_info_index, digi_info_index+7), isLast);
TNC2Frame += ',' + digi_addr;
digi_info_index += 7;
}
TNC2Frame += ':';
TNC2Frame += ax25Frame.substring(digi_info_index + 2);
}
return TNC2Frame;
}
/**
* Encode adress in TNC2 monitor format to ax.25/kiss format
* Encode adress in TNC2 monitor format to ax.25 format
* @param tnc2Address
* @param isLast
* @return
*/
String encode_address_kiss(String tnc2Address, bool isLast) {
String encode_address_ax25(String tnc2Address) {
if (tnc2Address.indexOf('-') == -1){
tnc2Address += "-0";
}
bool hasBeenDigipited = tnc2Address.indexOf('*') != -1;
int ssid = tnc2Address.substring(tnc2Address.indexOf('-')+1).toInt();
int separatorIndex = tnc2Address.indexOf('-');
int ssid = tnc2Address.substring(separatorIndex + 1).toInt();
// TODO: SSID should not be > 16
String kissAddress = "";
for (int i = 0; i < 6; ++i) {
if (tnc2Address.length() > i){
kissAddress += (char)(tnc2Address.charAt(i) << 1);
char addressChar;
if (tnc2Address.length() > i && i < separatorIndex){
addressChar = tnc2Address.charAt(i);
} else {
kissAddress += ' ';
addressChar = ' ';
}
kissAddress += (char)(addressChar << 1);
}
kissAddress += (char)((ssid << 1) | 0b01100000 | (isLast ? 1 : 0) | (hasBeenDigipited ? 0b10000000 : 0));
kissAddress += (char)((ssid << 1) | 0b01100000 | (hasBeenDigipited ? HAS_BEEN_DIGIPITED_MASK : 0));
return kissAddress;
}
/**
* Decode address from ax.25 format to TNC2 monitor format
* @param ax25Address
* @return
*/
String decode_address_ax25(const String& ax25Address, bool &isLast) {
String TNCAddress = "";
for (int i = 0; i < 6; ++i) {
uint8_t currentCharacter = ax25Address.charAt(i);
currentCharacter >>= 1;
if (currentCharacter != ' '){
TNCAddress += (char)currentCharacter;
}
}
auto ssid_char = (uint8_t) ax25Address.charAt(6);
bool hasBeenDigipited = ssid_char & HAS_BEEN_DIGIPITED_MASK;
isLast = ssid_char & IS_LAST_ADDRESS_POSITION_MASK;
ssid_char >>= 1;
int ssid = 0b1111 & ssid_char;
if (ssid){
TNCAddress += '-';
TNCAddress += ssid;
}
if (hasBeenDigipited){
TNCAddress += '*';
}
return TNCAddress;
}
bool validateTNC2Frame(const String &tnc2FormattedFrame) { return (tnc2FormattedFrame.indexOf(':') != -1) && (tnc2FormattedFrame.indexOf('>') != -1); }
bool validateKISSFrame(const String &kissFormattedFrame) { return kissFormattedFrame.charAt(0) == (char)FEND && kissFormattedFrame.charAt(kissFormattedFrame.length() - 1) == (char)FEND; }

Wyświetl plik

@ -4,6 +4,9 @@
#define APRS_CONTROL_FIELD 0x03
#define APRS_INFORMATION_FIELD 0xf0
#define HAS_BEEN_DIGIPITED_MASK 0b10000000
#define IS_LAST_ADDRESS_POSITION_MASK 0b1
String encode_kiss(const String& tnc2FormattedFrame);
String decode_kiss(String kissFormattedFrame);
String decode_kiss(const String& kissFormattedFrame);