From fe088c39c708f3085b7a6ebddc8f892821b37b0c Mon Sep 17 00:00:00 2001
From: Greyson Parrelli <greyson@signal.org>
Date: Fri, 25 Feb 2022 12:52:52 -0500
Subject: [PATCH] Avoid querying conversation size twice.

---
 .../securesms/conversation/ConversationDataSource.java      | 6 ++++--
 .../securesms/conversation/ConversationViewModel.java       | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationDataSource.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationDataSource.java
index 4fb285a60..650b86739 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationDataSource.java
+++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationDataSource.java
@@ -46,18 +46,20 @@ class ConversationDataSource implements PagedDataSource<MessageId, ConversationM
   private final long               threadId;
   private final MessageRequestData messageRequestData;
   private final boolean            showUniversalExpireTimerUpdate;
+  private final int                baseSize;
 
-  ConversationDataSource(@NonNull Context context, long threadId, @NonNull MessageRequestData messageRequestData, boolean showUniversalExpireTimerUpdate) {
+  ConversationDataSource(@NonNull Context context, long threadId, @NonNull MessageRequestData messageRequestData, boolean showUniversalExpireTimerUpdate, int baseSize) {
     this.context                        = context;
     this.threadId                       = threadId;
     this.messageRequestData             = messageRequestData;
     this.showUniversalExpireTimerUpdate = showUniversalExpireTimerUpdate;
+    this.baseSize                       = baseSize;
   }
 
   @Override
   public int size() {
     long startTime = System.currentTimeMillis();
-    int  size      = SignalDatabase.mmsSms().getConversationCount(threadId) +
+    int  size      = baseSize +
                      (messageRequestData.includeWarningUpdateMessage() ? 1 : 0) +
                      (showUniversalExpireTimerUpdate ? 1 : 0);
 
diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationViewModel.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationViewModel.java
index 030adba43..03b854e07 100644
--- a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationViewModel.java
+++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationViewModel.java
@@ -151,7 +151,7 @@ public class ConversationViewModel extends ViewModel {
       ApplicationDependencies.getDatabaseObserver().registerConversationObserver(data.getThreadId(), conversationObserver);
       ApplicationDependencies.getDatabaseObserver().registerMessageInsertObserver(data.getThreadId(), messageInsertObserver);
 
-      ConversationDataSource dataSource = new ConversationDataSource(context, data.getThreadId(), messageRequestData, data.showUniversalExpireTimerMessage());
+      ConversationDataSource dataSource = new ConversationDataSource(context, data.getThreadId(), messageRequestData, data.showUniversalExpireTimerMessage(), data.getThreadSize());
       PagingConfig config = new PagingConfig.Builder().setPageSize(25)
                                                       .setBufferPages(3)
                                                       .setStartIndex(Math.max(startPosition, 0))