From d7bf4f178f0675985fe02330e9f729f7f6644362 Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Fri, 4 Feb 2022 12:01:31 -0500 Subject: [PATCH] Prevent us from ever having no default transport option. --- .../conversation/ConversationParentFragment.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationParentFragment.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationParentFragment.java index c4bee278b..e408c37de 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationParentFragment.java +++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationParentFragment.java @@ -1552,18 +1552,21 @@ public class ConversationParentFragment extends Fragment sendButton.resetAvailableTransports(isMediaMessage); - if (!isSecureText && !isPushGroupConversation() && !recipient.get().isAciOnly() && !recipient.get().isReleaseNotes()) { - sendButton.disableTransport(Type.TEXTSECURE); - } + boolean smsEnabled = true; if (recipient.get().isPushGroup() || (!recipient.get().isMmsGroup() && !recipient.get().hasSmsAddress())) { sendButton.disableTransport(Type.SMS); + smsEnabled = false; } - if (!recipient.get().isPushGroup() && recipient.get().isForceSmsSelection()) { + if (!isSecureText && !isPushGroupConversation() && !recipient.get().isAciOnly() && !recipient.get().isReleaseNotes() && smsEnabled) { + sendButton.disableTransport(Type.TEXTSECURE); + } + + if (!recipient.get().isPushGroup() && recipient.get().isForceSmsSelection() && smsEnabled) { sendButton.setDefaultTransport(Type.SMS); } else { - if (isSecureText || isPushGroupConversation() || recipient.get().isAciOnly() || recipient.get().isReleaseNotes()) { + if (isSecureText || isPushGroupConversation() || recipient.get().isAciOnly() || recipient.get().isReleaseNotes() || !smsEnabled) { sendButton.setDefaultTransport(Type.TEXTSECURE); } else { sendButton.setDefaultTransport(Type.SMS);