diff --git a/app/src/androidTest/java/org/thoughtcrime/securesms/conversation/SafetyNumberChangeDialogPreviewer.kt b/app/src/androidTest/java/org/thoughtcrime/securesms/conversation/SafetyNumberChangeDialogPreviewer.kt index 7bcbbbfe3..4a14a1c25 100644 --- a/app/src/androidTest/java/org/thoughtcrime/securesms/conversation/SafetyNumberChangeDialogPreviewer.kt +++ b/app/src/androidTest/java/org/thoughtcrime/securesms/conversation/SafetyNumberChangeDialogPreviewer.kt @@ -8,6 +8,8 @@ import org.junit.runner.RunWith import org.thoughtcrime.securesms.contacts.paged.ContactSearchKey import org.thoughtcrime.securesms.database.IdentityDatabase import org.thoughtcrime.securesms.database.SignalDatabase +import org.thoughtcrime.securesms.database.model.DistributionListId +import org.thoughtcrime.securesms.database.model.DistributionListPrivacyMode import org.thoughtcrime.securesms.dependencies.ApplicationDependencies import org.thoughtcrime.securesms.profiles.ProfileName import org.thoughtcrime.securesms.recipients.Recipient @@ -42,25 +44,30 @@ class SafetyNumberChangeDialogPreviewer { @Test fun testShowLargeSheet() { + SignalDatabase.distributionLists.setPrivacyMode(DistributionListId.MY_STORY, DistributionListPrivacyMode.ONLY_WITH) + val othersRecipients = harness.others.map { Recipient.resolved(it) } othersRecipients.forEach { other -> SignalDatabase.recipients.setProfileName(other.id, ProfileName.fromParts("My", "Name")) harness.setVerified(other, IdentityDatabase.VerifiedStatus.DEFAULT) harness.changeIdentityKey(other) + + SignalDatabase.distributionLists.addMemberToList(DistributionListId.MY_STORY, DistributionListPrivacyMode.ONLY_WITH, other.id) } + val myStoryRecipientId = SignalDatabase.distributionLists.getRecipientId(DistributionListId.MY_STORY)!! val scenario: ActivityScenario = harness.launchActivity { putExtra("recipient_id", harness.others.first().serialize()) } scenario.onActivity { conversationActivity -> SafetyNumberBottomSheet .forIdentityRecordsAndDestinations( identityRecords = ApplicationDependencies.getProtocolStore().aci().identities().getIdentityRecords(othersRecipients).identityRecords, - destinations = othersRecipients.map { ContactSearchKey.RecipientSearchKey.KnownRecipient(it.id) } + destinations = listOf(ContactSearchKey.RecipientSearchKey.Story(myStoryRecipientId)) ) .show(conversationActivity.supportFragmentManager) } // Uncomment to make dialog stay on screen, otherwise will show/dismiss immediately - // ThreadUtil.sleep(15000) + // ThreadUtil.sleep( 30000) } } diff --git a/app/src/main/java/org/thoughtcrime/securesms/safety/review/SafetyNumberReviewConnectionsFragment.kt b/app/src/main/java/org/thoughtcrime/securesms/safety/review/SafetyNumberReviewConnectionsFragment.kt index 0494dc6fc..fd48736a2 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/safety/review/SafetyNumberReviewConnectionsFragment.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/safety/review/SafetyNumberReviewConnectionsFragment.kt @@ -55,9 +55,10 @@ class SafetyNumberReviewConnectionsFragment : DSLSettingsFragment( private fun getConfiguration(state: SafetyNumberBottomSheetState): DSLConfiguration { return configure { + val recipientCount = state.destinationToRecipientMap.values.flatten().size textPref( title = DSLSettingsText.from( - getString(R.string.SafetyNumberReviewConnectionsFragment__d_recipients_may_have, state.destinationToRecipientMap.values.flatten().size), + resources.getQuantityString(R.plurals.SafetyNumberReviewConnectionsFragment__d_recipients_may_have, recipientCount, recipientCount), DSLSettingsText.TextAppearanceModifier(R.style.Signal_Text_BodyMedium), DSLSettingsText.ColorModifier(ContextCompat.getColor(requireContext(), R.color.signal_colorOnSurfaceVariant)) ) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index d07e12097..bc3e9ad7d 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -4839,7 +4839,7 @@ View more Visit link - + %1$s · %2$d day duration %1$s · %2$d day duration @@ -4983,7 +4983,10 @@ Safety number changes - %1$d recipients may have reinstalled Signal or changed devices. Tap a recipient to confirm the new safety number. This is optional. + + %1$d recipient may have reinstalled Signal or changed devices. Tap a recipient to confirm the new safety number. This is optional. + %1$d recipients may have reinstalled Signal or changed devices. Tap a recipient to confirm the new safety number. This is optional. + Contacts