From c56564014b37f5fa90c324fa3bdb3733e804b5d7 Mon Sep 17 00:00:00 2001 From: Alex Hart Date: Fri, 3 Mar 2023 13:26:42 -0400 Subject: [PATCH] Add ktlint checking to :build-logic:plugins and split buildQa out into its own task for readability. --- build-logic/plugins/build.gradle.kts | 8 ++++++++ build.gradle | 11 +++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/build-logic/plugins/build.gradle.kts b/build-logic/plugins/build.gradle.kts index a651c2a53..55387e70e 100644 --- a/build-logic/plugins/build.gradle.kts +++ b/build-logic/plugins/build.gradle.kts @@ -26,3 +26,11 @@ dependencies { implementation(files(libs.javaClass.superclass.protectionDomain.codeSource.location)) implementation(files(testLibs.javaClass.superclass.protectionDomain.codeSource.location)) } + +ktlint { + filter { + exclude { element -> + element.file.path.contains("/build/generated-sources") + } + } +} diff --git a/build.gradle b/build.gradle index 75719d187..3f58773e0 100644 --- a/build.gradle +++ b/build.gradle @@ -60,12 +60,19 @@ subprojects { } } +task buildQa { + group 'Verification' + description 'Quality Assurance for build logic.' + dependsOn gradle.includedBuild('build-logic').task(':tools:test'), + gradle.includedBuild('build-logic').task(':tools:ktlintCheck'), + gradle.includedBuild('build-logic').task(':plugins:ktlintCheck') +} + task qa { group 'Verification' description 'Quality Assurance. Run before pushing.' dependsOn 'clean', - gradle.includedBuild('build-logic').task(':tools:test'), - gradle.includedBuild('build-logic').task(':tools:ktlintCheck'), + 'buildQa', ':Signal-Android:testPlayProdReleaseUnitTest', ':Signal-Android:lintPlayProdRelease', 'Signal-Android:ktlintCheck',