From c06056d8478b9b5ac249cef93e2e4ab78f46f9df Mon Sep 17 00:00:00 2001 From: Fumiaki Yoshimatsu Date: Fri, 25 Jun 2021 16:40:38 -0400 Subject: [PATCH] Force LTR layout in this view because the "playback" button should not be mirrored in RTL. In this specific case, the drawable (triangle_right) used in this view is _not_ autoMirrored which is correct. But the `layout_marginStart` attribute adds the margin to the wrong side of the view that breaks the appearance. c.f. https://material.io/design/usability/bidirectionality.html#mirroring-elements --- .../res/drawable-ldrtl-hdpi/ic_arrow_right.webp | Bin 0 -> 168 bytes .../res/drawable-ldrtl-xhdpi/ic_arrow_right.webp | Bin 0 -> 162 bytes .../res/drawable-ldrtl-xxhdpi/ic_arrow_right.webp | Bin 0 -> 190 bytes .../drawable-ldrtl-xxxhdpi/ic_arrow_right.webp | Bin 0 -> 196 bytes .../main/res/layout/mediapicker_media_item.xml | 1 + 5 files changed, 1 insertion(+) create mode 100644 app/src/main/res/drawable-ldrtl-hdpi/ic_arrow_right.webp create mode 100644 app/src/main/res/drawable-ldrtl-xhdpi/ic_arrow_right.webp create mode 100644 app/src/main/res/drawable-ldrtl-xxhdpi/ic_arrow_right.webp create mode 100644 app/src/main/res/drawable-ldrtl-xxxhdpi/ic_arrow_right.webp diff --git a/app/src/main/res/drawable-ldrtl-hdpi/ic_arrow_right.webp b/app/src/main/res/drawable-ldrtl-hdpi/ic_arrow_right.webp new file mode 100644 index 0000000000000000000000000000000000000000..f2ae8895fad781e82c19538dff55f29354b06ad1 GIT binary patch literal 168 zcmWIYbaPw4z`zjh>J$(bU=hIuWD5YXG8j4f1b74hd5rQ30t#y^KH8@$D>dob=-#}c)PLuFp)Z$))>M!~<~x3}>s`@ek3^QO!FR>yL=z%L=@0dFi${xRk3;uKDv zv?))eo-N~V&9P|=K${e_faV%7Gt6bwQejYGu$$;H-+Sp2rG<+-7&ZuTW->5HH}19L OV_^9AJ$(bU=hIuWD5YXJ{URr1bBD?d5r1~6LO7PXYzbKcD7U|C};sqG+<_!%cy0*V8CEE(PO^%(j`g@7k4mh5aP^aV32OyYsbgH@bAaD IzZwh-0P90EvH$=8 literal 0 HcmV?d00001 diff --git a/app/src/main/res/drawable-ldrtl-xxhdpi/ic_arrow_right.webp b/app/src/main/res/drawable-ldrtl-xxhdpi/ic_arrow_right.webp new file mode 100644 index 0000000000000000000000000000000000000000..eca60e5203e111bcc34fb17414eb8fcbb8280a2f GIT binary patch literal 190 zcmWIYbaUIrz`zjh>J$(bU=hIuWD5YXI~Y0o1bD;%d5roF6LO7Pf1Z}fWV_zc@nGG8 zZMn+FcktSME&ngv@^|{~PsJHZzt(Tdm3EW!n#5ehY_{kI)4D4SNkPozYQfCmQae2F zpA?L;*i)r^Yl@=ZjlZVBQ4vy4+8vL4Vg=f&U;?t0g<&qEmIs3egWW`rg+5D{C@U#? kFl-Rw%w%BT{J7YySIQ*g;$pWt28Mq>&VBR%>R@010PY1r>;M1& literal 0 HcmV?d00001 diff --git a/app/src/main/res/drawable-ldrtl-xxxhdpi/ic_arrow_right.webp b/app/src/main/res/drawable-ldrtl-xxxhdpi/ic_arrow_right.webp new file mode 100644 index 0000000000000000000000000000000000000000..e4cec78bc22f6191d3efc7538a0df9f7906ada9f GIT binary patch literal 196 zcmWIYbaUIoz`zjh>J$(bU=hIuWD5XsJQz9p1b9RPd5r1~6LO7Pf1c)f$#%V?09kGy4ZH}pqKEPki@qKvwj)x zxG+op$?Z>_jLZKxyx7RozV!5^mX&e$BpHCVDp&#S*ucUtmr*N$A%VeeqQ^p?rAw5R r6kafF5aP^aU|=r`t=W5Q-lzQKesir#US6(YVEFgr+`D%`Z9o73D;`Ve literal 0 HcmV?d00001 diff --git a/app/src/main/res/layout/mediapicker_media_item.xml b/app/src/main/res/layout/mediapicker_media_item.xml index a384c986c..8062cd9de 100644 --- a/app/src/main/res/layout/mediapicker_media_item.xml +++ b/app/src/main/res/layout/mediapicker_media_item.xml @@ -34,6 +34,7 @@ android:layout_marginStart="2dp" android:tint="@color/core_ultramarine" android:scaleType="fitXY" + android:layoutDirection="ltr" app:srcCompat="@drawable/triangle_right" />