From ba1055df8edae0b8b6a7e98b5a08ed13675d9dae Mon Sep 17 00:00:00 2001
From: Moxie Marlinspike <moxie@thoughtcrime.org>
Date: Fri, 13 Jun 2014 15:23:44 -0700
Subject: [PATCH] Correct contextual send language.

1) Use "secure" and "insecure" vs "encrypted" and "unencrypted.

2) Use MMS instead of SMS where appropriate.

Fixes #1602
---
 ...sh.xml => conversation_button_context.xml} |  9 +++++--
 ...versation_button_context_insecure_push.xml |  8 -------
 ...conversation_button_context_secure_sms.xml |  8 -------
 res/values/strings.xml                        |  6 +++--
 .../securesms/ConversationActivity.java       | 24 ++++++++++++++-----
 5 files changed, 29 insertions(+), 26 deletions(-)
 rename res/menu/{conversation_button_context_secure_push.xml => conversation_button_context.xml} (60%)
 delete mode 100644 res/menu/conversation_button_context_insecure_push.xml
 delete mode 100644 res/menu/conversation_button_context_secure_sms.xml

diff --git a/res/menu/conversation_button_context_secure_push.xml b/res/menu/conversation_button_context.xml
similarity index 60%
rename from res/menu/conversation_button_context_secure_push.xml
rename to res/menu/conversation_button_context.xml
index 7c60057cf..ea6978615 100644
--- a/res/menu/conversation_button_context_secure_push.xml
+++ b/res/menu/conversation_button_context.xml
@@ -3,8 +3,13 @@
 <menu xmlns:android="http://schemas.android.com/apk/res/android">
     <item android:title="@string/conversation_button_context__send_textsecure_message"
           android:id="@+id/menu_context_send_push" />
-    <item android:title="@string/conversation_button_context__send_encrypted_sms"
+    <item android:title="@string/conversation_button_context__send_secure_sms"
           android:id="@+id/menu_context_send_encrypted_sms" />
-    <item android:title="@string/conversation_button_context__send_unencrypted_sms"
+    <item android:title="@string/conversation_button_context__send_insecure_sms"
           android:id="@+id/menu_context_send_unencrypted_sms" />
+    <item android:title="@string/conversation_button_context__send_secure_mms"
+          android:id="@+id/menu_context_send_encrypted_mms" />
+    <item android:title="@string/conversation_button_context__send_insecure_mms"
+          android:id="@+id/menu_context_send_unencrypted_mms" />
+
 </menu>
\ No newline at end of file
diff --git a/res/menu/conversation_button_context_insecure_push.xml b/res/menu/conversation_button_context_insecure_push.xml
deleted file mode 100644
index 81dcf7419..000000000
--- a/res/menu/conversation_button_context_insecure_push.xml
+++ /dev/null
@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-
-<menu xmlns:android="http://schemas.android.com/apk/res/android">
-    <item android:title="@string/conversation_button_context__send_textsecure_message"
-          android:id="@+id/menu_context_send_push" />
-    <item android:title="@string/conversation_button_context__send_unencrypted_sms"
-          android:id="@+id/menu_context_send_unencrypted_sms" />
-</menu>
\ No newline at end of file
diff --git a/res/menu/conversation_button_context_secure_sms.xml b/res/menu/conversation_button_context_secure_sms.xml
deleted file mode 100644
index 457505e7b..000000000
--- a/res/menu/conversation_button_context_secure_sms.xml
+++ /dev/null
@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-
-<menu xmlns:android="http://schemas.android.com/apk/res/android">
-    <item android:title="@string/conversation_button_context__send_encrypted_sms"
-          android:id="@+id/menu_context_send_encrypted_sms" />
-    <item android:title="@string/conversation_button_context__send_unencrypted_sms"
-          android:id="@+id/menu_context_send_unencrypted_sms" />
-</menu>
\ No newline at end of file
diff --git a/res/values/strings.xml b/res/values/strings.xml
index 8f4782d73..85939a004 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -787,8 +787,10 @@
 
     <!-- conversation_button_context -->
     <string name="conversation_button_context__send_textsecure_message">Send TextSecure message</string>
-    <string name="conversation_button_context__send_unencrypted_sms">Send unencrypted SMS</string>
-    <string name="conversation_button_context__send_encrypted_sms">Send encrypted SMS</string>
+    <string name="conversation_button_context__send_secure_sms">Send secure SMS</string>
+    <string name="conversation_button_context__send_insecure_sms">Send insecure SMS</string>
+    <string name="conversation_button_context__send_secure_mms">Send secure MMS</string>
+    <string name="conversation_button_context__send_insecure_mms">Send insecure MMS</string>
 
     <!-- conversation_callable -->
     <string name="conversation_callable__menu_call">Call</string>
diff --git a/src/org/thoughtcrime/securesms/ConversationActivity.java b/src/org/thoughtcrime/securesms/ConversationActivity.java
index e6a6257a3..b3acf3a35 100644
--- a/src/org/thoughtcrime/securesms/ConversationActivity.java
+++ b/src/org/thoughtcrime/securesms/ConversationActivity.java
@@ -322,14 +322,24 @@ public class ConversationActivity extends PassphraseRequiredSherlockFragmentActi
       Recipient primaryRecipient  = getRecipients() == null ? null : getRecipients().getPrimaryRecipient();
       boolean   hasSession        = Session.hasSession(this, masterSecret, primaryRecipient);
 
-      int context;
+      getMenuInflater().inflate(R.menu.conversation_button_context, menu);
 
-      if      (isPushDestination && hasSession) context = R.menu.conversation_button_context_secure_push;
-      else if (isPushDestination)               context = R.menu.conversation_button_context_insecure_push;
-      else if (hasSession)                      context = R.menu.conversation_button_context_secure_sms;
-      else                                      return;
+      if (attachmentManager.isAttachmentPresent()) {
+        menu.removeItem(R.id.menu_context_send_encrypted_sms);
+        menu.removeItem(R.id.menu_context_send_unencrypted_sms);
+      } else {
+        menu.removeItem(R.id.menu_context_send_encrypted_mms);
+        menu.removeItem(R.id.menu_context_send_unencrypted_mms);
+      }
 
-      getMenuInflater().inflate(context, menu);
+      if (!isPushDestination) {
+        menu.removeItem(R.id.menu_context_send_push);
+      }
+
+      if (!hasSession) {
+        menu.removeItem(R.id.menu_context_send_encrypted_mms);
+        menu.removeItem(R.id.menu_context_send_encrypted_sms);
+      }
     }
   }
 
@@ -337,7 +347,9 @@ public class ConversationActivity extends PassphraseRequiredSherlockFragmentActi
   public boolean onContextItemSelected(android.view.MenuItem item) {
     switch (item.getItemId()) {
       case R.id.menu_context_send_push:            sendMessage(false, false); return true;
+      case R.id.menu_context_send_encrypted_mms:
       case R.id.menu_context_send_encrypted_sms:   sendMessage(false, true);  return true;
+      case R.id.menu_context_send_unencrypted_mms:
       case R.id.menu_context_send_unencrypted_sms: sendMessage(true, true);   return true;
     }