Add additional logging around attachment upload/deletion.

fork-5.53.8
Greyson Parrelli 2019-10-22 10:52:55 -04:00
rodzic cee6736656
commit b281b817ba
2 zmienionych plików z 10 dodań i 2 usunięć

Wyświetl plik

@ -293,6 +293,8 @@ public class AttachmentDatabase extends Database {
@SuppressWarnings("ResultOfMethodCallIgnored")
public void deleteAttachmentsForMessage(long mmsId) {
Log.d(TAG, "[deleteAttachmentsForMessage] mmsId: " + mmsId);
SQLiteDatabase database = databaseHelper.getWritableDatabase();
Cursor cursor = null;
@ -317,6 +319,8 @@ public class AttachmentDatabase extends Database {
}
public void deleteAttachmentFilesForMessage(long mmsId) {
Log.d(TAG, "[deleteAttachmentFilesForMessage] mmsId: " + mmsId);
SQLiteDatabase database = databaseHelper.getWritableDatabase();
Cursor cursor = null;
@ -360,6 +364,8 @@ public class AttachmentDatabase extends Database {
public void deleteAttachment(@NonNull AttachmentId id) {
Log.d(TAG, "[deleteAttachment] attachmentId: " + id);
SQLiteDatabase database = databaseHelper.getWritableDatabase();
try (Cursor cursor = database.query(TABLE_NAME,
@ -408,9 +414,9 @@ public class AttachmentDatabase extends Database {
boolean dataInUse = isDataUsedByAnotherAttachment(data, attachmentId);
if (dataInUse) {
Log.i(TAG, "[deleteAttachmentOnDisk] Attachment in use. Skipping deletion. " + data);
Log.i(TAG, "[deleteAttachmentOnDisk] Attachment in use. Skipping deletion. " + data + " " + attachmentId);
} else {
Log.i(TAG, "[deleteAttachmentOnDisk] No other users of this attachment. Safe to delete. " + data);
Log.i(TAG, "[deleteAttachmentOnDisk] No other users of this attachment. Safe to delete. " + data + " " + attachmentId);
}
if (!TextUtils.isEmpty(data) && !dataInUse) {

Wyświetl plik

@ -95,6 +95,8 @@ public final class AttachmentUploadJob extends BaseJob {
throw new InvalidAttachmentException("Cannot find the specified attachment.");
}
Log.i(TAG, "Uploading attachment for message " + databaseAttachment.getMmsId() + " with ID " + databaseAttachment.getAttachmentId());
try (NotificationController notification = getNotificationForAttachment(databaseAttachment)) {
SignalServiceAttachment localAttachment = getAttachmentFor(databaseAttachment, notification);
SignalServiceAttachmentPointer remoteAttachment = messageSender.uploadAttachment(localAttachment.asStream());