From 852ca2ac05890a96613e855c3c62ef969543661c Mon Sep 17 00:00:00 2001 From: Matt Enright Date: Wed, 26 Feb 2014 21:57:17 -0500 Subject: [PATCH] Don't display sender in outgoing message details Because we don't know it. Fixes WhisperSystems#711. --- res/values/strings.xml | 2 +- src/org/thoughtcrime/securesms/ConversationFragment.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 89298a953..6de0db720 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -86,7 +86,7 @@ Message details - Sender: %1$s\nTransport: %2$s\nSent/Received:%3$s + Transport: %1$s\nSent/Received:%2$s Sender: %1$s\nTransport: %2$s\nSent: %3$s\nReceived:%4$s Confirm Message Delete Are you sure that you want to permanently delete this message? diff --git a/src/org/thoughtcrime/securesms/ConversationFragment.java b/src/org/thoughtcrime/securesms/ConversationFragment.java index 4c52c4659..6ff0e2973 100644 --- a/src/org/thoughtcrime/securesms/ConversationFragment.java +++ b/src/org/thoughtcrime/securesms/ConversationFragment.java @@ -136,7 +136,6 @@ public class ConversationFragment extends SherlockListFragment } private void handleDisplayDetails(MessageRecord message) { - String sender = message.getIndividualRecipient().getNumber(); long dateReceived = message.getDateReceived(); long dateSent = message.getDateSent(); @@ -156,12 +155,13 @@ public class ConversationFragment extends SherlockListFragment if (dateReceived == dateSent || message.isOutgoing()) { builder.setMessage(String.format(getSherlockActivity() .getString(R.string.ConversationFragment_sender_s_transport_s_sent_received_s), - sender, transport.toUpperCase(), + transport.toUpperCase(), dateFormatter.format(new Date(dateSent)))); } else { builder.setMessage(String.format(getSherlockActivity() .getString(R.string.ConversationFragment_sender_s_transport_s_sent_s_received_s), - sender, transport.toUpperCase(), + message.getIndividualRecipient().getNumber(), + transport.toUpperCase(), dateFormatter.format(new Date(dateSent)), dateFormatter.format(new Date(dateReceived)))); }