From 69a1fa0d3c3f23716f4fe3405792eeb516f8d848 Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Fri, 12 Feb 2021 12:39:45 -0500 Subject: [PATCH] Remove database transaction protections for job manager interactions. Now that the JobDatabase is a separate physical database, we no longer have to worry about people enqueuing jobs while in a transaction. --- .../securesms/jobmanager/JobManager.java | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/jobmanager/JobManager.java b/app/src/main/java/org/thoughtcrime/securesms/jobmanager/JobManager.java index 380d9711c..e95a1241c 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/jobmanager/JobManager.java +++ b/app/src/main/java/org/thoughtcrime/securesms/jobmanager/JobManager.java @@ -58,17 +58,7 @@ public class JobManager implements ConstraintObserver.Notifier { public JobManager(@NonNull Application application, @NonNull Configuration configuration) { this.application = application; this.configuration = configuration; - this.executor = new FilteredExecutor(configuration.getExecutorFactory().newSingleThreadExecutor("signal-JobManager"), - () -> { - if (Util.isMainThread()) { - return true; - } else if (DatabaseFactory.inTransaction(application)) { - Log.w(TAG, "Tried to add a job while in a transaction!", new Throwable()); - return true; - } else { - return false; - } - }); + this.executor = new FilteredExecutor(configuration.getExecutorFactory().newSingleThreadExecutor("signal-JobManager"), Util::isMainThread); this.jobTracker = configuration.getJobTracker(); this.jobController = new JobController(application, configuration.getJobStorage(),