From 45d010bdb67fabf21ef785aaf23dddc190954399 Mon Sep 17 00:00:00 2001 From: Greyson Parrelli Date: Wed, 12 May 2021 17:15:59 -0400 Subject: [PATCH] Only update SMS setting if registration is complete. Otherwise you could crash during registration if the user had previously set Signal as the default. --- .../org/thoughtcrime/securesms/keyvalue/SettingsValues.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/keyvalue/SettingsValues.java b/app/src/main/java/org/thoughtcrime/securesms/keyvalue/SettingsValues.java index 6bb27551c..d1fbb22b3 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/keyvalue/SettingsValues.java +++ b/app/src/main/java/org/thoughtcrime/securesms/keyvalue/SettingsValues.java @@ -359,7 +359,7 @@ public final class SettingsValues extends SignalStoreValues { public void setDefaultSms(boolean value) { boolean lastKnown = getBoolean(DEFAULT_SMS, false); - if (value != lastKnown) { + if (value != lastKnown && SignalStore.registrationValues().isRegistrationComplete()) { Log.i(TAG, "Default SMS state changed! Scheduling a storage sync."); putBoolean(DEFAULT_SMS, value);