From 288b4169889f904dc2e4b58efd647fe3c2c9e6e1 Mon Sep 17 00:00:00 2001 From: Moxie Marlinspike Date: Tue, 25 Jun 2013 13:20:29 -0700 Subject: [PATCH] Fix NPEs --- src/org/thoughtcrime/securesms/ConversationListItem.java | 3 ++- .../thoughtcrime/securesms/crypto/KeyExchangeProcessor.java | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/org/thoughtcrime/securesms/ConversationListItem.java b/src/org/thoughtcrime/securesms/ConversationListItem.java index 51a42a7e2..9d8a86657 100644 --- a/src/org/thoughtcrime/securesms/ConversationListItem.java +++ b/src/org/thoughtcrime/securesms/ConversationListItem.java @@ -113,7 +113,8 @@ public class ConversationListItem extends RelativeLayout } public void unbind() { - this.recipients.removeListener(this); + if (this.recipients != null) + this.recipients.removeListener(this); } private void initializeContactWidgetVisibility() { diff --git a/src/org/thoughtcrime/securesms/crypto/KeyExchangeProcessor.java b/src/org/thoughtcrime/securesms/crypto/KeyExchangeProcessor.java index 3aa97481b..42a7bde14 100644 --- a/src/org/thoughtcrime/securesms/crypto/KeyExchangeProcessor.java +++ b/src/org/thoughtcrime/securesms/crypto/KeyExchangeProcessor.java @@ -111,8 +111,10 @@ public class KeyExchangeProcessor { sessionRecord.save(); - DatabaseFactory.getIdentityDatabase(context) - .saveIdentity(masterSecret, recipient, message.getIdentityKey()); + if (message.hasIdentityKey()) { + DatabaseFactory.getIdentityDatabase(context) + .saveIdentity(masterSecret, recipient, message.getIdentityKey()); + } DecryptingQueue.scheduleRogueMessages(context, masterSecret, recipient);