From 22e97457a3689a6ece4b59e228e84493fc0bcc27 Mon Sep 17 00:00:00 2001 From: AsamK Date: Thu, 6 Oct 2022 21:43:52 +0200 Subject: [PATCH] Fix sending normal group messages when falling back to socket. In the sendGroupMessage message the socket fallback for sending normal group messages always set the story parameter to true. This causes the message to be discarded by the receivers, because it has a story envelope, but no story content > Envelope was flagged as a story, but it did not have any story-related content! Dropping. Issue was introduced in 3895578d5188c7d2ef3378d61d7a9aa6efa03928 Closes #12496 --- .../signalservice/api/SignalServiceMessageSender.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java index a8a86a4b6..9566b8c4c 100644 --- a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java +++ b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java @@ -1968,7 +1968,7 @@ public class SignalServiceMessageSender { Log.w(TAG, "[sendGroupMessage][" + timestamp + "] Pipe failed, falling back... (" + e.getClass().getSimpleName() + ": " + e.getMessage() + ")"); } - SendGroupMessageResponse response = socket.sendGroupMessage(ciphertext, joinedUnidentifiedAccess, timestamp, online, urgent, true); + SendGroupMessageResponse response = socket.sendGroupMessage(ciphertext, joinedUnidentifiedAccess, timestamp, online, urgent, story); return transformGroupResponseToMessageResults(targetInfo.devices, response, content); } catch (GroupMismatchedDevicesException e) { Log.w(TAG, "[sendGroupMessage][" + timestamp + "] Handling mismatched devices. (" + e.getMessage() + ")");