From 2200af9c31ddcffca20c6e443d4347c2958fc33a Mon Sep 17 00:00:00 2001 From: Alex Hart Date: Thu, 17 Nov 2022 12:33:29 -0400 Subject: [PATCH] Remove background highlighting from empty lines in image editor. Co-Authored-By: GitStart <1501599+gitstart@users.noreply.github.com> Fixes #12612 --- .../core/renderers/MultiLineTextRenderer.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/image-editor/lib/src/main/java/org/signal/imageeditor/core/renderers/MultiLineTextRenderer.java b/image-editor/lib/src/main/java/org/signal/imageeditor/core/renderers/MultiLineTextRenderer.java index 1b88904ae..14999ed30 100644 --- a/image-editor/lib/src/main/java/org/signal/imageeditor/core/renderers/MultiLineTextRenderer.java +++ b/image-editor/lib/src/main/java/org/signal/imageeditor/core/renderers/MultiLineTextRenderer.java @@ -320,10 +320,14 @@ public final class MultiLineTextRenderer extends InvalidateableRenderer implemen rendererContext.canvasMatrix.concat(projectionMatrix); if (mode == Mode.HIGHLIGHT) { - modeBounds.set(textBounds.left - HIGHLIGHT_HORIZONTAL_PADDING, - selectionBounds.top - HIGHLIGHT_TOP_PADDING, - textBounds.right + HIGHLIGHT_HORIZONTAL_PADDING, - selectionBounds.bottom + HIGHLIGHT_BOTTOM_PADDING); + if(text.isEmpty()){ + modeBounds.setEmpty(); + }else{ + modeBounds.set(textBounds.left - HIGHLIGHT_HORIZONTAL_PADDING, + selectionBounds.top - HIGHLIGHT_TOP_PADDING, + textBounds.right + HIGHLIGHT_HORIZONTAL_PADDING, + selectionBounds.bottom + HIGHLIGHT_BOTTOM_PADDING); + } int alpha = modePaint.getAlpha(); modePaint.setAlpha(rendererContext.getAlpha(alpha)); rendererContext.canvas.drawRoundRect(modeBounds, HIGHLIGHT_CORNER_RADIUS, HIGHLIGHT_CORNER_RADIUS, modePaint);