diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationActivity.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationActivity.java index 8db9c8482..40c05789a 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationActivity.java +++ b/app/src/main/java/org/thoughtcrime/securesms/conversation/ConversationActivity.java @@ -931,9 +931,7 @@ public class ConversationActivity extends PassphraseRequiredActivity inflater.inflate(R.menu.conversation, menu); - if (isSingleConversation() && isSecureText) { - inflater.inflate(R.menu.conversation_secure, menu); - } else if (isSingleConversation()) { + if (isSingleConversation() && !isSecureText) { inflater.inflate(R.menu.conversation_insecure, menu); } @@ -1070,7 +1068,6 @@ public class ConversationActivity extends PassphraseRequiredActivity case R.id.menu_add_shortcut: handleAddShortcut(); return true; case R.id.menu_search: handleSearch(); return true; case R.id.menu_add_to_contacts: handleAddToContacts(); return true; - case R.id.menu_reset_secure_session: handleResetSecureSession(); return true; case R.id.menu_group_recipients: handleDisplayGroupRecipients(); return true; case R.id.menu_distribution_broadcast: handleDistributionBroadcastEnabled(item); return true; case R.id.menu_distribution_conversation: handleDistributionConversationEnabled(item); return true; @@ -1264,36 +1261,6 @@ public class ConversationActivity extends PassphraseRequiredActivity } } - private void handleResetSecureSession() { - AlertDialog.Builder builder = new AlertDialog.Builder(this); - builder.setTitle(R.string.ConversationActivity_reset_secure_session_question); - builder.setIcon(R.drawable.ic_warning); - builder.setCancelable(true); - builder.setMessage(R.string.ConversationActivity_this_may_help_if_youre_having_encryption_problems); - builder.setPositiveButton(R.string.ConversationActivity_reset, (dialog, which) -> { - if (isSingleConversation()) { - final Context context = getApplicationContext(); - - OutgoingEndSessionMessage endSessionMessage = - new OutgoingEndSessionMessage(new OutgoingTextMessage(getRecipient(), "TERMINATE", 0, -1)); - - new AsyncTask() { - @Override - protected Long doInBackground(OutgoingEndSessionMessage... messages) { - return MessageSender.send(context, messages[0], threadId, false, null, null); - } - - @Override - protected void onPostExecute(Long result) { - sendComplete(result); - } - }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR, endSessionMessage); - } - }); - builder.setNegativeButton(android.R.string.cancel, null); - builder.show(); - } - private void handleViewMedia() { startActivity(MediaOverviewActivity.forThread(this, threadId)); } diff --git a/app/src/main/res/menu/conversation_secure.xml b/app/src/main/res/menu/conversation_secure.xml deleted file mode 100644 index bec5124df..000000000 --- a/app/src/main/res/menu/conversation_secure.xml +++ /dev/null @@ -1,5 +0,0 @@ - - - - \ No newline at end of file diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 629aa9c96..a5a040acd 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -220,9 +220,6 @@ You deleted this message. - Reset secure session? - This may help if you\'re having encryption problems in this conversation. Your messages will be kept. - Reset Add attachment Select contact info Compose message diff --git a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java index 3fb510cdd..b73b1c740 100644 --- a/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java +++ b/libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java @@ -346,19 +346,6 @@ public class SignalServiceMessageSender { sendEvents.onSyncMessageSent(); - // TODO [greyson][session] Delete this when we delete the button - if (message.isEndSession()) { - store.deleteAllSessions(recipient.getUuid().toString()); - - if (recipient.getNumber().isPresent()) { - store.deleteAllSessions(recipient.getNumber().get()); - } - - if (eventListener.isPresent()) { - eventListener.get().onSecurityEvent(recipient); - } - } - return result; }