Revert "Fix ANR when leaving MediaPreviewActivity."

This reverts commit 8be659c1c8.
fork-5.53.8
Cody Henthorne 2021-06-21 09:55:40 -04:00
rodzic 5f1454aeb8
commit 08f023fb12
2 zmienionych plików z 6 dodań i 13 usunięć

Wyświetl plik

@ -73,7 +73,6 @@ import org.thoughtcrime.securesms.sharing.ShareActivity;
import org.thoughtcrime.securesms.util.AttachmentUtil;
import org.thoughtcrime.securesms.util.DateUtils;
import org.thoughtcrime.securesms.util.FullscreenHelper;
import org.thoughtcrime.securesms.util.LifecycleCursorWrapper;
import org.thoughtcrime.securesms.util.SaveAttachmentTask;
import org.thoughtcrime.securesms.util.SaveAttachmentTask.Attachment;
import org.thoughtcrime.securesms.util.StorageUtil;
@ -129,7 +128,7 @@ public final class MediaPreviewActivity extends PassphraseRequiredActivity
private MediaDatabase.Sorting sorting;
private FullscreenHelper fullscreenHelper;
private @Nullable LifecycleCursorWrapper cursor = null;
private @Nullable Cursor cursor = null;
public static @NonNull Intent intentFromMediaRecord(@NonNull Context context,
@NonNull MediaRecord mediaRecord,
@ -249,7 +248,10 @@ public final class MediaPreviewActivity extends PassphraseRequiredActivity
@Override
protected void onDestroy() {
cursor = null;
if (cursor != null) {
cursor.close();
cursor = null;
}
super.onDestroy();
}
@ -547,11 +549,9 @@ public final class MediaPreviewActivity extends PassphraseRequiredActivity
}
if (cursor != null) {
getLifecycle().removeObserver(cursor);
cursor.close();
}
cursor = new LifecycleCursorWrapper(Objects.requireNonNull(data.first));
getLifecycle().addObserver(cursor);
cursor = Objects.requireNonNull(data.first);
int mediaPosition = Objects.requireNonNull(data.second);

Wyświetl plik

@ -8,8 +8,6 @@ import androidx.lifecycle.DefaultLifecycleObserver;
import androidx.lifecycle.Lifecycle;
import androidx.lifecycle.LifecycleOwner;
import org.signal.core.util.concurrent.SignalExecutors;
/**
* Wraps a {@link Cursor} that will be closed automatically when the {@link Lifecycle.Event}.ON_DESTROY
* is fired from the lifecycle this object is observing.
@ -24,9 +22,4 @@ public class LifecycleCursorWrapper extends CursorWrapper implements DefaultLife
public void onDestroy(@NonNull LifecycleOwner owner) {
close();
}
@Override
public void close() {
SignalExecutors.BOUNDED.execute(super::close);
}
}