From 330f4e8fe1c72a2bec00171d7a300c7c2092b4cb Mon Sep 17 00:00:00 2001 From: jgromes Date: Sun, 12 May 2024 12:04:19 +0100 Subject: [PATCH] [CRC] Fixed issues found by cppcheck --- src/utils/CRC.cpp | 2 +- src/utils/CRC.h | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/utils/CRC.cpp b/src/utils/CRC.cpp index 4422942b..ac7fb74f 100644 --- a/src/utils/CRC.cpp +++ b/src/utils/CRC.cpp @@ -4,7 +4,7 @@ RadioLibCRC::RadioLibCRC() { } -uint32_t RadioLibCRC::checksum(uint8_t* buff, size_t len) { +uint32_t RadioLibCRC::checksum(const uint8_t* buff, size_t len) { uint32_t crc = this->init; size_t pos = 0; for(size_t i = 0; i < 8*len; i++) { diff --git a/src/utils/CRC.h b/src/utils/CRC.h index 124fa49d..bec3d710 100644 --- a/src/utils/CRC.h +++ b/src/utils/CRC.h @@ -21,32 +21,32 @@ class RadioLibCRC { /*! \brief CRC size in bits. */ - uint8_t size; + uint8_t size = 8; /*! \brief CRC polynomial. */ - uint32_t poly; + uint32_t poly = 0; /*! \brief Initial value. */ - uint32_t init; + uint32_t init = 0; /*! \brief Final XOR value. */ - uint32_t out; + uint32_t out = 0; /*! \brief Whether to reflect input bytes. */ - bool refIn; + bool refIn = false; /*! \brief Whether to reflect the result. */ - bool refOut; + bool refOut = false; /*! \brief Default constructor. @@ -59,7 +59,7 @@ class RadioLibCRC { \param len Size of the buffer in bytes. \returns The resulting checksum. */ - uint32_t checksum(uint8_t* buff, size_t len); + uint32_t checksum(const uint8_t* buff, size_t len); }; // the global singleton