From 0f0ab73832062b4038f02f52fb00b880207ef756 Mon Sep 17 00:00:00 2001 From: jgromes Date: Sat, 11 May 2024 20:32:32 +0100 Subject: [PATCH] [EXT] Fixed issues found by cppcheck --- src/protocols/ExternalRadio/ExternalRadio.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/protocols/ExternalRadio/ExternalRadio.h b/src/protocols/ExternalRadio/ExternalRadio.h index 22a0c41e..8c551726 100644 --- a/src/protocols/ExternalRadio/ExternalRadio.h +++ b/src/protocols/ExternalRadio/ExternalRadio.h @@ -20,7 +20,7 @@ class ExternalRadio: public PhysicalLayer { \brief Default constructor. \param pin Output pin when using direct transmission, defaults to unused pin. */ - ExternalRadio(uint32_t pin = RADIOLIB_NC); + ExternalRadio(uint32_t pin = RADIOLIB_NC); // cppcheck-suppress noExplicitConstructor #endif /*! @@ -28,13 +28,13 @@ class ExternalRadio: public PhysicalLayer { \param hal Pointer to the hardware abstraction layer to use. \param pin Output pin when using direct transmission, defaults to unused pin. */ - ExternalRadio(RadioLibHal *hal, uint32_t pin = RADIOLIB_NC); + ExternalRadio(RadioLibHal *hal, uint32_t pin = RADIOLIB_NC); // cppcheck-suppress noExplicitConstructor /*! \brief Method to retrieve pointer to the underlying Module instance. \returns Pointer to the Module instance. */ - Module* getMod(); + Module* getMod() override; /*! \brief Dummy implementation overriding PhysicalLayer. @@ -63,7 +63,7 @@ class ExternalRadio: public PhysicalLayer { the output pin will be set to logic high. Otherwise it will be set to logic low. \returns \ref status_codes */ - int16_t transmitDirect(uint32_t frf = 0); + int16_t transmitDirect(uint32_t frf = 0) override; private: Module* mod;