From f5581504a06eb99d25f4b76ed1b2c7fcf31564d6 Mon Sep 17 00:00:00 2001 From: Piero Toffanin Date: Wed, 14 Aug 2019 09:36:54 -0400 Subject: [PATCH] More robust template tags --- app/templatetags/settings.py | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/app/templatetags/settings.py b/app/templatetags/settings.py index 02730331..03c50bcd 100644 --- a/app/templatetags/settings.py +++ b/app/templatetags/settings.py @@ -9,7 +9,12 @@ logger = logging.getLogger('app.logger') @register.simple_tag(takes_context=True) def settings_image_url(context, image): - img_cache = getattr(context['SETTINGS'], image) + try: + img_cache = getattr(context['SETTINGS'], image) + except KeyError: + logger.warning("Cannot get SETTINGS key from context. Something's wrong in settings_image_url.") + return '' + try: return "/media/" + img_cache.url except FileNotFoundError: @@ -18,7 +23,12 @@ def settings_image_url(context, image): @register.simple_tag(takes_context=True) def get_footer(context): - settings = context['SETTINGS'] + try: + settings = context['SETTINGS'] + except KeyError: + logger.warning("Cannot get SETTINGS key from context. The footer will not be displayed.") + return "" + if settings.theme.html_footer == "": return "" organization = ""