From e650185f9d31e98a77d2036b20b106e1b3ee76a7 Mon Sep 17 00:00:00 2001 From: Piero Toffanin Date: Mon, 28 Sep 2020 10:49:02 -0400 Subject: [PATCH 1/2] Try to estimate GSD for flipped Z axis datasets --- opendm/gsd.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/opendm/gsd.py b/opendm/gsd.py index 96668e96..f14e3bab 100644 --- a/opendm/gsd.py +++ b/opendm/gsd.py @@ -127,9 +127,7 @@ def opensfm_reconstruction_average_gsd(reconstruction_json, use_all_shots=False) camera['width'])) if len(gsds) > 0: - mean = np.mean(gsds) - if mean > 0: - return mean + return abs(np.mean(gsds)) return None From 99f0538fccf33b6521279ea7e69ad37783b94362 Mon Sep 17 00:00:00 2001 From: Piero Toffanin Date: Mon, 28 Sep 2020 10:51:35 -0400 Subject: [PATCH 2/2] Add warning on negative GSD estimate --- opendm/gsd.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/opendm/gsd.py b/opendm/gsd.py index f14e3bab..4f4b0bb0 100644 --- a/opendm/gsd.py +++ b/opendm/gsd.py @@ -127,7 +127,10 @@ def opensfm_reconstruction_average_gsd(reconstruction_json, use_all_shots=False) camera['width'])) if len(gsds) > 0: - return abs(np.mean(gsds)) + mean = np.mean(gsds) + if mean < 0: + log.ODM_WARNING("Negative GSD estimated, this might indicate a flipped Z-axis.") + return abs(mean) return None