From 78a1fdd6132775ab18664aa2d6149947b189ff73 Mon Sep 17 00:00:00 2001 From: charnesp Date: Thu, 22 Apr 2021 20:23:35 +0200 Subject: [PATCH] Avoid bug when `resize-to=1` in WebODM When `resize-to`is set to `-1` in WebODM (default case in WebODM), `resize_to_is_set`is equal to `-1`, thus `feature_process_size`is set to `-1` and opensfm works at full image size. This patch avoid it. --- opendm/osfm.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/opendm/osfm.py b/opendm/osfm.py index 8e337b1e..7f68ab99 100644 --- a/opendm/osfm.py +++ b/opendm/osfm.py @@ -157,7 +157,7 @@ class OSFMContext: # Compute feature_process_size feature_process_size = 2048 # default - if 'resize_to_is_set' in args: + if ('resize_to_is_set' in args) and (int(args.resize_to) != -1): # Legacy log.ODM_WARNING("Legacy option --resize-to (this might be removed in a future version). Use --feature-quality instead.") feature_process_size = int(args.resize_to) @@ -175,6 +175,7 @@ class OSFMContext: if max_dim > 0: log.ODM_INFO("Maximum photo dimensions: %spx" % str(max_dim)) feature_process_size = int(max_dim * feature_quality_scale[args.feature_quality]) + log.ODM_INFO("Photo dimensions for feature phase process: %i px" % feature_process_size) else: log.ODM_WARNING("Cannot compute max image dimensions, going with defaults")