refactor resize cell

scripts/resize.py

@@ -24,55 +24,54 @@ class ODMResizeCell(ecto.Cell):
         args = self.inputs.args
         photos = self.inputs.photos
         project_path = io.absolute_path_file(args['project_path'])
-        
-        # loop over photos array
-        if photos:
-            # create working directory
-            resizing_dir = io.join_paths(project_path, 'images_resize')
-            system.mkdir_p(resizing_dir)
 
-            log.ODM_DEBUG('Resizing dataset to: %s' % resizing_dir)
+        if not photos:
-
-            # loop over photos
-            for photo in photos:
-
-                # TODO(edgar): check if resize is needed, else copy img.
-                # Try to avoid oversampling!
-                new_path_file = io.join_paths(resizing_dir, photo.filename)
-
-                if not io.file_exists(new_path_file):
-                    # open and resize image with opencv
-                    img = cv2.imread(photo.path_file)
-                    # compute new size
-                    max_side = max(photo.width, photo.height) \
-                        if photo.width and photo.height \
-                        else max(img.shape[0], img.shape[0])
-                    ratio = float(args['resize_to']) / float(max_side)
-                    img_r = cv2.resize(img, None, fx=ratio, fy=ratio)
-                    # write image with opencv
-                    cv2.imwrite(new_path_file, img_r)
-                    # read metadata with pyexiv2
-                    old_meta = pyexiv2.ImageMetadata(photo.path_file)
-                    new_meta = pyexiv2.ImageMetadata(new_path_file)
-                    old_meta.read()
-                    new_meta.read()
-                    # copy metadata
-                    old_meta.copy(new_meta)
-                    new_meta.write()
-                    # update photos array with new values
-                    photo.path_file = new_path_file
-                    photo.width = img_r.shape[0]
-                    photo.height = img_r.shape[1]
-                    photo.update_focal()
-
-                    # log message
-                    log.ODM_DEBUG('Resized %s | dimensions: %s to %s' % \
-                        (photo.filename, img_r.shape, args['resize_to']))
-                else:
-                    log.ODM_WARNING('Already resized %s' % photo.filename)
-        else:
             log.ODM_ERROR('Not enough photos in photos to resize')
             return ecto.QUIT
+        
+        # create working directory
+        resizing_dir = io.join_paths(project_path, 'images_resize')
+        system.mkdir_p(resizing_dir)
+
+        log.ODM_DEBUG('Resizing dataset to: %s' % resizing_dir)
+
+        # loop over photos
+        for photo in photos:
+
+            # TODO(edgar): check if resize is needed, else copy img.
+            # Try to avoid oversampling!
+            new_path_file = io.join_paths(resizing_dir, photo.filename)
+
+            if not io.file_exists(new_path_file):
+                # open and resize image with opencv
+                img = cv2.imread(photo.path_file)
+                # compute new size
+                max_side = max(photo.width, photo.height) \
+                    if photo.width and photo.height \
+                    else max(img.shape[0], img.shape[0])
+                ratio = float(args['resize_to']) / float(max_side)
+                img_r = cv2.resize(img, None, fx=ratio, fy=ratio)
+                # write image with opencv
+                cv2.imwrite(new_path_file, img_r)
+                # read metadata with pyexiv2
+                old_meta = pyexiv2.ImageMetadata(photo.path_file)
+                new_meta = pyexiv2.ImageMetadata(new_path_file)
+                old_meta.read()
+                new_meta.read()
+                # copy metadata
+                old_meta.copy(new_meta)
+                new_meta.write()
+                # update photos array with new values
+                photo.path_file = new_path_file
+                photo.width = img_r.shape[0]
+                photo.height = img_r.shape[1]
+                photo.update_focal()
+
+                # log message
+                log.ODM_DEBUG('Resized %s | dimensions: %s to %s' % \
+                    (photo.filename, img_r.shape, args['resize_to']))
+            else:
+                log.ODM_WARNING('Already resized %s' % photo.filename)
 
         log.ODM_INFO('Resized %s images' % len(photos))