From 677c048f1bef31bd8b1630fa5a8f9007e60abc48 Mon Sep 17 00:00:00 2001 From: litetex <40789489+litetex@users.noreply.github.com> Date: Sat, 15 Feb 2025 14:23:33 +0100 Subject: [PATCH] Only include ``jsr305`` and not complete spotbugs Only ``javax.annotation.Nonull`` or ``javax.annotation.Nullable`` are currently in used which means that spotbugs can and should be removed. See https://github.com/TeamNewPipe/NewPipeExtractor/issues/1278 for details --- build.gradle | 2 +- extractor/build.gradle | 2 +- timeago-parser/build.gradle | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/build.gradle b/build.gradle index 05045214c..335960db4 100644 --- a/build.gradle +++ b/build.gradle @@ -28,7 +28,7 @@ allprojects { ext { nanojsonVersion = "1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751" - spotbugsVersion = "4.8.6" + jsr305Version = "3.0.2" junitVersion = "5.11.4" checkstyleVersion = "10.4" } diff --git a/extractor/build.gradle b/extractor/build.gradle index aab2494fe..4d8b5bc60 100644 --- a/extractor/build.gradle +++ b/extractor/build.gradle @@ -27,7 +27,7 @@ dependencies { implementation "com.github.TeamNewPipe:nanojson:$nanojsonVersion" implementation 'org.jsoup:jsoup:1.17.2' - implementation "com.github.spotbugs:spotbugs-annotations:$spotbugsVersion" + implementation "com.google.code.findbugs:jsr305:$jsr305Version" // do not upgrade to 1.7.14, since in 1.7.14 Rhino uses the `SourceVersion` class, which is not // available on Android (even when using desugaring), and `NoClassDefFoundError` is thrown diff --git a/timeago-parser/build.gradle b/timeago-parser/build.gradle index 7ccf00291..04dc5cab5 100644 --- a/timeago-parser/build.gradle +++ b/timeago-parser/build.gradle @@ -1,4 +1,4 @@ dependencies { implementation "com.github.TeamNewPipe:nanojson:$nanojsonVersion" - implementation "com.github.spotbugs:spotbugs-annotations:$spotbugsVersion" + implementation "com.google.code.findbugs:jsr305:$jsr305Version" }