From 9f7690823d805de1e1d3d13a46b1aa18984e0961 Mon Sep 17 00:00:00 2001 From: AudricV <74829229+AudricV@users.noreply.github.com> Date: Sat, 26 Jul 2025 23:39:10 +0200 Subject: [PATCH] [YouTube] Move Trending kiosk to kiosk package, add deprecation comment Trending is still working at the time this commit is made, it has been just removed from the interface. Also remove getInstance method of YoutubeTrendingLinkHandlerFactory to make the INSTANCE static field public, for consistency with other kiosks of the service. --- .../newpipe/extractor/services/youtube/YoutubeService.java | 5 +++-- .../extractors/{ => kiosk}/YoutubeTrendingExtractor.java | 3 ++- .../linkHandler/YoutubeTrendingLinkHandlerFactory.java | 6 +----- .../services/youtube/YoutubeKioskExtractorTest.java | 2 +- 4 files changed, 7 insertions(+), 9 deletions(-) rename extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/{ => kiosk}/YoutubeTrendingExtractor.java (98%) diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeService.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeService.java index fcdff3af6..08d8c5a0f 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeService.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeService.java @@ -35,7 +35,7 @@ import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExt import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor; import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSubscriptionExtractor; import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSuggestionExtractor; -import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeTrendingExtractor; +import org.schabi.newpipe.extractor.services.youtube.extractors.kiosk.YoutubeTrendingExtractor; import org.schabi.newpipe.extractor.services.youtube.extractors.kiosk.YoutubeLiveExtractor; import org.schabi.newpipe.extractor.services.youtube.extractors.kiosk.YoutubeTrendingGamingVideosExtractor; import org.schabi.newpipe.extractor.services.youtube.extractors.kiosk.YoutubeTrendingMoviesAndShowsTrailersExtractor; @@ -164,7 +164,7 @@ public class YoutubeService extends StreamingService { @Override public KioskList getKioskList() throws ExtractionException { final KioskList list = new KioskList(this); - final ListLinkHandlerFactory trendingLHF = YoutubeTrendingLinkHandlerFactory.getInstance(); + final ListLinkHandlerFactory trendingLHF = YoutubeTrendingLinkHandlerFactory.INSTANCE; final ListLinkHandlerFactory runningLivesLHF = YoutubeLiveLinkHandlerFactory.INSTANCE; final ListLinkHandlerFactory trendingPodcastsEpisodesLHF = @@ -218,6 +218,7 @@ public class YoutubeService extends StreamingService { trendingMusicLHF, YoutubeTrendingMusicLinkHandlerFactory.KIOSK_ID ); + // Deprecated (i.e. removed from the interface of YouTube) since July 21, 2025 list.addKioskEntry( (streamingService, url, id) -> new YoutubeTrendingExtractor( YoutubeService.this, diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeTrendingExtractor.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/kiosk/YoutubeTrendingExtractor.java similarity index 98% rename from extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeTrendingExtractor.java rename to extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/kiosk/YoutubeTrendingExtractor.java index 2976edc4d..4dd3c0435 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeTrendingExtractor.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/kiosk/YoutubeTrendingExtractor.java @@ -18,7 +18,7 @@ * along with NewPipe Extractor. If not, see . */ -package org.schabi.newpipe.extractor.services.youtube.extractors; +package org.schabi.newpipe.extractor.services.youtube.extractors.kiosk; import static org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getJsonPostResponse; import static org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getTextAtKey; @@ -36,6 +36,7 @@ import org.schabi.newpipe.extractor.exceptions.ParsingException; import org.schabi.newpipe.extractor.kiosk.KioskExtractor; import org.schabi.newpipe.extractor.linkhandler.ListLinkHandler; import org.schabi.newpipe.extractor.localization.TimeAgoParser; +import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamInfoItemExtractor; import org.schabi.newpipe.extractor.stream.StreamInfoItem; import org.schabi.newpipe.extractor.stream.StreamInfoItemsCollector; diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeTrendingLinkHandlerFactory.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeTrendingLinkHandlerFactory.java index 778eb1199..a43c3d062 100644 --- a/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeTrendingLinkHandlerFactory.java +++ b/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeTrendingLinkHandlerFactory.java @@ -33,16 +33,12 @@ import java.util.List; public final class YoutubeTrendingLinkHandlerFactory extends ListLinkHandlerFactory { - private static final YoutubeTrendingLinkHandlerFactory INSTANCE = + public static final YoutubeTrendingLinkHandlerFactory INSTANCE = new YoutubeTrendingLinkHandlerFactory(); private YoutubeTrendingLinkHandlerFactory() { } - public static YoutubeTrendingLinkHandlerFactory getInstance() { - return INSTANCE; - } - public String getUrl(final String id, final List contentFilters, final String sortFilter) diff --git a/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeKioskExtractorTest.java b/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeKioskExtractorTest.java index 766fb0944..1c92fc664 100644 --- a/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeKioskExtractorTest.java +++ b/extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeKioskExtractorTest.java @@ -9,7 +9,7 @@ import org.junit.jupiter.api.Test; import org.schabi.newpipe.extractor.exceptions.ParsingException; import org.schabi.newpipe.extractor.services.BaseListExtractorTest; import org.schabi.newpipe.extractor.services.DefaultSimpleExtractorTest; -import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeTrendingExtractor; +import org.schabi.newpipe.extractor.services.youtube.extractors.kiosk.YoutubeTrendingExtractor; public class YoutubeKioskExtractorTest {