From 2afee89de374717f50ef930635c67092ea348fdf Mon Sep 17 00:00:00 2001
From: Christian Schabesberger <chris.schabesberger@mailbox.org>
Date: Thu, 26 Nov 2015 18:47:36 +0100
Subject: [PATCH] added contentDescription for better accesebility

---
 app/src/main/res/layout-land/fragment_videoitem_detail.xml | 4 ++++
 .../main/res/layout-sw600dp/fragment_videoitem_detail.xml  | 4 ++++
 app/src/main/res/layout/fragment_videoitem_detail.xml      | 4 ++++
 app/src/main/res/layout/video_item.xml                     | 1 +
 app/src/main/res/values/strings.xml                        | 7 +++++++
 5 files changed, 20 insertions(+)

diff --git a/app/src/main/res/layout-land/fragment_videoitem_detail.xml b/app/src/main/res/layout-land/fragment_videoitem_detail.xml
index a0138a3bb..dbbff1e45 100644
--- a/app/src/main/res/layout-land/fragment_videoitem_detail.xml
+++ b/app/src/main/res/layout-land/fragment_videoitem_detail.xml
@@ -31,6 +31,7 @@
                 android:layout_height="wrap_content">
 
                 <ImageView android:id="@+id/detailThumbnailView"
+                    android:contentDescription="@string/detailThumbnailViewDescription"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:scaleType="centerInside"
@@ -58,6 +59,7 @@
                         android:textAppearance="?android:attr/textAppearanceLarge"/>
 
                     <ImageView android:id="@+id/detailUploaderThumbnailView"
+                        android:contentDescription="@string/detailUploaderThumbnailViewDescription"
                         android:layout_width="100dp"
                         android:layout_height="100dp"
                         android:layout_below="@id/detailVideoTitleView"
@@ -91,6 +93,7 @@
                         android:textAppearance="?android:attr/textAppearanceMedium" />
 
                     <ImageView android:id="@+id/detailThumbsDownImgView"
+                        android:contentDescription="@string/detailThumbsDownImgViewDescription"
                         android:layout_width="40dp"
                         android:layout_height="20dp"
                         android:layout_below="@id/detailViewCountView"
@@ -108,6 +111,7 @@
                         android:textAppearance="?android:attr/textAppearanceMedium" />
 
                     <ImageView android:id="@+id/detailThumbsUpImgView"
+                        android:contentDescription="@string/detailThumbsUpImgViewDescription"
                         android:layout_width="40dp"
                         android:layout_height="20dp"
                         android:layout_below="@id/detailViewCountView"
diff --git a/app/src/main/res/layout-sw600dp/fragment_videoitem_detail.xml b/app/src/main/res/layout-sw600dp/fragment_videoitem_detail.xml
index 374d6f993..4eb67e2f4 100644
--- a/app/src/main/res/layout-sw600dp/fragment_videoitem_detail.xml
+++ b/app/src/main/res/layout-sw600dp/fragment_videoitem_detail.xml
@@ -31,6 +31,7 @@
                 android:layout_height="wrap_content">
 
                 <ImageView android:id="@+id/detailThumbnailView"
+                    android:contentDescription="@string/detailThumbnailViewDescription"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:scaleType="centerInside"
@@ -58,6 +59,7 @@
                         android:textAppearance="?android:attr/textAppearanceLarge"/>
 
                     <ImageView android:id="@+id/detailUploaderThumbnailView"
+                        android:contentDescription="@string/detailUploaderThumbnailViewDescription"
                         android:layout_width="100dp"
                         android:layout_height="100dp"
                         android:layout_below="@id/detailVideoTitleView"
@@ -91,6 +93,7 @@
                         android:textAppearance="?android:attr/textAppearanceMedium"/>
 
                     <ImageView android:id="@+id/detailThumbsDownImgView"
+                        android:contentDescription="@string/detailThumbsDownImgViewDescription"
                         android:layout_width="40dp"
                         android:layout_height="20dp"
                         android:layout_below="@id/detailViewCountView"
@@ -108,6 +111,7 @@
                         android:textAppearance="?android:attr/textAppearanceMedium" />
 
                     <ImageView android:id="@+id/detailThumbsUpImgView"
+                        android:contentDescription="@string/detailThumbsUpImgViewDescription"
                         android:layout_width="40dp"
                         android:layout_height="20dp"
                         android:layout_below="@id/detailViewCountView"
diff --git a/app/src/main/res/layout/fragment_videoitem_detail.xml b/app/src/main/res/layout/fragment_videoitem_detail.xml
index a6668a39a..340a07358 100644
--- a/app/src/main/res/layout/fragment_videoitem_detail.xml
+++ b/app/src/main/res/layout/fragment_videoitem_detail.xml
@@ -31,6 +31,7 @@
                 android:layout_height="wrap_content">
 
                 <ImageView android:id="@+id/detailThumbnailView"
+                    android:contentDescription="@string/detailThumbnailViewDescription"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:scaleType="centerInside"
@@ -58,6 +59,7 @@
                         android:textAppearance="?android:attr/textAppearanceLarge"/>
 
                     <ImageView android:id="@+id/detailUploaderThumbnailView"
+                        android:contentDescription="@string/detailUploaderThumbnailViewDescription"
                         android:layout_width="80dp"
                         android:layout_height="80dp"
                         android:layout_below="@id/detailVideoTitleView"
@@ -91,6 +93,7 @@
                         android:textAppearance="?android:attr/textAppearanceMedium" />
 
                     <ImageView android:id="@+id/detailThumbsDownImgView"
+                        android:contentDescription="@string/detailThumbsDownImgViewDescription"
                         android:layout_width="30dp"
                         android:layout_height="15dp"
                         android:layout_below="@id/detailViewCountView"
@@ -108,6 +111,7 @@
                         android:textAppearance="?android:attr/textAppearanceMedium"/>
 
                     <ImageView android:id="@+id/detailThumbsUpImgView"
+                        android:contentDescription="@string/detailThumbsUpImgViewDescription"
                         android:layout_width="30dp"
                         android:layout_height="15dp"
                         android:layout_below="@id/detailViewCountView"
diff --git a/app/src/main/res/layout/video_item.xml b/app/src/main/res/layout/video_item.xml
index 98bd2ab73..9433bd4f7 100644
--- a/app/src/main/res/layout/video_item.xml
+++ b/app/src/main/res/layout/video_item.xml
@@ -7,6 +7,7 @@
     android:padding="6dp">
 
     <ImageView android:id="@+id/itemThumbnailView"
+        android:contentDescription="@string/itemThumbnailViewDescription"
         android:layout_width="142dp"
         android:layout_height="80dp"
         android:layout_marginRight="6dp"
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index fa3a118dd..e8e23a08b 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -53,4 +53,11 @@
     <string name="settingsCategoryVideoAudioTitle">VIDEO &amp; AUDIO</string>
     <string name="settingsCategoryVideoInfoTittle">INFO</string>
     <string name="settingsCategoryEtcTitle">ETC</string>
+
+    <!-- Content descriptions (for better accessibility) -->
+    <string name="itemThumbnailViewDescription">Video preview thumbnail</string>
+    <string name="detailThumbnailViewDescription">Video preview thumbnail</string>
+    <string name="detailUploaderThumbnailViewDescription">Uploader thumbnail</string>
+    <string name="detailThumbsDownImgViewDescription">Unlikes</string>
+    <string name="detailThumbsUpImgViewDescription">Likes</string>
 </resources>