From 12ac5ef781bfc6b31ef264259e03676b5c2f5675 Mon Sep 17 00:00:00 2001 From: Stypox Date: Sat, 15 Aug 2020 15:58:25 +0200 Subject: [PATCH] [regression] Close player in onPlaybackShutdown() --- .../main/java/org/schabi/newpipe/player/BasePlayer.java | 8 -------- .../java/org/schabi/newpipe/player/VideoPlayerImpl.java | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/player/BasePlayer.java b/app/src/main/java/org/schabi/newpipe/player/BasePlayer.java index 1a8c98fd2..36484e4b0 100644 --- a/app/src/main/java/org/schabi/newpipe/player/BasePlayer.java +++ b/app/src/main/java/org/schabi/newpipe/player/BasePlayer.java @@ -1068,14 +1068,6 @@ public abstract class BasePlayer implements registerView(); } - @Override - public void onPlaybackShutdown() { - if (DEBUG) { - Log.d(TAG, "Shutting down..."); - } - destroy(); - } - /*////////////////////////////////////////////////////////////////////////// // General Player //////////////////////////////////////////////////////////////////////////*/ diff --git a/app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java b/app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java index 44bdc1108..8fdc67be3 100644 --- a/app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java +++ b/app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java @@ -622,7 +622,7 @@ public class VideoPlayerImpl extends VideoPlayer if (DEBUG) { Log.d(TAG, "onPlaybackShutdown() called"); } - // Override it because we don't want playerImpl destroyed + service.onDestroy(); } @Override