From 89b08a3d1127387d8971d9aa784e3ad65fbfc073 Mon Sep 17 00:00:00 2001 From: Mateusz Lubecki Date: Tue, 3 May 2022 17:38:36 +0200 Subject: [PATCH] bugfix in FavouritesStationDetailsOnListUpdater which sometimes crashed the application on ontry to favs list --- app/build.gradle | 4 ++-- .../FavouritesStationDetailsOnListUpdater.java | 11 +++++++---- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 710abb8..01d494c 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -12,8 +12,8 @@ android { applicationId "cc.pogoda.mobile.meteosystem" minSdkVersion 24 targetSdkVersion 30 - versionCode 11 - versionName "0.11-beta" + versionCode 13 + versionName "0.13-beta" testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } diff --git a/app/src/main/java/cc/pogoda/mobile/meteosystem/activity/updater/FavouritesStationDetailsOnListUpdater.java b/app/src/main/java/cc/pogoda/mobile/meteosystem/activity/updater/FavouritesStationDetailsOnListUpdater.java index faf4ca0..419690a 100644 --- a/app/src/main/java/cc/pogoda/mobile/meteosystem/activity/updater/FavouritesStationDetailsOnListUpdater.java +++ b/app/src/main/java/cc/pogoda/mobile/meteosystem/activity/updater/FavouritesStationDetailsOnListUpdater.java @@ -92,13 +92,13 @@ public class FavouritesStationDetailsOnListUpdater implements Runnable { // query web service for station data Summary summary = stationNameSummary.get(stationSystemName); - Logger.debug("[FavouritesStationDetailsOnListUpdater][run][stationSystemName = " + stationSystemName +"][summary.last_timestamp = " + summary.last_timestamp +"]"); - // query for available parameters AvailableParametersWeb params = availableParametersDao.getAvaliableParamsByStationName(stationSystemName); // if data has been collected - if (summary != null) { + if (summary != null && params != null) { + Logger.debug("[FavouritesStationDetailsOnListUpdater][run][stationSystemName = " + stationSystemName +"][summary.last_timestamp = " + summary.last_timestamp +"]"); + String str; // check if this station transmits wind information @@ -135,9 +135,12 @@ public class FavouritesStationDetailsOnListUpdater implements Runnable { toUpdate.setTextColor(androidx.activity.R.color.secondary_text_default_material_light); } } + else { + Logger.error("[FavouritesStationDetailsOnListUpdater][run][summary object is null!! Maybe the API responds exeptionally slow?]"); + } } - handler.postDelayed(this, 60000); + handler.postDelayed(this, 3000); } } }