Taylor Smock
808623d727
JUnit4 -> JUnit5
...
* Fix an NPE, doesn't fix root issue
* Add tag for command tests
* Add annotations for specific types of tests.
There is now an annotation for slow tests, tests that affect other
tests, and tests that are affected by other tests.
In the event that a wounded test (test affected by another test) is
fixed, it may have its wounded annotation removed. Under no
circumstances should the test that affects another test have its bleed
annotation removed, since it may cause other tests to fail in the
future. When a wounded annotation is added or removed, it should have a
reference to the test that is wounding it.
* Add documentation on why tests may be failing
* Add a wiremock response transformer
This ensures that any URL's in the response are also mocked (or fails
the test).
I also fixed a listener bug for MapWithAILayerInfo.
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-11-12 15:17:11 -07:00
Taylor Smock
7d64a84062
MapWithAIDataUtils: Add minimum dimensions (effectively 1 km).
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 09:02:39 -07:00
Taylor Smock
b77508554a
MapWithAIDataUtils: FIXUP: Don't continually try to download
...
* Only try smaller bboxes when the exception is from a
SocketTimeoutException
* If the exception is IllegalDataException, then log and show a
notification to the user that the servers may be down.
* Otherwise, throw a new JosmRuntimeException
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 08:58:42 -07:00
Taylor Smock
3500f3843f
FIXUP: Ensure that a copy of a MapWithAIInfo object actually copies everything.
...
This caused an issue where an entry would be copied without parameters,
and a failure would occur until the entry list was updated again, at
which point the parameters were set.
This adds a non-regression test that should (hopefully) ensure that this
does not occur again with that specific clone constructor.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-30 08:28:40 -06:00
Taylor Smock
8e71690ed1
FIXUP: Avoid source tag conflicts
...
* Merging addresses and buildings will now merge sources _in
alphabetical_ order.
This fixes #96 .
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-07 08:05:21 -06:00
Taylor Smock
10e3ad76a7
FIXUP: Don't show preview data sets when expert mode is not checked
...
This fixes #99 .
This also changes the default classpath for the JRE, so that it
hopefully just works on different machines.
The minimum JOSM version is also bumped to the current stable.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-07 07:27:58 -06:00
Taylor Smock
99d1b61ab9
DataConflationSender: Fix some sonar issues
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 11:51:42 -06:00
Taylor Smock
960798c9ca
FIXUP: Fix a potential NPE (sonar)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 11:46:41 -06:00
Taylor Smock
1ffa7fcad3
Improve calculations for areas that have already been downloaded
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-21 17:08:46 -06:00
Taylor Smock
70bf24f9af
MapWithAILayer: Initialize data source listeners on initialization
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-21 17:08:46 -06:00
Taylor Smock
75b29cbec4
Revert "DownloadListener: Remove unneeded code"
...
This reverts commit a061c2110d8ad93f58c0e98870c8095c7c7308c6.
2020-09-21 17:08:46 -06:00
Taylor Smock
c5dc614d0d
DownloadListener: Remove unneeded code
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-21 17:08:46 -06:00
Taylor Smock
0ad2ed5c97
MovePrimitiveDataSetCommand: FIXUP: Account for deleted MapWithAI layer
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-18 08:38:29 -06:00
Taylor Smock
d13fa58ae8
FIXUP: Avoid an NPE when adding a custom source
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-17 15:25:55 -06:00
Taylor Smock
aa99c12233
MapWithAIProvidersPanel: FIXUP: Convert row index to model
...
* This fixes an issue where the checkbox would not properly toggle a
checkbox.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-09 18:15:54 -06:00
Taylor Smock
8668fc84b2
FIXUP: Stop reading attributes into JOSM
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-03 09:38:00 -06:00
Taylor Smock
e92bfd38bb
FIXUP: Fix a possible NPE and cast 10_000 to double
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-19 11:36:16 -06:00
Taylor Smock
f66f950d16
FIXUP: PMD issues
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-19 10:28:20 -06:00
Taylor Smock
ea06356d6b
Modify MapPaintUtilsTest (disabled due to race condition)
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-19 09:59:40 -06:00
Taylor Smock
76cf948ee9
FIXUP: MapPaintUtils: Fix some sonar issues
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-18 13:06:44 -06:00
Taylor Smock
d8969f38eb
FIXUP: Don't try to use non-highway objects when adding a node to another way
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-18 11:43:37 -06:00
Taylor Smock
58be4eea0c
MapPaintUtils: Fix test, fix an NPE
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-18 09:56:58 -06:00
Taylor Smock
251f968df8
FIXUP: Add a test (and fix an issue) whereby simplified ways could cause a crash
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-17 08:14:30 -06:00
Taylor Smock
ed83ff4e1e
REFACTOR: Move commands into more appropriate packages
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-14 08:59:24 -06:00
Taylor Smock
458c5acc71
Remove unnecessary version check
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-06 11:34:46 -06:00
Taylor Smock
229bf76be8
MapPaintUtils: Enumerator -> Stream
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-05 14:18:33 -06:00
Taylor Smock
e8e3985460
Fix some errorprone issues
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-05 08:03:40 -06:00
Taylor Smock
51aa40925d
Add tests for zip file paint style and fiddle with other tests/problems
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-05 07:19:47 -06:00
Taylor Smock
b6c1ff07e7
Experimental style
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-29 15:54:23 -06:00
Taylor Smock
21341972f1
Update in-tree copy of mapcss file
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-29 15:51:05 -06:00
Taylor Smock
5f634aac7c
FIXUP: MapPaintUtils documentation
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-29 15:49:50 -06:00
Taylor Smock
f40b349d86
Add a version check since color settings are not yet available.
...
See JOSM-19547 for more information.
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-29 15:21:17 -06:00
Taylor Smock
9b34329209
Create a new MapPaintUtils class.
...
This class has methods that have been moved from MapWithAIDataUtils.
It also has some new methods to modify a MapWithAI.mapcss file inplace
(special handling for zip files from JOSM website).
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-29 15:21:16 -06:00
Taylor Smock
9dc02dee33
Change action message when it changes what it does
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-15 08:22:59 -06:00
Taylor Smock
4ed09dd7e1
FIXUP: Spotbugs
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-14 11:39:46 -06:00
Taylor Smock
5d81c2906f
Fix some compile warnings
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-14 08:53:02 -06:00
Taylor Smock
88ab3ea863
Add a notification for when no MapWithAIInfo is available in a region.
...
This fixes #92 .
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-14 08:26:41 -06:00
Taylor Smock
0122707e27
Don't allow users to select data sources when there is no data layer
...
This fixes #91 .
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-14 08:04:29 -06:00
Taylor Smock
fd73d6a88b
Add checkbox for users to toggle.
...
Also fix an issue with the clickable licenses (opened two tabs)
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-13 17:07:06 -06:00
Taylor Smock
5d35fb36f3
FIXUP: Avoid crash when user may have modified conn/dupe tags
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-13 15:10:07 -06:00
Beata Tautan-Jancso
93938afc77
added license url to providers table
2020-07-12 19:27:41 +03:00
Taylor Smock
2c8c3adef2
Fix JOSM-19473
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-01 10:55:46 -06:00
Taylor Smock
0bc1f03848
Improve MapWithAI menu
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-01 09:52:31 -06:00
Taylor Smock
0b43172d3f
Add preference checkbox to show preview datasets. Requires Expert Mode.
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-01 08:44:05 -06:00
Taylor Smock
d8a6bf8422
FIXUP: Remove .svg from image path
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-01 08:26:48 -06:00
Taylor Smock
af51c59346
Really fix a ReDOS attack(tm)
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-30 16:15:22 -06:00
Taylor Smock
c042ce8df4
Add a test for MapWithAIDefaultLayerTableModel
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-30 14:06:55 -06:00
Taylor Smock
6ec23bb0a9
Basic testing for AddMapWithAILayerAction + a fix for an NPE
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-30 13:15:07 -06:00
Taylor Smock
f4ad6b7421
Store the layers that have been downloaded into the MapWithAI
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-30 11:37:05 -06:00
Taylor Smock
81950d379e
Add basic test for MapWithAIProvidersPanel
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-30 10:51:53 -06:00