Taylor Smock
eff911c300
Extract TileXYZ and add some basic tests
...
Signed-off-by: Taylor Smock <smocktaylor@gmail.com>
2024-01-03 11:18:39 -07:00
Hermann Schwarting
d13d61f13c
PMTiles: invert y axis of tile coordinates
...
The y axis of XYZ tiles is oriented from north to south. When
enumerating tiles for a given bounding box, the y coordinates have to be
enumerated from north/top to south/bottom.
2024-01-03 17:45:24 +01:00
Taylor Smock
225abbb685
Avoid using worker thread for getting sources -- this can block data downloads
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-11-29 11:30:16 -07:00
Taylor Smock
e8c6e96217
Remove unnecessary test rules
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-11-29 11:30:15 -07:00
Taylor Smock
e796f49d8e
See #23220 : Use jakarta.annotation instead of javax.annotation (JSR305)
...
Some lint issues were also fixed.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-10-25 10:49:59 -06:00
Taylor Smock
4af7ac225f
Use max zoom from pmtiles and guess zoom for new MVT layers
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-10-04 08:03:26 -06:00
Taylor Smock
9c3e9c0879
Fix MapWithAI layer switching with ctrl+r
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-10-02 11:33:08 -06:00
Taylor Smock
bac594e719
Fix #23186 : NPE when validating relation with no complete members
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-09-22 05:40:10 -06:00
Taylor Smock
409662a664
Add support for MVT and PMTiles data sources
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-28 10:23:05 -06:00
Taylor Smock
193cc730cb
Add basic support for z/x/y data sources
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-28 08:07:37 -06:00
Taylor Smock
6107e3b2c8
Use jakarta.json instead of javax.json
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-22 07:33:05 -06:00
Taylor Smock
dd3cb880a6
Decrease allocations from listing the layers
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-08 13:52:36 -06:00
Taylor Smock
ada0741bc7
Ensure that the conflation service will timeout
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-08 08:35:08 -06:00
Taylor Smock
b4961db21a
Reduce allocations during runtime
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-02 11:19:03 -06:00
Taylor Smock
defd8c0890
More Java 17 changes
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-02 10:33:48 -06:00
Taylor Smock
056b9db064
Reduce startup costs
...
This largely focuses on reducing memory allocations.
There are also some conversions to Java 17 standards.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-02 09:59:22 -06:00
Taylor Smock
9aab77dd4f
Add icon for JOSM download window
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-01 11:06:48 -06:00
Taylor Smock
35bad2f762
Fix EDT violation
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-07-20 15:36:37 -06:00
Taylor Smock
21d43934d1
Sync continuous download with JOSM download window
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-07-20 15:22:22 -06:00
Taylor Smock
8c609c0ab2
Significantly reduce cost of Access#expandAccessValues and RoutingIslandsTest#getDefaultAccessTags
...
CPU samples and memory allocations for those two methods was reduced by ~1/3.
JVM method CPU samples were reduced by ~1/4.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-07-20 12:06:02 -06:00
Taylor Smock
3412935eaf
Fix #23062 : NPE in StreetAddressTest#realVisit
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-07-17 06:36:19 -06:00
Taylor Smock
5a8033b9b0
Revert "Remove duplicate ways"
...
This reverts commit ff8293e7d0
.
2023-04-27 07:11:03 -06:00
Taylor Smock
40f719ffa8
Fix #22905 : OsmApiException
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-04-26 11:48:00 -06:00
Taylor Smock
ff8293e7d0
Remove duplicate ways
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-04-26 11:41:49 -06:00
Taylor Smock
449514d2fb
Avoid multiple creations of the ForkJoinPool
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-04-26 11:39:46 -06:00
Taylor Smock
d099263041
MergeBuildingAddress: Don't use deleted nodes when looking for additional addresses
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-03-06 10:57:39 -07:00
Taylor Smock
875622c3b5
StreetAddressTest: expand search for nearby way names
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-03-06 10:57:38 -07:00
Taylor Smock
63ebf28b5b
Fix icon name (lowercase)
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-03-03 05:35:02 -07:00
Taylor Smock
1ce9aa9e1c
Fix #22765 : IAE when sending a null license
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-02-23 12:15:27 -07:00
Taylor Smock
f1f69dacac
See #22762 : Don't merge new address node with deleted address node
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-02-23 06:23:12 -07:00
Taylor Smock
c88b05021c
Fix #22760 : IAE when adding a node inside two buildings
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-02-22 07:22:46 -07:00
Taylor Smock
968d61171a
Fix node deduplication occasionally merging nodes that should not be merged
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-02-21 15:01:43 -07:00
Taylor Smock
e5b228bdba
Fix #22728 : No URL for provider
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-02-14 08:27:57 -07:00
Taylor Smock
e70f64e534
Fix #22683 : IllegalArgumentException: Listener was already added
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-01-30 07:18:24 -07:00
Taylor Smock
00835859c5
Fix #22649 : IAE: node is already deleted
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-01-16 07:08:53 -07:00
Taylor Smock
1c4b249284
StreetAddressTest: Handle upload check not looking at roads during visit phase
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-01-03 14:23:40 -07:00
Taylor Smock
f4c7761d33
Fix #22624 : Improperly added resultOffset to URLs sent to MapWithAI servers
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-01-03 07:32:45 -07:00
Taylor Smock
070e4fb9fe
MergeBuildingAddress: Don't delete duplicate addresses when added together
...
It is possible that the originating source didn't have addr:unit tags,
so other applications such as StreetComplete should detect duplicate
addresses and ask users if there are addr:unit tags, or which one is the
"main" building.
Furthermore, JOSM has a validator for duplicate addresses, so hopefully
the user will see the duplicate addresses and deal with them
appropriately, if it is obvious that one of the buildings is an
outbuilding.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-20 07:17:10 -07:00
Taylor Smock
f251a0428e
MergeBuildingAddress: Only add ChangePropertyCommand if something will change
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-20 06:49:05 -07:00
Taylor Smock
de47e9c589
Significantly reduce memory usage by MergeBuildingAddress#getAddressPoints
...
This reduces CPU usage by 98.6% and memory allocations by 99.6%.
The time for adding all addresses in the
`39.69427;-86.104252;39.72361;-86.082427` download area went from ~1.25
minutes to ~10 seconds (~86% reduction).
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-20 06:42:52 -07:00
Taylor Smock
84682ba8c6
StreetAddressTest: Significantly improve performance
...
This reduces CPU cycles by ~99% and memory allocations by ~74%.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-15 07:20:31 -07:00
Taylor Smock
c453368368
StreetAddressOrder: Improve performance
...
This reduces CPU time in getNearbyAddresses by ~85% and memory
allocations by ~97%.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-15 07:20:31 -07:00
Taylor Smock
f633e40322
Fix JavaDocs
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-14 09:18:09 -07:00
Taylor Smock
9507670753
Paginate Esri sources
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-14 09:05:47 -07:00
Taylor Smock
b893f8a09e
Fix TM bound generation
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-13 15:22:46 -07:00
Taylor Smock
01ce992d24
Update to non-deprecated methods
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-07 07:23:42 -07:00
Taylor Smock
61d5b62689
MapWithAISourceReader#getBounds *must* return a modifiable list
...
Also, add @Territories annotation to a test that needed it
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-07 06:02:37 -07:00
Taylor Smock
9a61f34d7f
Fix many SonarLint issues, mostly documentation
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-06 14:32:30 -07:00
Taylor Smock
ee0c576ee7
Fix #22509 : stale URLs may cause downloads to fail
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-11-17 10:32:48 -07:00
Taylor Smock
6d1ab18335
Attempt to fix #22511 : Deadlock in DataSet#beginUpdate
...
This race occurs when
* MapWithAI is downloading and cleaning data *and*
* JOSM is performing a map paint
This attempts to fix the issue by getting a write lock
*prior to* entering any synchronized methods in DataSet.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-11-17 09:58:52 -07:00