070e4fb9fe
MergeBuildingAddress: Don't delete duplicate addresses when added together
...
It is possible that the originating source didn't have addr:unit tags,
so other applications such as StreetComplete should detect duplicate
addresses and ask users if there are addr:unit tags, or which one is the
"main" building.
Furthermore, JOSM has a validator for duplicate addresses, so hopefully
the user will see the duplicate addresses and deal with them
appropriately, if it is obvious that one of the buildings is an
outbuilding.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-20 07:17:10 -07:00
f251a0428e
MergeBuildingAddress: Only add ChangePropertyCommand if something will change
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-20 06:49:05 -07:00
de47e9c589
Significantly reduce memory usage by MergeBuildingAddress#getAddressPoints
...
This reduces CPU usage by 98.6% and memory allocations by 99.6%.
The time for adding all addresses in the
`39.69427;-86.104252;39.72361;-86.082427` download area went from ~1.25
minutes to ~10 seconds (~86% reduction).
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-20 06:42:52 -07:00
84682ba8c6
StreetAddressTest: Significantly improve performance
...
This reduces CPU cycles by ~99% and memory allocations by ~74%.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-15 07:20:31 -07:00
c453368368
StreetAddressOrder: Improve performance
...
This reduces CPU time in getNearbyAddresses by ~85% and memory
allocations by ~97%.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-15 07:20:31 -07:00
f633e40322
Fix JavaDocs
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-14 09:18:09 -07:00
9507670753
Paginate Esri sources
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-14 09:05:47 -07:00
b893f8a09e
Fix TM bound generation
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-13 15:22:46 -07:00
01ce992d24
Update to non-deprecated methods
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-07 07:23:42 -07:00
61d5b62689
MapWithAISourceReader#getBounds *must* return a modifiable list
...
Also, add @Territories annotation to a test that needed it
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-07 06:02:37 -07:00
9d685d9baa
Workflows: Add report publishing
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-06 14:32:52 -07:00
9a61f34d7f
Fix many SonarLint issues, mostly documentation
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-06 14:32:30 -07:00
0fcc9e8ee0
Dependency updates
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-06 08:52:26 -07:00
ee0c576ee7
Fix #22509 : stale URLs may cause downloads to fail
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-11-17 10:32:48 -07:00
6d1ab18335
Attempt to fix #22511 : Deadlock in DataSet#beginUpdate
...
This race occurs when
* MapWithAI is downloading and cleaning data *and*
* JOSM is performing a map paint
This attempts to fix the issue by getting a write lock
*prior to* entering any synchronized methods in DataSet.
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-11-17 09:58:52 -07:00
ed1af91aef
Move from Apache HTTP 4 to Apache HTTP 5
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-11-07 16:14:24 -07:00
88a48a5fdb
Fix #22440 : NPE in MapWithAIInfo#getConflationUrl
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-10-11 10:46:43 -06:00
ff3a9d38c3
Remove ivy (no longer necessary)
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-10-10 12:26:49 -06:00
976f861309
Update GH Actions
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-10-10 10:29:49 -06:00
96503e69d0
Update URL locations
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-10-10 09:26:16 -06:00
207161b6c6
Fix #22316 : CancellationException when cancelling after OSM download screen
...
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-10-06 15:24:06 -06:00
7380924ccc
UpdateProdTest: Use JOSM test rules to set revision (polluted following tests)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-10-05 15:31:08 -06:00
9419a57277
Add Plugin-Url to manifest generated by ant
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-10-05 11:34:23 -06:00
26c0fda8d2
MapWithAICopyProhibitTest: Update testDestroyable for r18390
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-10-05 11:34:23 -06:00
cfb0c686c9
Initial GitHub actions
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-10-05 11:34:23 -06:00
4d736c967f
Fix #22414 : RuntimeException instead of OsmApiException is thrown from ForkJoinPool#join
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-10-03 08:40:12 -06:00
9c8ebfe282
Dependency updates
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-08-30 09:34:22 -06:00
5aa110b829
Update to gradle josm plugin 0.8.2 from 0.8.0
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-08-30 06:57:50 -06:00
89c7d898ce
MapWithAILayerInfo: Fix an IllegalMonitorStateException
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-08-30 06:57:49 -06:00
26d229fd3a
MapWithAIDataUtilsTest: Disable flaky test
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-07-05 08:33:07 -06:00
7d7464f5da
Fix JOSM #22186 : NPE in MapWithAIDataUtils#mergeDataSet
...
This is due to the localized message being null.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-07-05 07:23:03 -06:00
48751b16ec
ESRISourceReader: Account for `null` values for "accessInformation"
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-28 12:43:44 -06:00
840cadb61b
Lint fixes
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-22 12:26:24 -06:00
b4a32e426c
GetDataRunnable: Move away from streams
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-02 13:08:52 -06:00
9e00328d33
Decrease allocations in various locations
...
With the changes from
325c169468bce987bd93e78da81b92c12e52d86f..2c11de9e3ca95e5ea26ba08b053692ff013eb728,
this reduces allocations due to MapWithAI cleanup methods
(on download) from 1.7 GB to 265 MB.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 16:54:11 -06:00
7c3c0e72c2
MapWithAIDataUtils: Cleanup legacy methods
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 10:29:25 -06:00
2c11de9e3c
GetDataRunnable: Significantly reduce allocations from merging nodes
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 08:04:56 -06:00
c9beb019ef
GetDataRunnable: Various cleanups
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 08:04:56 -06:00
482ccffb8e
MapWithAIPreferenceHelper: Cache a property that is constantly hit
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 08:04:56 -06:00
844e67d5a1
MapWithAIDataUtils: Download inside a safe ForkJoinPool
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 08:04:56 -06:00
b350286a36
MapWithAIInfoTest: Add equals check
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 08:04:54 -06:00
7acae1ca7f
CountryUtils: Significantly reduce allocations by caching
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-31 16:10:40 -06:00
ebc1725a10
GetDataRunnable: Avoid allocations
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-31 14:47:47 -06:00
5a74db8351
MapWithAIPreferenceHelper: Avoid allocations by using specific property classes
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-31 14:45:37 -06:00
325c169468
Various fixups (mostly for parallelStream -> stream)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-27 06:34:48 -06:00
d6914567c4
Fix a deadlock that could occur when downloading data
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-27 06:16:27 -06:00
f8723d9db4
ESRISourceReader: Directly submit ForkJoinTasks to safe ForkJoinPool
...
This fixes JOSM #22077 , which was caused by ForkJoinTask#fork submitting
the task to ForkJoinPool#commonPool, when not called inside a
ForkJoinPool. This is problematic under WebStart.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-18 08:25:40 -06:00
10a821f794
MapWithAIPlugin: Call addDownloadSelection in tests
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 16:41:58 -06:00
1dc1f18e8e
ESRI: Get data in a ForkJoinPool (significant speedup)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 16:02:29 -06:00
5aa3843271
Fix some javadoc issues
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 16:02:23 -06:00
Taylor Smock