Taylor Smock
7cf36357d2
FIXUP: Readd the check for whether or not a node pair exists as a segment
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-05-19 09:51:13 -06:00
Taylor Smock
a142ded362
MapWithAITestRules: Workaround double initialization
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-05-19 08:37:06 -06:00
Taylor Smock
1d99028c93
WaySegment -> IWaySegment
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-05-19 08:36:24 -06:00
Taylor Smock
5beec53fb1
DetectTaskingManagerUtils: Update deprecated method
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-05-18 07:24:21 -06:00
Taylor Smock
88a87bb1c1
Update for compatibility with JOSM r17903
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-05-18 07:24:13 -06:00
Taylor Smock
88c3027e01
CI: FIXUP: Add curl for lsif
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-04-13 16:54:57 -06:00
Taylor Smock
b2b22a700d
Fix JOSM-20753 -- fallout from JOSM r17752
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-04-13 08:01:45 -06:00
Taylor Smock
f528c871a3
CI: Update LSIF (again)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-04-08 12:31:24 -06:00
Taylor Smock
eba21f2d57
Update dependencies
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-04-08 12:30:33 -06:00
Taylor Smock
b5786301bb
Modify the max add defaults
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-03-16 14:17:50 -06:00
Taylor Smock
df0d947ed3
Fix JOSM-20551
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-03-02 07:56:54 -07:00
Taylor Smock
f68354bc9c
Fix sonar lint issue
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-03-02 07:56:44 -07:00
Taylor Smock
437c452f6c
Update versions
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-14 12:48:08 -07:00
Taylor Smock
b3c0e37f80
Fix JOSM-20388, attempting to duplicate a MapWithAI layer
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-14 07:34:43 -07:00
Taylor Smock
abf49ffdab
ConnectedCommandTest: Fix lint issue (easier test to debug)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-14 07:34:43 -07:00
Taylor Smock
e717fe5075
MapWithAILayer: Fix lint issue w.r.t. JLS
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-14 07:32:47 -07:00
Taylor Smock
8407b58946
Gitlab-CI: Sync with Mapillary Gitlab CI
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-13 16:31:43 -07:00
Taylor Smock
ef62098664
Gitlab-CI: Hopefully fix shown coverage
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-13 14:31:07 -07:00
Taylor Smock
5fb9a0707a
Gitlab-CI: Expire unnecessary artifacts after 1 day
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-13 14:31:07 -07:00
Taylor Smock
acf6787de1
Gitlab-CI: Add dependencies to share gradle build dir
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-13 14:31:07 -07:00
Taylor Smock
f4ffb1eb73
Gitlab-CI: Try to avoid detached pipelines
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-13 12:35:28 -07:00
Taylor Smock
808bd9794c
Update old version download links
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-13 09:09:29 -07:00
Taylor Smock
18ac7eaec8
MapWithAIPreferences: Increase the maximum maxadd by 10 fold
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-12 12:32:50 -07:00
Taylor Smock
ab0055a4d3
FIXUP: EsriSourceReader: Fix paginiation for Esri sources
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-12 09:47:44 -07:00
Taylor Smock
9942dcd094
MapWithAILayer: Merge similar sources together (Esri only)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-12-23 11:13:27 -07:00
Taylor Smock
76b5de2c6e
Sonar: Fix various issues
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-12-23 10:17:01 -07:00
Taylor Smock
504e06faf5
Gitlab-CI: Sonar for merge requests
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-12-23 10:17:01 -07:00
Taylor Smock
a47032c8ec
Add code to avoid accidentally uploading bad data in older plugin versions.
...
This and related commits will be backported.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-12-23 10:17:01 -07:00
Taylor Smock
71c494aeb6
Add initial code to check if this version of the plugin should not upload to OSM
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-12-22 17:20:32 -07:00
Taylor Smock
01f5f51a6f
MapWithAILayer: Don't allow MapWithAI data to be merged into a OSM data layer.
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-12-22 16:58:17 -07:00
Taylor Smock
8955a871a6
MapWithAILayer: Add MapWithAI to source tags when used
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-12-22 16:58:17 -07:00
Taylor Smock
451f0b5976
FIXUP: Fix JOSM-20203
...
Just notify the user that there is a problem. Don't cause an exception.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-12-08 14:14:08 -07:00
Taylor Smock
a9b06f09de
Move MapWithAI Menu to the "data" menu
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-30 12:47:57 -07:00
Taylor Smock
793af99bf8
MapWithAIPreferences: Increase default max add and thus absolute max add
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-24 16:32:53 +00:00
Taylor Smock
f53c8220c4
GITLAB_CI: Add coverage highlighting
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-23 12:30:26 -07:00
Taylor Smock
fdbc7d5191
Dependencies: Update compile version
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 15:26:07 -07:00
Taylor Smock
bd2f15113d
Dependencies: Update to newer versions
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 15:17:11 -07:00
Taylor Smock
808623d727
JUnit4 -> JUnit5
...
* Fix an NPE, doesn't fix root issue
* Add tag for command tests
* Add annotations for specific types of tests.
There is now an annotation for slow tests, tests that affect other
tests, and tests that are affected by other tests.
In the event that a wounded test (test affected by another test) is
fixed, it may have its wounded annotation removed. Under no
circumstances should the test that affects another test have its bleed
annotation removed, since it may cause other tests to fail in the
future. When a wounded annotation is added or removed, it should have a
reference to the test that is wounding it.
* Add documentation on why tests may be failing
* Add a wiremock response transformer
This ensures that any URL's in the response are also mocked (or fails
the test).
I also fixed a listener bug for MapWithAILayerInfo.
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-11-12 15:17:11 -07:00
Taylor Smock
89d561d36c
FIXUP: Update old versions
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 09:51:12 -07:00
Taylor Smock
7d64a84062
MapWithAIDataUtils: Add minimum dimensions (effectively 1 km).
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 09:02:39 -07:00
Taylor Smock
b77508554a
MapWithAIDataUtils: FIXUP: Don't continually try to download
...
* Only try smaller bboxes when the exception is from a
SocketTimeoutException
* If the exception is IllegalDataException, then log and show a
notification to the user that the servers may be down.
* Otherwise, throw a new JosmRuntimeException
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 08:58:42 -07:00
Taylor Smock
3500f3843f
FIXUP: Ensure that a copy of a MapWithAIInfo object actually copies everything.
...
This caused an issue where an entry would be copied without parameters,
and a failure would occur until the entry list was updated again, at
which point the parameters were set.
This adds a non-regression test that should (hopefully) ensure that this
does not occur again with that specific clone constructor.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-30 08:28:40 -06:00
Taylor Smock
9d87fe5613
FIXUP: Update lsif due to indexer dropping flag
...
See 199fa8cbf4 (diff-10addec6648bff00c4ac7d074e08e7cfL62)
for the offending commit and lines that were dropped for more
information.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-07 08:45:56 -06:00
Taylor Smock
8e71690ed1
FIXUP: Avoid source tag conflicts
...
* Merging addresses and buildings will now merge sources _in
alphabetical_ order.
This fixes #96 .
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-07 08:05:21 -06:00
Taylor Smock
10e3ad76a7
FIXUP: Don't show preview data sets when expert mode is not checked
...
This fixes #99 .
This also changes the default classpath for the JRE, so that it
hopefully just works on different machines.
The minimum JOSM version is also bumped to the current stable.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-07 07:27:58 -06:00
Taylor Smock
db4416ad60
MapWithAIRemoteControlTest: FIXUP sonar lint
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-23 09:34:41 -06:00
Taylor Smock
e8b5a1cdad
MergeDuplicateWaysTest: FIXUP sonar issue
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-23 09:21:58 -06:00
Taylor Smock
99d1b61ab9
DataConflationSender: Fix some sonar issues
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 11:51:42 -06:00
Taylor Smock
960798c9ca
FIXUP: Fix a potential NPE (sonar)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 11:46:41 -06:00
Taylor Smock
7784fb360e
CI: Modify sonar
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 11:02:45 -06:00