ef13fd97d4
EsriSourceReader: Lazily load replacement tags
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-10-18 12:02:00 -06:00
810831af37
GetDataRunnable: Fix race condition where creation of two dataset might attempt to increment primitive id backward
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-30 16:25:38 -06:00
849f571837
Lint: Cleanup warnings on build
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-30 14:54:21 -06:00
5cb5262128
MapWithAI SourceReaders: Create common class for deduplication
...
Also ensure that users can ignore cache for MapWithAI sources.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-30 14:54:21 -06:00
073104e869
Tests: Clean up some warnings on compile
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-30 14:54:21 -06:00
357a4fadd0
CI: Update highest Java version to 17
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-30 14:54:21 -06:00
a23e94be0d
Tests: Better test isolation
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-08 06:06:14 -06:00
73e64116f9
MapWithAILayerInfo: Make new @MapWithAISources annotation
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-07 10:21:46 -06:00
cd95357e43
Tests: Move annotations to separate package
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-07 10:21:45 -06:00
e092718f2f
RoutingIslands: Add highway=platform to exclusions
...
See https://wiki.openstreetmap.org/wiki/Tag:highway%3Dplatform for tag
information.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-09-07 08:22:55 -06:00
9f6d2e0015
MapWithAIPreferencesTest: Docs and PMD
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-07-20 13:58:48 -06:00
2becd190c3
Tests: Use @BasicPreferences
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-07-20 12:14:59 -06:00
b00a35b953
ESRISourceReader: Increase initial search, some perf optimizations
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-07-20 12:12:52 -06:00
ed6b8bcd5d
MapWithAILayerInfo: Don't block JOSM startup
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-07-01 08:22:27 -06:00
455d5f5345
Prohibit copy-paste from MapWithAI layer to OSM layer
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-05-26 09:42:35 -06:00
7cf36357d2
FIXUP: Readd the check for whether or not a node pair exists as a segment
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-05-19 09:51:13 -06:00
a142ded362
MapWithAITestRules: Workaround double initialization
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-05-19 08:37:06 -06:00
88a87bb1c1
Update for compatibility with JOSM r17903
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-05-18 07:24:13 -06:00
abf49ffdab
ConnectedCommandTest: Fix lint issue (easier test to debug)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-14 07:34:43 -07:00
ab0055a4d3
FIXUP: EsriSourceReader: Fix paginiation for Esri sources
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2021-01-12 09:47:44 -07:00
9942dcd094
MapWithAILayer: Merge similar sources together (Esri only)
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-12-23 11:13:27 -07:00
a47032c8ec
Add code to avoid accidentally uploading bad data in older plugin versions.
...
This and related commits will be backported.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-12-23 10:17:01 -07:00
71c494aeb6
Add initial code to check if this version of the plugin should not upload to OSM
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-12-22 17:20:32 -07:00
a9b06f09de
Move MapWithAI Menu to the "data" menu
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-30 12:47:57 -07:00
793af99bf8
MapWithAIPreferences: Increase default max add and thus absolute max add
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-24 16:32:53 +00:00
808623d727
JUnit4 -> JUnit5
...
* Fix an NPE, doesn't fix root issue
* Add tag for command tests
* Add annotations for specific types of tests.
There is now an annotation for slow tests, tests that affect other
tests, and tests that are affected by other tests.
In the event that a wounded test (test affected by another test) is
fixed, it may have its wounded annotation removed. Under no
circumstances should the test that affects another test have its bleed
annotation removed, since it may cause other tests to fail in the
future. When a wounded annotation is added or removed, it should have a
reference to the test that is wounding it.
* Add documentation on why tests may be failing
* Add a wiremock response transformer
This ensures that any URL's in the response are also mocked (or fails
the test).
I also fixed a listener bug for MapWithAILayerInfo.
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-11-12 15:17:11 -07:00
3500f3843f
FIXUP: Ensure that a copy of a MapWithAIInfo object actually copies everything.
...
This caused an issue where an entry would be copied without parameters,
and a failure would occur until the entry list was updated again, at
which point the parameters were set.
This adds a non-regression test that should (hopefully) ensure that this
does not occur again with that specific clone constructor.
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-30 08:28:40 -06:00
db4416ad60
MapWithAIRemoteControlTest: FIXUP sonar lint
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-23 09:34:41 -06:00
e8b5a1cdad
MergeDuplicateWaysTest: FIXUP sonar issue
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-23 09:21:58 -06:00
1ffa7fcad3
Improve calculations for areas that have already been downloaded
...
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-21 17:08:46 -06:00
667bae488b
FIXUP: PMD issues
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-19 11:03:24 -06:00
ea06356d6b
Modify MapPaintUtilsTest (disabled due to race condition)
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-19 09:59:40 -06:00
e24322ffd8
Remove unnecessary worker wait and rename test
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-18 13:00:04 -06:00
c8264da706
MapWithAI Style ZIP: Remove @support (test env bailed on it)
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-18 11:12:23 -06:00
58be4eea0c
MapPaintUtils: Fix test, fix an NPE
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-18 09:56:58 -06:00
251f968df8
FIXUP: Add a test (and fix an issue) whereby simplified ways could cause a crash
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-17 08:14:30 -06:00
ed83ff4e1e
REFACTOR: Move commands into more appropriate packages
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-14 08:59:24 -06:00
b0355f0c5e
Attempt to fix unit tests
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-14 07:49:47 -06:00
e8e3985460
Fix some errorprone issues
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-05 08:03:40 -06:00
886f32153b
Add MapPaintUtilsTest
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-05 07:20:50 -06:00
51aa40925d
Add tests for zip file paint style and fiddle with other tests/problems
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-05 07:19:47 -06:00
9b34329209
Create a new MapPaintUtils class.
...
This class has methods that have been moved from MapWithAIDataUtils.
It also has some new methods to modify a MapWithAI.mapcss file inplace
(special handling for zip files from JOSM website).
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-29 15:21:16 -06:00
3b94fe1150
Fix an NPE in a test
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-14 10:19:10 -06:00
5d81c2906f
Fix some compile warnings
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-14 08:53:02 -06:00
5d35fb36f3
FIXUP: Avoid crash when user may have modified conn/dupe tags
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-13 15:10:07 -06:00
2c8c3adef2
Fix JOSM-19473
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-07-01 10:55:46 -06:00
6f3aef98c3
Fix some issues when tests were run together
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-30 15:44:14 -06:00
11adb96777
Add basic tests for the MapWithAIMenu
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-30 15:03:46 -06:00
c042ce8df4
Add a test for MapWithAIDefaultLayerTableModel
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-30 14:06:55 -06:00
6ec23bb0a9
Basic testing for AddMapWithAILayerAction + a fix for an NPE
...
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-06-30 13:15:07 -06:00
Taylor Smock