Wykres commitów

649 Commity (0aaa1b6ba7eb2ebe45e5af7b5fa2d9600e78eda5)

Autor SHA1 Wiadomość Data
Taylor Smock fdbc7d5191 Dependencies: Update compile version
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 15:26:07 -07:00
Taylor Smock bd2f15113d Dependencies: Update to newer versions
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 15:17:11 -07:00
Taylor Smock 808623d727 JUnit4 -> JUnit5
* Fix an NPE, doesn't fix root issue
* Add tag for command tests
* Add annotations for specific types of tests.
  There is now an annotation for slow tests, tests that affect other
  tests, and tests that are affected by other tests.
  In the event that a wounded test (test affected by another test) is
  fixed, it may have its wounded annotation removed. Under no
  circumstances should the test that affects another test have its bleed
  annotation removed, since it may cause other tests to fail in the
  future. When a wounded annotation is added or removed, it should have a
  reference to the test that is wounding it.
* Add documentation on why tests may be failing
* Add a wiremock response transformer
  This ensures that any URL's in the response are also mocked (or fails
  the test).
  I also fixed a listener bug for MapWithAILayerInfo.

Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-11-12 15:17:11 -07:00
Taylor Smock 89d561d36c FIXUP: Update old versions
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 09:51:12 -07:00
Taylor Smock 7d64a84062 MapWithAIDataUtils: Add minimum dimensions (effectively 1 km).
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 09:02:39 -07:00
Taylor Smock b77508554a MapWithAIDataUtils: FIXUP: Don't continually try to download
* Only try smaller bboxes when the exception is from a
  SocketTimeoutException
* If the exception is IllegalDataException, then log and show a
  notification to the user that the servers may be down.
* Otherwise, throw a new JosmRuntimeException

Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-11-12 08:58:42 -07:00
Taylor Smock 3500f3843f FIXUP: Ensure that a copy of a MapWithAIInfo object actually copies everything.
This caused an issue where an entry would be copied without parameters,
and a failure would occur until the entry list was updated again, at
which point the parameters were set.

This adds a non-regression test that should (hopefully) ensure that this
does not occur again with that specific clone constructor.

Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-30 08:28:40 -06:00
Taylor Smock 9d87fe5613 FIXUP: Update lsif due to indexer dropping flag
See 199fa8cbf4 (diff-10addec6648bff00c4ac7d074e08e7cfL62)
for the offending commit and lines that were dropped for more
information.

Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-07 08:45:56 -06:00
Taylor Smock 8e71690ed1 FIXUP: Avoid source tag conflicts
* Merging addresses and buildings will now merge sources _in
  alphabetical_ order.

This fixes #96.

Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-07 08:05:21 -06:00
Taylor Smock 10e3ad76a7 FIXUP: Don't show preview data sets when expert mode is not checked
This fixes #99.

This also changes the default classpath for the JRE, so that it
hopefully just works on different machines.

The minimum JOSM version is also bumped to the current stable.

Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-10-07 07:27:58 -06:00
Taylor Smock db4416ad60 MapWithAIRemoteControlTest: FIXUP sonar lint
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-23 09:34:41 -06:00
Taylor Smock e8b5a1cdad MergeDuplicateWaysTest: FIXUP sonar issue
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-23 09:21:58 -06:00
Taylor Smock 99d1b61ab9 DataConflationSender: Fix some sonar issues
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 11:51:42 -06:00
Taylor Smock 960798c9ca FIXUP: Fix a potential NPE (sonar)
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 11:46:41 -06:00
Taylor Smock 7784fb360e CI: Modify sonar
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 11:02:45 -06:00
Taylor Smock b1f1a5332e CI: Modify sonar
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 10:57:40 -06:00
Taylor Smock 94b3c86780 CI: Move sonar to after tests
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 10:54:24 -06:00
Taylor Smock fbb112f2ea CI: Use an non-shallow repo for sonar
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 09:14:11 -06:00
Taylor Smock 08a3afc31b CI: Update sonarcloud URL
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-22 09:10:53 -06:00
Taylor Smock 1ffa7fcad3 Improve calculations for areas that have already been downloaded
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-21 17:08:46 -06:00
Taylor Smock 0441c11d4a SONAR: Bump java version
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-21 17:08:46 -06:00
Taylor Smock 70bf24f9af MapWithAILayer: Initialize data source listeners on initialization
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-21 17:08:46 -06:00
Taylor Smock 4a3d539466 Bump min JOSM version down (bumped up to fix test issue with signing keys)
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-21 17:08:46 -06:00
Taylor Smock 75b29cbec4 Revert "DownloadListener: Remove unneeded code"
This reverts commit a061c2110d8ad93f58c0e98870c8095c7c7308c6.
2020-09-21 17:08:46 -06:00
Taylor Smock c5dc614d0d DownloadListener: Remove unneeded code
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-21 17:08:46 -06:00
Taylor Smock c1de460d4c FIXUP: Sonar?
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-21 17:08:46 -06:00
Taylor Smock aa51ffdf26 FIXUP: Sonar?
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-18 08:38:29 -06:00
Taylor Smock 0ad2ed5c97 MovePrimitiveDataSetCommand: FIXUP: Account for deleted MapWithAI layer
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-18 08:38:29 -06:00
Taylor Smock 6f50f2c85f GRADLE: Add jvmArgs so that tests can be used on non-headless systems
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-18 08:16:14 -06:00
Taylor Smock d13fa58ae8 FIXUP: Avoid an NPE when adding a custom source
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-17 15:25:55 -06:00
Taylor Smock 2884444464 FIXUP: Bump JOSM version (JOSM changed signing keys, so builds were failing)
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-17 13:42:34 -06:00
Taylor Smock 8c516efeaf Add sonar lint
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-17 13:42:34 -06:00
Taylor Smock aa99c12233 MapWithAIProvidersPanel: FIXUP: Convert row index to model
* This fixes an issue where the checkbox would not properly toggle a
  checkbox.

Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-09 18:15:54 -06:00
Taylor Smock c5dccd6770 Bump old versions to remove unknown attributes
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-03 11:19:06 -06:00
Taylor Smock 8668fc84b2 FIXUP: Stop reading attributes into JOSM
Signed-off-by: Taylor Smock <tsmock@fb.com>
2020-09-03 09:38:00 -06:00
Taylor Smock a91a81977f
CI: dependencies -> needs
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-28 08:47:01 -06:00
Taylor Smock e92bfd38bb
FIXUP: Fix a possible NPE and cast 10_000 to double
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-19 11:36:16 -06:00
Taylor Smock 667bae488b
FIXUP: PMD issues
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-19 11:03:24 -06:00
Taylor Smock f66f950d16
FIXUP: PMD issues
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-19 10:28:20 -06:00
Taylor Smock ea06356d6b
Modify MapPaintUtilsTest (disabled due to race condition)
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-19 09:59:40 -06:00
Taylor Smock 76cf948ee9
FIXUP: MapPaintUtils: Fix some sonar issues
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-18 13:06:44 -06:00
Taylor Smock e24322ffd8
Remove unnecessary worker wait and rename test
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-18 13:00:04 -06:00
Taylor Smock d8969f38eb
FIXUP: Don't try to use non-highway objects when adding a node to another way
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-18 11:43:37 -06:00
Taylor Smock c8264da706
MapWithAI Style ZIP: Remove @support (test env bailed on it)
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-18 11:12:23 -06:00
Taylor Smock 58be4eea0c
MapPaintUtils: Fix test, fix an NPE
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-18 09:56:58 -06:00
Taylor Smock 251f968df8
FIXUP: Add a test (and fix an issue) whereby simplified ways could cause a crash
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-17 08:14:30 -06:00
Taylor Smock ed83ff4e1e
REFACTOR: Move commands into more appropriate packages
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-14 08:59:24 -06:00
Taylor Smock b0355f0c5e
Attempt to fix unit tests
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-14 07:49:47 -06:00
Taylor Smock 458c5acc71
Remove unnecessary version check
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-06 11:34:46 -06:00
Taylor Smock 229bf76be8
MapPaintUtils: Enumerator -> Stream
Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
2020-08-05 14:18:33 -06:00