Wykres commitów

37 Commity (master)

Autor SHA1 Wiadomość Data
Taylor Smock eff911c300
Extract TileXYZ and add some basic tests
Signed-off-by: Taylor Smock <smocktaylor@gmail.com>
2024-01-03 11:18:39 -07:00
Taylor Smock e8c6e96217
Remove unnecessary test rules
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-11-29 11:30:15 -07:00
Taylor Smock e796f49d8e
See #23220: Use jakarta.annotation instead of javax.annotation (JSR305)
Some lint issues were also fixed.

Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-10-25 10:49:59 -06:00
Taylor Smock 9c3e9c0879
Fix MapWithAI layer switching with ctrl+r
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-10-02 11:33:08 -06:00
Taylor Smock bac594e719
Fix #23186: NPE when validating relation with no complete members
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-09-22 05:40:10 -06:00
Taylor Smock 409662a664
Add support for MVT and PMTiles data sources
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-28 10:23:05 -06:00
Taylor Smock 6107e3b2c8
Use jakarta.json instead of javax.json
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-22 07:33:05 -06:00
Taylor Smock a2372c6e49
Use JOSM territories annotation
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-08-08 13:25:49 -06:00
Taylor Smock 3fdb8b0560
Only reset MapWithAILayerInfo if the @Territories annotation is ued
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-07-26 08:30:01 -06:00
Taylor Smock 390526525d
Switch more test initialization to JUnit 5 annotations
One significant improvement here is done by the custom @Territories annotation;
it no longer initializes Territories on every test.

This reduces total test time (wall clock) from 5.5 minutes to 3 minutes.

Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-07-20 13:35:55 -06:00
Taylor Smock 9064644785
Add prefab values for Polygon since it fails under Java 17
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-07-20 12:05:40 -06:00
Taylor Smock 3412935eaf
Fix #23062: NPE in StreetAddressTest#realVisit
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-07-17 06:36:19 -06:00
Taylor Smock d099263041
MergeBuildingAddress: Don't use deleted nodes when looking for additional addresses
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-03-06 10:57:39 -07:00
Taylor Smock f1f69dacac
See #22762: Don't merge new address node with deleted address node
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-02-23 06:23:12 -07:00
Taylor Smock c88b05021c
Fix #22760: IAE when adding a node inside two buildings
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-02-22 07:22:46 -07:00
Taylor Smock 968d61171a
Fix node deduplication occasionally merging nodes that should not be merged
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-02-21 15:01:43 -07:00
Taylor Smock e5b228bdba
Fix #22728: No URL for provider
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-02-14 08:27:57 -07:00
Taylor Smock e70f64e534
Fix #22683: IllegalArgumentException: Listener was already added
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-01-30 07:18:24 -07:00
Taylor Smock 00835859c5
Fix #22649: IAE: node is already deleted
Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-01-16 07:08:53 -07:00
Taylor Smock 1e774df4df
See #22624: Improperly added resultOffset to URLs sent to MapWithAI servers
Add non-regression test.

Signed-off-by: Taylor Smock <tsmock@meta.com>
2023-01-03 08:20:23 -07:00
Taylor Smock 070e4fb9fe
MergeBuildingAddress: Don't delete duplicate addresses when added together
It is possible that the originating source didn't have addr:unit tags,
so other applications such as StreetComplete should detect duplicate
addresses and ask users if there are addr:unit tags, or which one is the
"main" building.

Furthermore, JOSM has a validator for duplicate addresses, so hopefully
the user will see the duplicate addresses and deal with them
appropriately, if it is obvious that one of the buildings is an
outbuilding.

Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-20 07:17:10 -07:00
Taylor Smock 84682ba8c6
StreetAddressTest: Significantly improve performance
This reduces CPU cycles by ~99% and memory allocations by ~74%.

Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-15 07:20:31 -07:00
Taylor Smock c453368368
StreetAddressOrder: Improve performance
This reduces CPU time in getNearbyAddresses by ~85% and memory
allocations by ~97%.

Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-15 07:20:31 -07:00
Taylor Smock 61d5b62689
MapWithAISourceReader#getBounds *must* return a modifiable list
Also, add @Territories annotation to a test that needed it

Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-07 06:02:37 -07:00
Taylor Smock 9a61f34d7f
Fix many SonarLint issues, mostly documentation
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-12-06 14:32:30 -07:00
Taylor Smock 88a48a5fdb
Fix #22440: NPE in MapWithAIInfo#getConflationUrl
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-10-11 10:46:43 -06:00
Taylor Smock 96503e69d0
Update URL locations
Signed-off-by: Taylor Smock <tsmock@meta.com>
2022-10-10 09:26:16 -06:00
Taylor Smock 7380924ccc
UpdateProdTest: Use JOSM test rules to set revision (polluted following tests)
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-10-05 15:31:08 -06:00
Taylor Smock 26c0fda8d2
MapWithAICopyProhibitTest: Update testDestroyable for r18390
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-10-05 11:34:23 -06:00
Taylor Smock 26d229fd3a
MapWithAIDataUtilsTest: Disable flaky test
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-07-05 08:33:07 -06:00
Taylor Smock 7c3c0e72c2
MapWithAIDataUtils: Cleanup legacy methods
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 10:29:25 -06:00
Taylor Smock b350286a36
MapWithAIInfoTest: Add equals check
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-06-01 08:04:54 -06:00
Taylor Smock 325c169468
Various fixups (mostly for parallelStream -> stream)
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-27 06:34:48 -06:00
Taylor Smock 10a821f794
MapWithAIPlugin: Call addDownloadSelection in tests
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 16:41:58 -06:00
Taylor Smock 6c9e6c6719
Add test for remote icons
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-05-16 14:50:32 -06:00
Taylor Smock 960eb784e1
Commands: Add tests for participating primitives (partial)
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-03-02 14:26:40 -07:00
Taylor Smock f535eaab6e
Refactor for test fixtures
Signed-off-by: Taylor Smock <tsmock@fb.com>
2022-01-12 10:31:10 -07:00