mirror
/
MapWithAI
kopia lustrzana https://github.com/JOSM/MapWithAI
1
0
Forkuj 0
Kod Zgłoszenia Packages Projekty Wydania Wiki Aktywność

Documentation and cleanup 

Signed-off-by: Taylor Smock <taylor.smock@kaart.com>
pull/1/head
Taylor Smock 2019-12-20 08:43:20 -07:00
rodzic 867535ae15
commit ed884ef8da
Nie znaleziono w bazie danych klucza dla tego podpisu
ID klucza GPG: 625F6A74A3E4311A
1 zmienionych plików z 11 dodań i 3 usunięć
Pokaż statystyki Ściągnij plik aktualizacji Ściągnij plik porównania Expand all files Collapse all files

14
src/main/java/org/openstreetmap/josm/plugins/mapwithai/data/validation/tests/RoutingIslandsTest.java
Wyświetl plik

@ -129,7 +129,7 @@ public class RoutingIslandsTest extends Test {
.collect(Collectors.toSet())).parallelStream() .collect(Collectors.toSet())).parallelStream()
.map(way -> new Pair<>((incomingWays.containsAll(way) ? "outgoing" : "incoming"), way)) .map(way -> new Pair<>((incomingWays.containsAll(way) ? "outgoing" : "incoming"), way))
.collect(Collectors.toList()); .collect(Collectors.toList());
createErrors(problematic, currentTransportMode, potentialWays); createErrors(problematic, currentTransportMode);
} }
/** /**
@ -200,7 +200,15 @@ public class RoutingIslandsTest extends Test {
.collect(Collectors.toSet())); .collect(Collectors.toSet()));
} }
private void createErrors(List<Pair<String, Set<Way>>> problematic, String mode, Collection<Way> potentialWays) { /**
* Create errors for a problematic way
*
* @param problematic The set of problematic ways (Pairs are
* &lt;incoming/outgoing, Set&lt;Connected ways with same
* issue&gt;&gt;)
* @param mode The transport mode
*/
private void createErrors(List<Pair<String, Set<Way>>> problematic, String mode) {
for (Pair<String, Set<Way>> ways : problematic) { for (Pair<String, Set<Way>> ways : problematic) {
errors.add( errors.add(
TestError.builder(this, SEVERITY_MAP.getOrDefault(ROUTING_ISLAND, Severity.OTHER), ROUTING_ISLAND) TestError.builder(this, SEVERITY_MAP.getOrDefault(ROUTING_ISLAND, Severity.OTHER), ROUTING_ISLAND)
@ -312,7 +320,7 @@ public class RoutingIslandsTest extends Test {
String backward = transportType.concat(":backward"); String backward = transportType.concat(":backward");
boolean possibleForward = "yes".equals(way.get(forward)) || (!way.hasKey(forward) && way.isOneway() != -1); boolean possibleForward = "yes".equals(way.get(forward)) || (!way.hasKey(forward) && way.isOneway() != -1);
boolean possibleBackward = "yes".equals(way.get(backward)) || (!way.hasKey(backward) && way.isOneway() != 1); boolean possibleBackward = "yes".equals(way.get(backward)) || (!way.hasKey(backward) && way.isOneway() != 1);
if (transportType.equals(Access.AccessTags.FOOT.getKey()) && !"footway".equals(way.get("highway")) if (transportType.equals(Access.AccessTags.FOOT.getKey()) && !"footway".equals(way.get(HIGHWAY))
&& !way.hasTag("foot:forward") && !way.hasTag("foot:backward")) { && !way.hasTag("foot:forward") && !way.hasTag("foot:backward")) {
return 0; // Foot is almost never oneway, especially on generic road types. There are some return 0; // Foot is almost never oneway, especially on generic road types. There are some
// cases on mountain paths. // cases on mountain paths.