From b9cd410cd121740a0693d32164a5da3b42548ce7 Mon Sep 17 00:00:00 2001 From: Peter Buchegger Date: Thu, 8 Jun 2023 12:52:03 +0200 Subject: [PATCH] fix cppcheck --- lib/PowerManagement/power_management.cpp | 2 +- src/TaskAprsIs.cpp | 8 +++++--- src/TaskMQTT.h | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/PowerManagement/power_management.cpp b/lib/PowerManagement/power_management.cpp index e81e6bf..f93a7a1 100644 --- a/lib/PowerManagement/power_management.cpp +++ b/lib/PowerManagement/power_management.cpp @@ -1,7 +1,7 @@ #include "power_management.h" -PowerManagement::PowerManagement() { +PowerManagement::PowerManagement() : axp() { } bool PowerManagement::begin(TwoWire &port) { diff --git a/src/TaskAprsIs.cpp b/src/TaskAprsIs.cpp index 16ac6be..81089e0 100644 --- a/src/TaskAprsIs.cpp +++ b/src/TaskAprsIs.cpp @@ -30,9 +30,11 @@ bool AprsIsTask::loop(System &system) { return false; } - std::shared_ptr msg = _aprs_is.getAPRSMessage(); - if (msg) { - _toModem.addElement(msg); + { + std::shared_ptr msg = _aprs_is.getAPRSMessage(); + if (msg) { + _toModem.addElement(msg); + } } if (!_toAprsIs.empty()) { diff --git a/src/TaskMQTT.h b/src/TaskMQTT.h index d388075..082ec2e 100644 --- a/src/TaskMQTT.h +++ b/src/TaskMQTT.h @@ -8,7 +8,7 @@ class MQTTTask : public Task { public: - MQTTTask(TaskQueue> &toMQTT); + explicit MQTTTask(TaskQueue> &toMQTT); virtual ~MQTTTask(); virtual bool setup(System &system) override;