working cppcheck

.github/workflows/build_check.yml

@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@v2
         with:
           submodules: 'recursive'
-      - run: platformio check --fail-on-defect low --fail-on-defect medium --fail-on-defect high --skip-packages --flags "--suppress=*:*.pio\* --inline-suppr" -v
+      - run: platformio check --fail-on-defect low --fail-on-defect medium --fail-on-defect high --skip-packages --flags "--suppress=*:*.pio\* --inline-suppr lib/common/src" -v
 
   PlatformIO-Build:
     runs-on: ubuntu-latest

.gitmodules

@@ -1,3 +1,3 @@
 [submodule "lib"]
-	path = lib/Common
+	path = lib/common
 	url = ../LoRa_APRS_Common

platformio.ini

@@ -16,7 +16,7 @@ lib_deps =
 	peterus/LoRa-APRS-Lib @ 0.0.5
 check_tool = cppcheck
 check_flags =
-    cppcheck: --suppress=*:*.pio\* --inline-suppr
+    cppcheck: --suppress=*:*.pio\* --inline-suppr lib/common/src
 monitor_flags = --raw
 # activate for OTA Update, use the CALLSIGN from is-cfg.h as upload_port:
 #upload_protocol = espota

src/project_configuration.h

@@ -114,8 +114,8 @@ public:
 	virtual ~ProjectConfigurationManagement() {}
 
 private:
-	virtual Configuration * readProjectConfiguration(DynamicJsonDocument & data);
-	virtual void writeProjectConfiguration(Configuration * conf, DynamicJsonDocument & data);
+	virtual Configuration * readProjectConfiguration(DynamicJsonDocument & data) override;
+	virtual void writeProjectConfiguration(Configuration * conf, DynamicJsonDocument & data) override;
 };
 
 #endif