Mike Black W9MDB
6f9d057162
astyle files getting ready for release
2022-05-13 16:50:13 -05:00
Mike Black W9MDB
d0fa5d7776
Small change to rig_vfo_op in rig.c
2022-05-13 16:30:05 -05:00
Mike Black W9MDB
2aa8d4b675
Add some debug to rig.c
2022-05-12 11:09:46 -05:00
Mike Black W9MDB
af8b0d57e9
Change debug in set_powerstat
2022-05-09 09:13:26 -05:00
Mike Black W9MDB
c107fd4af3
Fix rig_flush in rig.c
2022-05-09 07:30:21 -05:00
Mike Black W9MDB
22d4009327
Add flush to set_powerstat to avoid any queued data during power operations
2022-05-09 07:11:01 -05:00
Mike Black W9MDB
b30db5bc59
Fix minor spelling
2022-05-04 13:08:17 -05:00
Mike Black W9MDB
e4bd3c8ede
Improved rigerror
2022-05-04 07:31:18 -05:00
Mike Black W9MDB
3a4d99dd77
Fix rig_set_split_mode detection of existing split status
2022-05-03 12:59:35 -05:00
Mike Black W9MDB
9d73fa737d
More debug in rig.c
2022-05-03 12:51:58 -05:00
Mike Black W9MDB
4ecf274353
Add some more debug to rig.c
2022-05-03 12:48:48 -05:00
Mike Black W9MDB
9d952e6d09
Add some debug to track down cache problem
2022-05-03 12:40:23 -05:00
Mike Black W9MDB
428ca4a196
Update debugmsgsave to save more lines and use less space too
2022-05-03 12:13:02 -05:00
Mike Black W9MDB
0b62193d92
Add new error code for security
...
https://github.com/Hamlib/Hamlib/issues/813
2022-04-29 17:17:43 -05:00
Mike Black W9MDB
2f29f326ab
Ensure cache is update for split
...
https://github.com/Hamlib/Hamlib/issues/1012
2022-04-19 23:06:03 -05:00
Mike Black W9MDB
e409efbaef
Fix TCP connection to Xiegu X6100 to not be overridden by UDP implementation
...
https://github.com/Hamlib/Hamlib/issues/1009
2022-04-16 08:18:16 -05:00
Mike Black W9MDB
770aa4e98a
Stage 1 rigctld password working using MD5 hash
...
Need to add Stage 2 which will be encryption using the MD5 hash as the key so the secret key nevers gets trasmitted
Then need to add a "by connection" capability as password is permanent across connections right now.
2022-04-15 13:21:35 -05:00
Mike Black W9MDB
606609f62e
Improved set_mode error reporting
2022-03-02 07:47:17 -06:00
Mike Black W9MDB
0333cdfca5
astyle files
2022-03-01 11:40:14 -06:00
Mike Black W9MDB
499198bf50
Basic rigctld password working -- still need to add secure method -- plain text right now
...
https://github.com/Hamlib/Hamlib/issues/813
2022-03-01 11:39:11 -06:00
Mike Black W9MDB
b3d93cc231
Remove testsecurity from tests/Makefile.am
...
Will implement later
https://github.com/Hamlib/Hamlib/issues/813
2022-02-28 13:08:41 -06:00
Mike Black W9MDB
1444448aeb
Allow rig_get_vfo_list to work if rig is not open
2022-02-25 07:41:10 -06:00
Mike Black W9MDB
9ae519fc41
Working on password access for rigctld -- not fully implmented yet
...
Need to check on security audit and cross-platform compilation first
https://github.com/Hamlib/Hamlib/issues/813
2022-02-24 17:28:25 -06:00
challinan
d6f05e1974
Correct compiler warning - s.b. bitwise or
2022-02-19 21:39:17 -05:00
Michael Black
c0630312a3
Merge pull request #965 from challinan/master
...
Removed redundant RETURNFUNC() call
2022-02-16 12:03:16 -06:00
challinan
779c2d344e
Removed redundant RETURNFUNC() call
2022-02-16 12:55:44 -05:00
Mike Black W9MDB
799b588a7c
Add some RETURNFUNC2 to rig.c for errors
2022-02-14 17:44:40 -06:00
Mike Black W9MDB
a0fc3eaffa
Add a check to a bogus warning in rig.c to make it correct
2022-02-07 07:17:51 -06:00
Mike Black W9MDB
776c68e3b1
Allow backwards compatibility for rigctl and rigctld by copying deprecated values to new port_t structures
2022-02-05 23:55:46 -06:00
Mike Black W9MDB
8c34ce1a2d
astyle source code
2022-02-05 15:27:43 -06:00
Mike Black W9MDB
81d61c09cc
Remove temp debug from rig.c
...
https://github.com/Hamlib/Hamlib/issues/947
2022-02-03 23:10:04 -06:00
Mike Black W9MDB
9aade8de3f
Add config.h to include/hamlib so HAVE_PTHREAD is available if needed
...
https://github.com/Hamlib/Hamlib/issues/947
2022-02-03 22:31:42 -06:00
Mike Black W9MDB
bbd20c45dd
Fix valgrind-discovered unitialized curr_vfo in rig.c
2022-02-03 10:41:54 -06:00
Mike Black W9MDB
5a1e73396c
Remove FUNC calls from rig_cleanup as rig is closed
2022-02-03 08:38:17 -06:00
Mike Black W9MDB
9852288992
Baland RETURNFUNC statements in rig.c
2022-02-02 23:48:42 -06:00
Mike Black W9MDB
c4e01ddadb
Change debug level from BUG to VERBOSE for debugging.
...
Causes abort in JTDX when BUG is used
https://github.com/Hamlib/Hamlib/issues/947
2022-02-02 08:45:46 -06:00
Mike Black W9MDB
9ede1174a3
Add temporary debug for rig->state.pttport.type.ptt diagnosis
...
https://github.com/Hamlib/Hamlib/issues/947
2022-02-02 07:45:00 -06:00
Mike Black W9MDB
9dd5f70b01
Add some more copy for hamlib_deprected structures
...
https://github.com/Hamlib/Hamlib/issues/947
2022-02-01 11:29:26 -06:00
Mike Black W9MDB
011f9789e2
Add another copy to deprecated hamlib_port to fix PTT method in JTDX/WSJTX
...
https://github.com/Hamlib/Hamlib/issues/947
2022-02-01 07:57:59 -06:00
Mike Black W9MDB
171f581243
Fix rig_set_ptt to copy new hamlib_port_t structure to deprecated
2022-01-31 06:58:49 -06:00
Mike Black W9MDB
7b4b7ee630
Add a depth count to debug statements to help understand calling sequences
...
First call into rig functions is level 1
Top level like rigctl, rigctld is level 0
Non-depth calls are internal debug statements -- which can be modified to also show levels but that's a whole lot of statements not really necessary
Normal calls from other clients will be level 1
2022-01-30 23:37:01 -06:00
Mike Black W9MDB
63b31eac4e
Add tx_freq to debug statement
2022-01-30 10:51:49 -06:00
Mike Black W9MDB
3c60636b80
In rig_set_split rx_vfo set to vfo value passed in
2022-01-30 07:28:52 -06:00
Mike Black W9MDB
afd595d2da
Allow asyncio rigs to use cached-only values for rig_get_freq and rig_get_mode
...
https://github.com/Hamlib/Hamlib/issues/894
2022-01-29 08:39:27 -06:00
Mike Black W9MDB
86c62d5dbb
Remove ASYNC_BUG #ifdef blocks as it is all working now
2022-01-28 09:55:48 -06:00
Mike Black W9MDB
fab7f4d54c
Revert "Revert "Deprecate hamlib_port_t to hamlib_port_t_deprecated""
...
Fixing hamlib_port_t deprecation
This reverts commit f696123a3b
.
https://github.com/Hamlib/Hamlib/issues/894
2022-01-27 06:37:55 -06:00
Mike Black W9MDB
b5bcae4af3
Fix compilation after revert
2022-01-26 18:04:29 -06:00
Mike Black W9MDB
f696123a3b
Revert "Deprecate hamlib_port_t to hamlib_port_t_deprecated"
...
This reverts commit 401e718d60
.
2022-01-26 17:56:58 -06:00
Mike Black W9MDB
2028d4d1fa
Add some more memcpy's to sync hamlib_port_t_deprecated
...
https://github.com/Hamlib/Hamlib/issues/894
2022-01-26 17:44:03 -06:00
Mike Black W9MDB
81bb70bb84
Deprecate hamlib_port_t to hamlib_port_t_deprecated
...
New hamlib_port_t at end of structure -- eventually need to change this to a pointer'
Enable ASYNC_BUG now works with new hamlib_port_t
Backwards compatible with already-compiled clients and newly-compiled clients
https://github.com/Hamlib/Hamlib/issues/894
2022-01-26 12:39:13 -06:00
Mike Black W9MDB
a277d7ab9b
Changes changing hamlib_port_t to pointer are not backwards compatible
2022-01-25 17:41:26 -06:00
Mike Black W9MDB
cb36210ddb
Revert "Fix rig.c memcpy to deprecated hamlib_port_t"
...
This reverts commit 27adcc2e75
.
2022-01-25 15:02:51 -06:00
Mike Black W9MDB
27adcc2e75
Fix rig.c memcpy to deprecated hamlib_port_t
2022-01-25 14:52:07 -06:00
Mike Black W9MDB
9e86e62238
Enable async I/O by default
...
Change hamlib_port_t to a pointer in rig.state
Deprecate static hamlib_port_t structure
New hamlib_port_t structure at end of rig.state
Clients built with older hamlib will use old structure in DLL
Clients built with newer hamlib will use new structure in DLL
So we maintain backwards compatibility until Hamlib 5.0
https://github.com/Hamlib/Hamlib/issues/894
2022-01-25 07:59:47 -06:00
Mike Black W9MDB
4dfaa03838
Enable ASYNC and rename async to asynio to avoid python name collision
...
https://github.com/Hamlib/Hamlib/issues/894
2022-01-24 10:37:07 -06:00
Michael Black
51da62f3fb
Merge pull request #943 from mikaelnousiainen/async-rigctld-icom-bugfixes
...
Bugfixes for async I/O, rigctld and Icom backend
2022-01-23 11:49:14 -06:00
Mike Black W9MDB
1beebfc835
Make set_transaction functions use intra process mutex -- Phase 1
...
Phase 2 will be inter-process named mutexes
https://github.com/Hamlib/Hamlib/issues/942
2022-01-23 09:01:06 -06:00
Mikael Nousiainen
1f428c8d95
Allow icom_rig_open() to succeed even if the rig is powered off. Fix issues with async I/O error code propagation. Allow rigctld daemon to start even if rig is powered off. Add mutex locks around rig_open()/rig_close() calls as multiple client connections could end up calling them concurrently, which could lead to all kinds of issues as the functions are not meant to be thread-safe. This also blocks execution of rigctl commands during rig open/close.
2022-01-22 23:19:07 +02:00
Mike Black W9MDB
970d253866
In rig_set_vfo query vfo first to see if it needs to be changed.
...
Doing VS0 on an FTDX-3000 was causing VFOA to mute
https://github.com/Hamlib/Hamlib/issues/903
2022-01-19 15:40:08 -06:00
Mike Black W9MDB
09c9b01552
Change snprintf to SNPRINTF in src
...
https://github.com/Hamlib/Hamlib/issues/857
2022-01-19 09:11:04 -06:00
Mike Black W9MDB
e2bb11aa4c
Change sprintf to SNPRINTF in misc.c, network.c, and rig.c
...
https://github.com/Hamlib/Hamlib/issues/857
2022-01-18 15:07:49 -06:00
Mike Black W9MDB
165b5b2921
Change sprint to SNPRINTF in rig.c
...
https://github.com/Hamlib/Hamlib/issues/857
2022-01-18 14:39:34 -06:00
Mikael Nousiainen
2857a54ea6
Allow enabling of async data mode via conf option. Ignore multicast data publishing if the publisher routine is not enabled.
2022-01-05 19:12:43 +02:00
Mikael Nousiainen
8ee0383464
Merge branch 'master' into async-io-on-windows
2022-01-03 14:40:09 +02:00
Mikael Nousiainen
a00d78c860
Implement pipes using asynchronous/overlapped I/O on Windows
2022-01-03 14:18:49 +02:00
Mike Black W9MDB
01b7f81119
Add a data tag to the caps structure and a test in rig_init to ensure the data tag is where it is expected
...
Modify testrigcaps.c to test new data tag
This should detect any changes which corrupt rig_caps from additons/subtractions/changes to the structure
2021-12-31 23:49:29 -06:00
Mike Black W9MDB
80188965a1
Comment out more async code
2021-12-29 22:28:32 -06:00
Mike Black W9MDB
05bed8f52e
Add vfo_fixup to rig_get_mode
2021-12-28 23:50:32 -06:00
Mike Black W9MDB
99f964ed72
Add vfo_fixup to rig_set_mode
2021-12-28 23:20:57 -06:00
Mike Black W9MDB
f5b229f9dc
Re-enable serial_flush
2021-12-28 11:26:02 -06:00
Mike Black W9MDB
36859c33dc
Fix rig_open
2021-12-28 07:49:45 -06:00
Mike Black W9MDB
045ab048f1
Remove more async code to clean up compiler warning for 4.5
2021-12-27 17:09:50 -06:00
Mike Black W9MDB
1518b8033c
If -RIG_ENTARGET returns from set_freq it will be ignored
...
This will covers rigs that cannot set freq while transmitting like the FTDX3000 and FTDX5000
https://github.com/Hamlib/Hamlib/issues/906
2021-12-27 14:46:56 -06:00
Mike Black W9MDB
2fe9117639
Disable async processing and move async definitions out of hamlib_port_t
...
This broke backwards compatibility with DLL/shared libraries
2021-12-26 22:24:09 -06:00
Mike Black W9MDB
72dac9a573
Disable async startup code on Windows
...
Need a custom pipe function for Windows to work
https://github.com/Hamlib/Hamlib/issues/902
2021-12-25 12:33:32 -06:00
Mikael Nousiainen
c764336e73
Fix build warnings caused by changes to I/O function signatures
2021-12-18 23:49:45 +02:00
Mikael Nousiainen
1d067d6a43
Merge branch 'master' into async-reader
2021-12-12 23:05:48 +02:00
Mikael Nousiainen
56c95b1529
Merge upstream changes and fix conflicts
2021-12-12 23:05:26 +02:00
Mike Black W9MDB
5e15159c79
Move debug in set_ptt to see logic for serial port sharing
2021-12-12 08:17:30 -06:00
Mike Black W9MDB
674a9868d9
Implement ISO8601 time standard in more places.
...
Debug time now shows localtime + utc offset
Rigs that can set the clock now can set either local or utc time on the rig
Icom rigs can only display clock#1 right now so users may want either local or utc
So here are IC7300 examples
rigctl -m 3073 -r com3 -s 115200 set_clock local
rigctl -m 3073 -r com3 -s 115200 set_clock utc
2021-12-06 10:23:18 -06:00
Mike Black W9MDB
07cac7be76
Move ELAPSED macros to rig.h for global use
...
Add ELAPSED to get_vfo_info in rigctl_parse.c
2021-12-05 09:46:00 -06:00
Mike Black W9MDB
a1da584bc1
Add HAMLIB_CACHE_ALWAYS to rig_get_mode
...
https://github.com/Hamlib/Hamlib/issues/880
2021-12-02 16:53:22 -06:00
Mike Black W9MDB
b5a4e99a3e
Add HAMLIB_CACHE_ALWAYS
...
Enable for rig_get_freq
https://github.com/Hamlib/Hamlib/issues/880
2021-12-02 16:44:39 -06:00
Mike Black W9MDB
a1c8493c62
First cut at clock setting for IC7300/7800/785x/9700
...
https://github.com/Hamlib/Hamlib/issues/851
2021-12-01 11:50:33 -06:00
Mikael Nousiainen
c20f397c24
Refactor WIN32 I/O port routines to be hopefully compatible with async data reader (not tested). Fix some incomplete data fields in UDP snapshot packets.
2021-11-30 09:25:51 +02:00
Mike Black W9MDB
a36b74deca
https://github.com/Hamlib/Hamlib/issues/514
2021-11-29 16:08:24 -06:00
Mikael Nousiainen
d857f18163
Initial implementation of: reader thread for async handling of rig data, UDP multicast publisher routine and rig state poll thread routine. The reader thread can correctly handle asynchronous data, such as transceive or spectrum data. Work in progress: multi-platform code for I/O routines still missing and the poll routine is not yet in use. Tested briefly on an IC-7300 so far.
2021-11-28 20:52:29 +02:00
Mike Black W9MDB
63a51c36a1
astyle files preparing for 4.4 release
2021-11-28 12:41:10 -06:00
Mike Black W9MDB
5cf68f3647
Get the correct rx_vfo when split is off
...
https://github.com/Hamlib/Hamlib/issues/872
2021-11-25 12:17:39 -06:00
Mike Black W9MDB
643e18dc28
Ensure rx_vfo is set correctly based on tx_vfo requested
...
https://github.com/Hamlib/Hamlib
2021-11-25 09:34:23 -06:00
Mike Black W9MDB
71662c79f8
Remove rig_lock/unlock as not needed for eventual async i/o implementation
2021-11-24 15:52:37 -06:00
Mike Black W9MDB
d1a7964ac4
Allow for set_split with VFOA/VFOA to put RX VFO on VFOB
2021-11-24 13:33:16 -06:00
Mike Black W9MDB
8928672e2c
Rigs with non-targetable set_mode will now use cached values to determine if mode needs to be changed
...
Hamlib 5.0 plans are to start using transceive mode and AI2 mode to detect rig changes so eventually
users on these types of rigs will be able to twiddle knobs and hamlib will follow.
But for now we are avoiding the VFO flashing and relay chattering on non-targetable rigs
https://github.com/Hamlib/Hamlib/issues/872
2021-11-24 09:03:26 -06:00
Mike Black W9MDB
238e17b736
rig_set_mode for non-targetable rigs will only set mode on VFOB once per run unless mode is changed
...
This allows subsequent rig_set_mode to execute quickly without any VFO juggling
If user twiddles with VFOB mode they are on their own
https://github.com/Hamlib/Hamlib/issues/872
2021-11-22 16:54:22 -06:00
Mikael Nousiainen
39cec4aa27
Merge branch 'master' into async-reader
2021-11-20 22:50:55 +02:00
Mikael Nousiainen
1f538ad7ec
Started work on asynchronous reader thread to enable handling of rig tranceive and waterfall data (WIP)
2021-11-20 21:33:29 +02:00
Mike Black W9MDB
4b3bbabc5d
Fix rig_set_split problem on Kenwood rigs
...
https://github.com/Hamlib/Hamlib/issues/872
2021-11-19 16:19:18 -06:00
Mike Black W9MDB
8c3e8fed28
Improved debug in rig_get_cache
...
https://github.com/Hamlib/Hamlib/issues/872
2021-11-18 10:42:58 -06:00
Mike Black W9MDB
3de368f6a2
Add rig_lock and rig_unlock to support serial I/O locking for a transaction
...
https://github.com/Hamlib/Hamlib/issues/695
2021-11-15 07:16:31 -06:00
Mike Black W9MDB
8b5685425a
For non-targetable VFOs we will set VFO on every set_freq
...
https://github.com/Hamlib/Hamlib/issues/865
2021-11-11 17:10:57 -06:00
Mike Black W9MDB
e64a128f3a
In rig_set_split_mode and rig mode is not targetable we disable split, set mode, and re-enable to avoid vfo flashing.
...
This disable is moved behind the targetable mode now as it should not be required in that case
https://github.com/Hamlib/Hamlib/issues/863
2021-11-09 23:52:21 -06:00
Mike Black W9MDB
61141126c1
Add more ELAPSED timings
2021-11-09 23:20:02 -06:00
Mike Black W9MDB
68edfe3357
Add more ELAPSED timings
2021-11-09 23:14:44 -06:00
Mike Black W9MDB
9eccaec6af
Improve debug in rig_get_split_vfo
2021-11-09 23:07:02 -06:00
Mike Black W9MDB
eed9637675
Do not change split freq if change not needed
...
https://github.com/Hamlib/Hamlib/issues/863
2021-11-09 17:06:48 -06:00
Mike Black W9MDB
663b149a48
Fix ELAPSED macros in rig.c to provide more accurate timing
2021-11-07 07:36:46 -06:00
Mike Black W9MDB
6ca9844196
In rig.c do not override curr_vfo if it gets set by the backend
...
https://github.com/Hamlib/Hamlib/issues/853
2021-11-05 17:23:10 -05:00
Mike Black W9MDB
ffe3c9d012
Revert "Change rig_set_split_mode to use TOGGLE first, then set_vfo"
...
This reverts commit c1c549cbf3
.
2021-11-05 06:37:45 -05:00
Mike Black W9MDB
e7530643a0
In rig.c set rxvfo and txvfo to current if currvfo is requested
...
https://github.com/Hamlib/Hamlib/issues/838
2021-11-03 15:00:38 -05:00
Mike Black W9MDB
c1c549cbf3
Change rig_set_split_mode to use TOGGLE first, then set_vfo
...
https://github.com/Hamlib/Hamlib/issues/838
2021-11-03 13:11:11 -05:00
Mike Black W9MDB
b4f4228650
Revert "Change rig_set_split_mode to disable/enable ptt by rig model as needed"
...
This reverts commit c1c1f1f053
.
2021-11-03 12:37:38 -05:00
Mike Black W9MDB
c1c1f1f053
Change rig_set_split_mode to disable/enable ptt by rig model as needed
...
https://github.com/Hamlib/Hamlib/issues/838
2021-11-03 08:16:39 -05:00
Mike Black W9MDB
8fe190d622
Reduce error messages about RIG_VFO_OTHER which only applies to some rigs like Icom rigs with the 0x25 command
...
Add a flush_flag to read_string so that the new serial_flush will not produce a timeout value when flushing
https://github.com/Hamlib/Hamlib/issues/835
2021-11-01 23:43:45 -05:00
Mike Black W9MDB
603223d493
During rig_set_split_mode and non-targetable mode we will turn off split, set mode, and turn split back on. This should prevent some ugly flashing on Yaesu rigs
...
https://github.com/Hamlib/Hamlib/issues/838
2021-11-01 22:15:50 -05:00
Mike Black W9MDB
dc585776fc
Add rig pointer to hamlib_port_t
2021-10-30 08:53:45 -05:00
Mike Black W9MDB
9d2aaa00c0
Disallow set_split_vfo when PTT is active
...
https://github.com/Hamlib/Hamlib/issues/844
2021-10-28 09:49:18 -05:00
Mike Black W9MDB
6f82645ee8
Revert "Disallow set_split_vfo when ptt is active"
...
Had other temporary code in it
This reverts commit db9cd44bcf
.
2021-10-28 09:46:52 -05:00
Mike Black W9MDB
db9cd44bcf
Disallow set_split_vfo when ptt is active
...
https://github.com/Hamlib/Hamlib/issues/844
2021-10-28 09:44:57 -05:00
Mike Black W9MDB
5cdbdd04c6
Add rig backends in 0 range (maingly FlRig and rigctld) to targetable_ptt -- should avoid some vfo swapping going on
...
https://github.com/Hamlib/Hamlib/issues/836
2021-10-22 17:15:35 -05:00
Mike Black W9MDB
014219c4ad
Add RIG_OTHER_VFO handling to rig_get_cache
...
https://github.com/Hamlib/Hamlib/issues/835
2021-10-21 22:31:38 -05:00
Mike Black W9MDB
8a983cae80
Clean up MUTEX declarations in rig.c
2021-10-14 23:06:57 -05:00
Mike Black W9MDB
da34930ab9
Fix rig_get_mode cache time printout
2021-10-14 11:36:34 -05:00
Mike Black W9MDB
ac43daa998
Add some more elapsed time monitoring
2021-10-14 11:32:30 -05:00
Mike Black W9MDB
dd1376becf
Fix debug statement
...
https://github.com/Hamlib/Hamlib/issues/812
2021-09-28 23:13:37 -05:00
Mike Black W9MDB
da87903e3c
Fix set_vfo for non TARGETABLE_FREQ rigs like the FT100
...
Was not setting VFOB when requested
https://github.com/Hamlib/Hamlib/issues/812
2021-09-28 23:03:56 -05:00
Mike Black W9MDB
7c42d6ddb0
Fix LOCK macros
2021-09-28 23:03:06 -05:00
Mike Black W9MDB
43251254c5
New mutex macros to be resued across all rig functions to support async multicast actions
2021-09-28 22:57:35 -05:00
Mike Black W9MDB
7bd407beda
Add some more elapsed time entries and reduce ELAPSED2 macro
2021-09-25 23:26:49 -05:00
Mike Black W9MDB
2e2543a0fc
Fix ELAPSED2 time
2021-09-25 23:16:08 -05:00
Mike Black W9MDB
0b9b719997
Add elapsed time macros and put in vfo and freq calls
2021-09-25 08:59:57 -05:00
Wouter van Gulik
a3ab4a4312
Fix rig_cookie: use lock for reads and write.
...
Ensure we never print more then HAMLIB_COOKIE_SIZE otherwise we read
out-of-bounds.
Drop stray printf.
Add tests for invalid input and overly large input.
Fix test2 to release the cookie.
2021-09-20 22:10:55 +02:00
Wouter van Gulik
d9e1f5aac4
Fix and document rig_cookie;
...
Example in doxygen was wrong.
Description of parameters was wrong; we return an int so we cannot return
a NULL.
NULL check for cookies is needed for all 3 commands so move it up, fixing the
missing one.
Length check was wrong; cookie needs to be at least as large as
HAMLIB_COOKIE_SIZE otherwise subsequent checks will always faila
Document the 3 cookie commands a bit.
2021-09-19 22:52:41 +02:00
Wouter van Gulik
82785f81dc
Replace RIG_EIO with RIG_EINVAL when checking arguments. RIG == NULL is
...
an argument error. A rig not properly inited (caps == NULL) is also an
invalid argument.
2021-09-19 22:18:03 +02:00
Wouter van Gulik
f029769fb7
Add arguments check for rig_get_cache, rig_stop_morse, rig_wait_morse,
...
rig_get_range, rig_set_vfo_opt, rig_get_infget_info.
2021-09-19 22:12:21 +02:00
Mike Black W9MDB
d60e82c222
Reduce scope of vars in rig.c
2021-09-13 17:41:53 -05:00
Mike Black W9MDB
16263e8338
Remove shadow var from rig.c
2021-09-13 17:38:37 -05:00
Wouter van Gulik
fe2f24cba3
Make make_crc_table and gen_crc static.
2021-09-09 22:47:57 +02:00
Wouter van Gulik
720f8fa86e
Fix documentation for get_info. Memory is not allocated!
...
Prevent users from trying to free it.
2021-09-09 22:42:55 +02:00
Wouter van Gulik
3edc59dbd2
Add documentation for rig_get_cache.
...
Note that it misses all sanity check on the input, but at least that is
now documented.
Made rig_check_rig_caps and twiddling static, they are not exported
but Doxygen includes all globally visible function.
2021-09-09 22:36:43 +02:00
Wouter van Gulik
d6c1c4ec78
rig.c/rig_reset Make defines a link in the documentation
2021-09-09 22:15:16 +02:00
Wouter van Gulik
9134fa55c9
rig.c: Fix Doxygen for rigerror
2021-09-08 22:57:04 +02:00
Wouter van Gulik
998e19bdd4
Fix Doxygen in rig.c. Commit c5c60f0
also touched Doxygen comments which
...
was not intended. It replaced \return with \RETURNFUNC. Breaking
Doxygen.
2021-09-08 22:45:36 +02:00
Mike Black W9MDB
c53a288cd8
Add debug to show vfofixup being skipped due to satmode rig
2021-09-06 07:41:33 -05:00
Mike Black W9MDB
6de4588335
Do not do vfo_fixup on satmode rigs
...
https://github.com/Hamlib/Hamlib/issues/782
2021-09-01 12:45:29 -05:00
Mike Black W9MDB
f65022b4ca
If set_split_freq_mode is called when split=off we'll turn on split based on current vfo selection
...
https://github.com/Hamlib/Hamlib/issues/764
2021-08-30 08:45:56 -05:00
Mike Black W9MDB
f552e3f0e8
Fix set_split_vfo to use correct RX vfo instead of TX vfo
...
https://github.com/Hamlib/Hamlib/issues/762
https://github.com/Hamlib/Hamlib/issues/430
2021-08-28 09:54:37 -05:00
Mike Black W9MDB
4653aa2f6e
astyle files
2021-08-27 22:25:53 -05:00
Mike Black W9MDB
b41f706eda
Fix uninitialized warning in rig.c
...
https://github.com/Hamlib/Hamlib/issues/762
https://github.com/Hamlib/Hamlib/issues/430
2021-08-27 15:51:02 -05:00
Mike Black W9MDB
f6b54df7c7
Fix some more unnecessary vfo swapping
...
https://github.com/Hamlib/Hamlib/issues/762
https://github.com/Hamlib/Hamlib/issues/430
2021-08-27 15:46:23 -05:00
Mike Black W9MDB
5a0590d421
Finish up targetable_ptt logic
...
Was causing unnecessary vfo swapping
https://github.com/Hamlib/Hamlib/issues/762
https://github.com/Hamlib/Hamlib/issues/430
2021-08-27 12:50:53 -05:00