George Baltz N3GB
8589d5c6bc
Fix unbalanced ENTERFUNC/RETURNFUNC pairs in icom.c
...
Also tweak comments/formats to eliminate false positives in code base
(except for the Catch-22 ones in tests/func_chk.c itself)
2024-12-22 16:48:56 -05:00
Daniele Forsi IU5HKX
6036a65d2e
Fix typos in comments
2024-11-24 19:24:35 +01:00
Mike Black W9MDB
22c0001320
Another IC-PW2 change
2024-11-11 17:01:11 -06:00
Mike Black W9MDB
3bd462308c
Another IC-PW2 try
2024-11-11 16:55:12 -06:00
Mike Black W9MDB
356776f4bf
Another fix for IC-PW2
2024-11-11 16:48:54 -06:00
Mike Black W9MDB
27643a9a0e
Another fix for IC-PW2
2024-11-11 16:32:04 -06:00
Mike Black W9MDB
7a98365c15
Other file for IC-PW2 fix
2024-11-11 16:27:20 -06:00
Mike Black W9MDB
5c269964c2
astyle files in preparation for release 4.6
2024-11-06 08:07:34 -06:00
Mike Black W9MDB
49e870cfb8
Remove collision_retry=0 in icom/frame.c -- was causing a loop when random data received
...
https://github.com/Hamlib/Hamlib/issues/1604
2024-10-30 16:41:29 -05:00
Mike Black W9MDB
f64727c1e0
Limit collision_retry to 2 times in icom's frame.c
2024-08-31 22:25:58 -05:00
Mike Black W9MDB
7b71bc09ab
Change timeout on IC7100 to 700ms instead of 1000ms
...
Hopefully allow for timeout when async packets are coming in every 1000ms
https://github.com/Hamlib/Hamlib/issues/1587
2024-08-04 17:11:19 -05:00
Mike Black W9MDB
df48595add
Put rig_flush back in frame.c for the IC-7100 -- hopefully fixed async packets on the CI-V port coming from amplifiers
...
The 7100 cannot unlink the CI-V port and these async packets are not being handled well.
https://github.com/Hamlib/Hamlib/issues/1587
2024-08-04 11:51:18 -05:00
Mike Black W9MDB
fe43a6425e
In icom frame.c move the frm building inside the collision_retry block
...
https://github.com/Hamlib/Hamlib/issues/1587
2024-08-02 16:31:49 -05:00
Mike Black W9MDB
9d8cc7d260
Move the async detection for Icom to after the echo detection
...
https://github.com/Hamlib/Hamlib/issues/1587
2024-08-01 17:30:03 -05:00
Mike Black W9MDB
ff71f202c9
Another attempt to fix IC7100 behavior when amplifier is sending requests
...
Seems the IC7100 cannot separate the CI-V port from the USB CI-V like other Icom rigs
2024-08-01 11:59:15 -05:00
Mike Black W9MDB
725542775b
Hopefully fix IC-7100 0xe1 packet async problem
2024-07-31 11:49:59 -05:00
Mike Black W9MDB
b718788c9a
Echo detection is now dynamic so can be changed while running
...
Async packet is now handled correctly...may be tied to the ANT CI-V port
https://github.com/Hamlib/Hamlib/issues/1575
https://github.com/Hamlib/Hamlib/issues/1587
https://github.com/Hamlib/Hamlib/issues/1588
2024-07-25 12:08:23 -05:00
Mike Black W9MDB
75783cb125
Revert "Try to fix IC-7100 remote operation echo oddity"
...
Seems to break things severely
This reverts commit ed33a235f4
.
2024-07-23 09:34:09 -05:00
Mike Black W9MDB
ed33a235f4
Try to fix IC-7100 remote operation echo oddity
...
https://github.com/Hamlib/Hamlib/issues/1575
2024-07-22 16:57:14 -05:00
Mike Black W9MDB
56d55f59b3
Fix echo bug
...
https://github.com/Hamlib/Hamlib/issues/1581
2024-07-17 11:38:59 -05:00
Mike Black W9MDB
5814f745b9
Allow Icom rigs to skip packets that do not match the cmd/subcmd sent.
...
This should allow some sharing between controllers
2024-07-07 12:53:22 -05:00
Mike Black W9MDB
388a18e5da
IC-7100 is sending 0xe1 for broadcast frames so add 0xe1 as an async packet type
...
https://github.com/Hamlib/Hamlib/issues/1575
2024-07-05 08:16:30 -05:00
Mike Black W9MDB
660bfcb1d9
Allow 0xe1 async frames in icom frame.c
2024-07-04 17:24:11 -05:00
George Baltz N3GB
096af1f592
More of the balancing act.
...
Mostly ENTERFUNC/RETURNFUNC.
2024-06-26 10:16:12 -04:00
George Baltz N3GB
f5870c84ef
First set of rigs/icom/* state pointer macros.
2024-06-08 03:55:08 -04:00
Mike Black W9MDB
6a98b0b9cb
Rest of commit -- if setting FM width to other than 7000/10000/15000 cache will show requested width until next poll
...
https://github.com/Hamlib/Hamlib/issues/1533
2024-04-22 17:48:59 -05:00
Mike Black W9MDB
1045620313
Return error on bad read_icom_frame
2024-03-15 07:27:19 -05:00
Mike Black W9MDB
7831dfc311
Icom async packets now work when ci-v echo is on.
...
async packets are handled individually and not flushed anymore
2024-03-01 16:41:44 -06:00
Mike Black W9MDB
12404aa8a6
Ignore ICOM transceive frames
2024-03-01 12:56:20 -06:00
George Baltz N3GB
464eea58e7
Convert rigs/icom/, rigs/kit/
2024-02-05 11:28:31 -05:00
Mike Black W9MDB
e267c62764
astyle files
2023-12-16 11:37:58 -06:00
Mike Black W9MDB
e2354333f3
Return early in icom/frame.c on BUSERROR
2023-10-14 12:01:15 -05:00
Mike Black W9MDB
f0765e6c3a
Remove more noisy debug from frame.c
2023-08-12 11:32:27 -05:00
Mike Black W9MDB
7392d206a8
Remove noisy debug from frame.c
2023-08-12 11:06:42 -05:00
Mike Black W9MDB
d7d450df49
Add parm BANDSELECT for Yaesu rigs
...
'p BANDSELECT' returns current band of VFOA
'P BANDSELECT BAND160M' example selects the 160M band
'P BANDSELECT ?' shows bands available for the rig
Kenwood rigs will be next
Icom rigs TBD when Icom explains the return from 0x1a 0x01 -- no bandselect possible so manual setting of rig values
https://github.com/Hamlib/Hamlib/issues/1353
2023-08-11 10:40:42 -05:00
Mike Black W9MDB
17c5a8aed9
Fix cppcheck shadow variable
2023-08-02 23:32:02 -05:00
Mike Black W9MDB
d76e28d772
Fix cppcheck warnings
2023-08-02 17:32:51 -05:00
Mike Black W9MDB
fcba1cab20
Make icom echo check skip the 1st two bytes of the frame
...
Saw an instance where the 1st 0xfe was corrupted so this allows for that
2023-07-24 17:35:14 -05:00
Mike Black W9MDB
23639557a0
Revert "Remove rig_flush from icom/frame.c"
...
This reverts commit ca3f19fbd6
.
Evidence showing this is needed when sequencing is lost
Instead we need to improved Windows serial_flush
2023-07-24 08:30:14 -05:00
Mike Black W9MDB
ca3f19fbd6
Remove rig_flush from icom/frame.c
...
Speeds up Windows serial i/o by about 6ms per call for Icom rigs
https://github.com/Hamlib/Hamlib/issues/1123
2023-07-23 14:55:27 -05:00
Mike Black W9MDB
dc1fa7f450
Remove ENTERFUNC from frame.c to balance
2023-06-09 22:39:24 -05:00
Mike Black W9MDB
dad55ef148
astyle files getting ready for WSJT-x-2.7.0rc1
2023-05-08 07:37:13 -05:00
Mike Black W9MDB
e82f127965
Allow icom read_frame to return when bus collision occurs
...
https://github.com/Hamlib/Hamlib/issues/1280
2023-04-26 15:38:08 -05:00
Mike Black W9MDB
07ba41d551
Add a retry in icom frame.c in case of collision
...
https://github.com/Hamlib/Hamlib/issues/1280
2023-04-25 11:07:25 -05:00
Daniele Forsi IU5HKX
6f0efd59e6
Fix check for RIG_BUSBUSY
...
Fixes a cppcheck warning:
rigs/icom/frame.c:510:19: style: Redundant condition: The condition 'i != 14' is redundant since 'i < 0' is sufficient. [redundantCondition]
if (i < 0 && i != RIG_BUSBUSY) /* die on errors */
2023-04-11 23:28:46 +02:00
Mikael Nousiainen
f17f6f0f42
Disable rig port flushing when async I/O is enabled. Improve validation of Icom frames.
2023-03-08 23:35:08 +02:00
Daniele Forsi IU5HKX
7211730866
[icom] Fix includes
2023-02-16 19:08:24 +01:00
Mike Black W9MDB
1efff461e3
Have icom rigs show debug when civ addr has been changed and timeout occurs
...
https://github.com/Hamlib/Hamlib/issues/1229
2023-02-04 14:22:57 -06:00
Mike Black W9MDB
a83eb3bf42
astyle files for 4.5 release
2022-07-27 17:16:17 -05:00
Mike Black W9MDB
e0d39b3dcb
Change IC7800 mode definitions to allow for PKTUSB and PKTLSB
...
https://github.com/Hamlib/Hamlib/issues/1057
2022-06-07 17:40:38 -05:00