Daniele Forsi IU5HKX
e11b4bd01c
Fix segfaults with malformed input and wrong command line arguments
...
Fixes:
NULL dereference.
Steps to reproduce:
echo L | tests/ampctl
echo L | tests/rigctl
echo L | tests/rotctl
2023-04-10 19:44:40 +02:00
Daniele Forsi IU5HKX
2db37fe7db
Fix typos
2023-03-26 11:01:51 +02:00
Daniele Forsi IU5HKX
3f90086991
[tests] Fix includes
2023-02-16 19:08:24 +01:00
Mike Black W9MDB
a47eba7ce4
Revert "Update NEWS"
...
This reverts commit 76a3ab19eb
.
2023-01-24 11:25:49 -06:00
Mike Black W9MDB
76a3ab19eb
Update NEWS
2023-01-24 11:23:47 -06:00
Mike Black W9MDB
cdbd517228
Remove double execution of get_powerstat -- was causing rigctld to give an error
...
https://github.com/Hamlib/Hamlib/issues/1220
2023-01-21 12:55:44 -06:00
Mike Black W9MDB
c78371353c
Allow get_powerstat when rig is powered off
...
https://github.com/Hamlib/Hamlib/issues/1220
2023-01-19 17:15:59 -06:00
Mike Black W9MDB
d180883f3e
Allow rigctl/rigctld to continue when a bad set_conf is called -- just shows a warning now
2023-01-17 09:22:55 -06:00
Mike Black W9MDB
29a80fb496
Fix get_powerstat call when get_powerstat is not defined
...
https://github.com/Hamlib/Hamlib/issues/1217
2023-01-13 17:30:55 -06:00
Mike Black W9MDB
4689a2ff11
Add client_version for rigctld clients to report their version to rigctld
...
This should allow for rigctld to report deprecation, compatibility, or alternatives
https://github.com/Hamlib/Hamlib/issues/1153
2022-12-23 23:39:20 -06:00
Mike Black W9MDB
f468fa3c1d
Allow POWERSDR to do commands when powered off
2022-12-19 16:58:44 -06:00
Mike Black W9MDB
2b145fe717
Add netrigctl_send_raw to allow send_raw to work with rigctld
...
https://github.com/Hamlib/Hamlib/issues/1157
2022-12-01 16:20:23 -06:00
Mike Black W9MDB
f81c20eb37
Astyle files
2022-11-28 10:48:17 -06:00
Mike Black W9MDB
66d0dc9a5d
Fix mingw64 warnings
2022-11-28 09:01:28 -06:00
Mike Black W9MDB
6995986880
Change rigctl_powerstat message to only show when powerstat shows off and promote to error
2022-11-26 16:13:41 -06:00
Mike Black W9MDB
58f2549a99
Change rigctl send_raw to also require terminator
...
https://github.com/Hamlib/Hamlib/issues/1157
2022-11-26 15:19:23 -06:00
Mike Black W9MDB
a0711bfa71
Fix send_raw and add some debug to it
...
https://github.com/Hamlib/Hamlib/issues/1157
2022-11-25 17:40:05 -06:00
Mike Black W9MDB
af6d4d03e3
Add send_raw to rigctl
2022-11-24 23:27:07 -06:00
Mike Black W9MDB
1ef3549e94
Fix rigctld showing the real rig agc_levels instead of all levels
...
Fix display of RIG_AGC_OFF
Add RIG_AGC_LONG
Fix PowerSDR AGC values
https://github.com/Hamlib/Hamlib/issues/1155
2022-11-23 23:29:18 -06:00
Mike Black W9MDB
6c5e0e6974
Update astyle formatting
2022-11-16 15:30:36 -06:00
Mike Black W9MDB
cd1dc4c05d
Add ability to enter terminator char for W send_cmd_rx so one can do 'W FA; ;' without a timeout needed
2022-10-29 23:09:53 -05:00
Mike Black W9MDB
9c02b2ebc2
Fix Yaesu DT command and add 2 or 4 digit timezone option
...
https://github.com/Hamlib/Hamlib/issues/1132
2022-10-25 23:26:16 -05:00
Mike Black W9MDB
67b933ddb5
Update astyle for 4.5 release
2022-09-20 08:46:28 -05:00
Mikael Nousiainen
2c5013662d
Fix warning message for allowed commands when rig is powered off
2022-08-23 00:14:12 +03:00
Mikael Nousiainen
dc02c566f5
Fix handling of the new EPOWER error code: do not re-open rig and fix/extend allowed commands when rig is powered off. Fix Yaesu newcat backend to not try to call rig ID command during command validation.
2022-08-23 00:10:25 +03:00
Mike Black W9MDB
a83eb3bf42
astyle files for 4.5 release
2022-07-27 17:16:17 -05:00
Mike Black W9MDB
627ec83652
Change malloc to calloc
2022-07-27 10:26:08 -05:00
Mike Black W9MDB
72c6bbf2c3
Allo chk_vfo and dump_caps while rig power is off
...
https://github.com/Hamlib/Hamlib/issues/1085
2022-07-20 22:26:18 -05:00
Mike Black W9MDB
d9c7fda5c9
Add global rig_powerstat so other rigctld clients can see powerstat
...
https://github.com/Hamlib/Hamlib/issues/1085
2022-07-16 07:54:27 -05:00
Mike Black W9MDB
93ca57a555
Only check power on if backend has rig_get_powerstat
...
https://github.com/Hamlib/Hamlib/issues/1085
2022-07-15 16:16:11 -05:00
Mike Black W9MDB
0e2ec27646
Default to powerstat=RIG_POWER_ON
...
https://github.com/Hamlib/Hamlib/issues/1085
2022-07-15 16:06:06 -05:00
Mike Black W9MDB
d0c615ae43
Added EPOWER error return when rig is powered off
...
Only set_powerstat will be accepted and rig will be polled for powerstat
https://github.com/Hamlib/Hamlib/issues/1085
2022-07-15 15:41:23 -05:00
Mike Black W9MDB
0ec9622433
Interactive rigctld clients will now flush the line when a VFO error is encountered
...
https://github.com/Hamlib/Hamlib/issues/1041
2022-07-08 16:21:34 -05:00
Mike Black W9MDB
ad2f5047e0
Fix rig_set_lock_mode and rig_get_lock_mode
...
https://github.com/Hamlib/Hamlib/issues/1044
2022-06-06 22:54:10 -05:00
Mike Black W9MDB
f555eceff9
Got set_lock_mode and get_lock_mode working now
...
https://github.com/Hamlib/Hamlib/issues/1044
2022-06-02 15:55:56 -05:00
Mike Black W9MDB
f19d354ede
Astyle files
2022-05-29 12:06:44 -05:00
Mike Black W9MDB
fc26aa545f
Fix get_separator rigctl output
2022-05-29 12:06:03 -05:00
Mike Black W9MDB
ae67384daf
https://github.com/Hamlib/Hamlib/issues/1044
2022-05-29 12:00:03 -05:00
Mike Black W9MDB
0d46e5b92e
Fix check_buffer_overlow for rig_set_ant
2022-05-25 11:55:14 -05:00
Mike Black W9MDB
19f00558e4
More cleanup of rigctl_parse.c output
2022-05-22 23:01:14 -05:00
Mike Black W9MDB
1c379e793a
Clean up rig_get_level output in rigctl_parse.c
2022-05-22 22:45:25 -05:00
Mike Black W9MDB
febeb40722
Add resp_sep to a couple more places in rigctl_parse.c
2022-05-22 22:35:21 -05:00
Mike Black W9MDB
f44fe0ed31
Fix output format of rigctl_parse.c for non-interactive clients
...
Add ARG_NOVFO to get_vfo_info
2022-05-22 09:00:38 -05:00
Mike Black W9MDB
b1a4bb06ce
Astyle files
2022-05-21 13:23:51 -05:00
Mike Black W9MDB
11bcf03229
Add get_separator and set_separator to rigctld
...
This allows rigctld clients to change the reponse format
Multi-line response will use the new separator for fields and a newline at the end of message.
The allows node-red tcprequest to wait for newline and then parse the fields in one message.
https://github.com/Hamlib/Hamlib/issues/1015
2022-05-21 12:42:34 -05:00
Mike Black W9MDB
c9d31337b9
Fix MICDATA ptt with rigctld and the few rigs which needs this -- e.g. TS-590, TS-480, TS-890, TS-990. VX-1700. ICF-8101
...
https://github.com/Hamlib/Hamlib/issues/1033
2022-05-20 09:06:17 -05:00
Mike Black W9MDB
921d4d43ef
Add -S/--separator option to rigctld to allow something other then \n as a field separator
...
Should work better for node-red parsing
https://github.com/Hamlib/Hamlib/issues/1030
2022-05-19 12:28:49 -05:00
Mike Black W9MDB
4d8e64acfe
Stop mapping MICDATA ptt to PTT -- there should be no reason to do this and it was interfering with rigctld and MICDATA rigs TS480/590/890/990
...
https://github.com/Hamlib/Hamlib/issues/998
2022-05-15 11:53:38 -05:00
Mike Black W9MDB
3892bc41dc
Remove form feed form rigctl_parse. Did not do what we need for node-red
2022-05-14 22:13:17 -05:00
Mike Black W9MDB
f16988d363
Fix get_vfo_info prompt
2022-05-14 17:36:28 -05:00
Mike Black W9MDB
6f9d057162
astyle files getting ready for release
2022-05-13 16:50:13 -05:00
Mike Black W9MDB
49cbc18e19
Fix missing semicolon in rig.c and rigctl_parse.c
2022-05-13 11:09:30 -05:00
Mike Black W9MDB
45208df8c6
Fix misspelling in rigctl_parse.c
2022-05-11 22:58:46 -05:00
Mike Black W9MDB
71407bbf1d
Add debug to show file handle in rigctl_parse
...
https://github.com/Hamlib/Hamlib/issues/1026
2022-05-11 11:53:20 -05:00
Mike Black W9MDB
a22787393f
Add debug to rigctl_parse.c to chase down fscanf problem with node-red on some commands
2022-05-10 12:20:54 -05:00
Mike Black W9MDB
22d4009327
Add flush to set_powerstat to avoid any queued data during power operations
2022-05-09 07:11:01 -05:00
Mike Black W9MDB
0b62193d92
Add new error code for security
...
https://github.com/Hamlib/Hamlib/issues/813
2022-04-29 17:17:43 -05:00
Mike Black W9MDB
5400d8ed01
Fix send_command to detect FLRig correctly
2022-04-25 12:54:06 -05:00
Mike Black W9MDB
fbd7893192
Add cat_string to the raw send command in rigctl for FLRig
2022-04-25 12:42:27 -05:00
Mike Black W9MDB
4055810dc8
Remove md5.h from rigctl_parse.c
...
https://github.com/Hamlib/Hamlib/issues/813
2022-04-16 06:40:01 -05:00
Mike Black W9MDB
5c6e92a089
Change make_md5 to rig_make_md5 and export for the DLL build
...
https://github.com/Hamlib/Hamlib/issues/813
2022-04-15 22:44:53 -05:00
Mike Black W9MDB
cd5f69fb96
Remove make_md5 declaraion from rigctl_parse.c
...
https://github.com/Hamlib/Hamlib/issues/813
2022-04-15 17:41:49 -05:00
Mike Black W9MDB
770aa4e98a
Stage 1 rigctld password working using MD5 hash
...
Need to add Stage 2 which will be encryption using the MD5 hash as the key so the secret key nevers gets trasmitted
Then need to add a "by connection" capability as password is permanent across connections right now.
2022-04-15 13:21:35 -05:00
Mike Black W9MDB
8fbda12ce2
Fix warning in rigctl_parse.c
2022-03-05 16:49:56 -06:00
Mike Black W9MDB
0333cdfca5
astyle files
2022-03-01 11:40:14 -06:00
Mike Black W9MDB
499198bf50
Basic rigctld password working -- still need to add secure method -- plain text right now
...
https://github.com/Hamlib/Hamlib/issues/813
2022-03-01 11:39:11 -06:00
Mike Black W9MDB
b3d93cc231
Remove testsecurity from tests/Makefile.am
...
Will implement later
https://github.com/Hamlib/Hamlib/issues/813
2022-02-28 13:08:41 -06:00
Mike Black W9MDB
2c43ee5f0c
Fix compilation warning on rigctl_parse.c
...
https://github.com/Hamlib/Hamlib/issues/813
2022-02-24 17:50:57 -06:00
Mike Black W9MDB
9ae519fc41
Working on password access for rigctld -- not fully implmented yet
...
Need to check on security audit and cross-platform compilation first
https://github.com/Hamlib/Hamlib/issues/813
2022-02-24 17:28:25 -06:00
Mike Black W9MDB
3df4571ec4
Allow rigctl w command to time out faster
2022-02-06 08:24:37 -06:00
Mike Black W9MDB
8c34ce1a2d
astyle source code
2022-02-05 15:27:43 -06:00
Mike Black W9MDB
68e121d82c
Change all to remove HAVE_CONFIG dependency and include <hamlib/config.h> by default
...
This is necessary to keep alignment between the client view of rig->state and the shared libarary view
Including PTHREAD functions in rig->state necessitated this as HAVE_PTHREAD only defined during hamlib compilation.
Clients including hamlib/rig.h did not pick up all the HAVE* config variable that control what gets included
https://github.com/Hamlib/Hamlib/issues/947
2022-02-04 07:41:36 -06:00
Mike Black W9MDB
f08c7d7e36
Change ENTERFUNC RETURNFUNC calls in rigctl_parse.c
...
https://github.com/Hamlib/Hamlib/issues/946
2022-01-31 09:34:32 -06:00
Mike Black W9MDB
615f102ccc
Fix mingw static build
...
https://github.com/Hamlib/Hamlib/issues/946
2022-01-31 09:12:18 -06:00
Mike Black W9MDB
456ab24f58
Fix mingw32 compilation errors
2022-01-31 08:19:50 -06:00
Mike Black W9MDB
7b4b7ee630
Add a depth count to debug statements to help understand calling sequences
...
First call into rig functions is level 1
Top level like rigctl, rigctld is level 0
Non-depth calls are internal debug statements -- which can be modified to also show levels but that's a whole lot of statements not really necessary
Normal calls from other clients will be level 1
2022-01-30 23:37:01 -06:00
Mike Black W9MDB
2028d4d1fa
Add some more memcpy's to sync hamlib_port_t_deprecated
...
https://github.com/Hamlib/Hamlib/issues/894
2022-01-26 17:44:03 -06:00
Mike Black W9MDB
a277d7ab9b
Changes changing hamlib_port_t to pointer are not backwards compatible
2022-01-25 17:41:26 -06:00
Mike Black W9MDB
9e86e62238
Enable async I/O by default
...
Change hamlib_port_t to a pointer in rig.state
Deprecate static hamlib_port_t structure
New hamlib_port_t structure at end of rig.state
Clients built with older hamlib will use old structure in DLL
Clients built with newer hamlib will use new structure in DLL
So we maintain backwards compatibility until Hamlib 5.0
https://github.com/Hamlib/Hamlib/issues/894
2022-01-25 07:59:47 -06:00
Mike Black W9MDB
c2cb94e412
Change sprintf to snprint in tests
...
https://github.com/Hamlib/Hamlib/issues/857
2022-01-11 00:00:44 -06:00
Mike Black W9MDB
d96d616ce5
Change sprint to snprintf in rigctl_parse.c
...
https://github.com/Hamlib/Hamlib/issues/857
2022-01-08 16:08:24 -06:00
Mikael Nousiainen
1d067d6a43
Merge branch 'master' into async-reader
2021-12-12 23:05:48 +02:00
Mikael Nousiainen
56c95b1529
Merge upstream changes and fix conflicts
2021-12-12 23:05:26 +02:00
Mike Black W9MDB
4fa2d68477
Add rig_model and rigctld_version to dump_caps in rigctl_parse.c
2021-12-11 22:54:54 -06:00
Mike Black W9MDB
674a9868d9
Implement ISO8601 time standard in more places.
...
Debug time now shows localtime + utc offset
Rigs that can set the clock now can set either local or utc time on the rig
Icom rigs can only display clock#1 right now so users may want either local or utc
So here are IC7300 examples
rigctl -m 3073 -r com3 -s 115200 set_clock local
rigctl -m 3073 -r com3 -s 115200 set_clock utc
2021-12-06 10:23:18 -06:00
Mike Black W9MDB
07cac7be76
Move ELAPSED macros to rig.h for global use
...
Add ELAPSED to get_vfo_info in rigctl_parse.c
2021-12-05 09:46:00 -06:00
Mike Black W9MDB
d38a248fda
set/get_clock routines for IC7100/7300/7600/7610/7700/7800/785x/9700
...
https://github.com/Hamlib/Hamlib/issues/851
2021-12-01 22:52:55 -06:00
Mike Black W9MDB
a1c8493c62
First cut at clock setting for IC7300/7800/785x/9700
...
https://github.com/Hamlib/Hamlib/issues/851
2021-12-01 11:50:33 -06:00
Mikael Nousiainen
d857f18163
Initial implementation of: reader thread for async handling of rig data, UDP multicast publisher routine and rig state poll thread routine. The reader thread can correctly handle asynchronous data, such as transceive or spectrum data. Work in progress: multi-platform code for I/O routines still missing and the poll routine is not yet in use. Tested briefly on an IC-7300 so far.
2021-11-28 20:52:29 +02:00
Mike Black W9MDB
63a51c36a1
astyle files preparing for 4.4 release
2021-11-28 12:41:10 -06:00
Mike Black W9MDB
d820ee9dbf
Add expected_len to read_string function for potential serial I/O speedup
...
https://github.com/Hamlib/Hamlib/issues/850
2021-11-24 13:02:39 -06:00
Mike Black W9MDB
42284ef70b
Fix G command in netrigctl.c
...
https://github.com/Hamlib/Hamlib/issues/874
2021-11-20 16:26:47 -06:00
Mikael Nousiainen
1f538ad7ec
Started work on asynchronous reader thread to enable handling of rig tranceive and waterfall data (WIP)
2021-11-20 21:33:29 +02:00
Mike Black W9MDB
8fe190d622
Reduce error messages about RIG_VFO_OTHER which only applies to some rigs like Icom rigs with the 0x25 command
...
Add a flush_flag to read_string so that the new serial_flush will not produce a timeout value when flushing
https://github.com/Hamlib/Hamlib/issues/835
2021-11-01 23:43:45 -05:00
Mike Black W9MDB
a7a97776bb
Revert "Remove VFO argument from stop_morse, wait_morse, send_voice_mem, and get_dcd"
...
This reverts commit c3d1e1559a
.
2021-10-23 10:13:30 -05:00
Mike Black W9MDB
c3d1e1559a
Remove VFO argument from stop_morse, wait_morse, send_voice_mem, and get_dcd
...
None of these should require a vfo
2021-10-22 13:02:02 -05:00
Mike Black W9MDB
a8a317f6ab
Move parse_mode error message to the function itself
2021-10-16 09:45:24 -05:00
Mike Black W9MDB
4462fe423e
Add USB-D and LSB-D to mode_map for Log4OM mode requests
2021-10-16 09:20:24 -05:00
Mike Black W9MDB
5db5c47ce2
Fix rigctl send_morse command when in vfo mode
2021-09-10 05:46:13 -05:00
Mike Black W9MDB
a0672e4f7e
Fix rigctl/rigctld interaction regression from issue 773
...
https://github.com/Hamlib/Hamlib/issues/778
https://github.com/Hamlib/Hamlib/issues/773
2021-08-29 09:59:47 -05:00