From 512f5f94d04dc84c89e43a1c443f9f47df8c0960 Mon Sep 17 00:00:00 2001 From: Daniele Forsi IU5HKX Date: Mon, 18 Aug 2025 10:28:19 +0200 Subject: [PATCH 1/2] Put the switch cases in the same order as the enum To see what is missing. --- tests/dumpcaps.c | 28 ++++++++++++++-------------- tests/dumpstate.c | 28 ++++++++++++++-------------- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/tests/dumpcaps.c b/tests/dumpcaps.c index 4185812b4..2fcd2dafc 100644 --- a/tests/dumpcaps.c +++ b/tests/dumpcaps.c @@ -124,28 +124,28 @@ int dumpcaps(RIG *rig, FILE *fout) switch (caps->ptt_type) { + case RIG_PTT_NONE: + fprintf(fout, "None\n"); + break; + case RIG_PTT_RIG: fprintf(fout, "Rig capable\n"); break; - case RIG_PTT_RIG_MICDATA: - fprintf(fout, "Rig capable (Mic/Data)\n"); - break; - - case RIG_PTT_PARALLEL: - fprintf(fout, "Parallel port (DATA0)\n"); - break; - - case RIG_PTT_SERIAL_RTS: - fprintf(fout, "Serial port (CTS/RTS)\n"); - break; - case RIG_PTT_SERIAL_DTR: fprintf(fout, "Serial port (DTR/DSR)\n"); break; - case RIG_PTT_NONE: - fprintf(fout, "None\n"); + case RIG_PTT_SERIAL_RTS: + fprintf(fout, "Serial port (CTS/RTS)\n"); + break; + + case RIG_PTT_PARALLEL: + fprintf(fout, "Parallel port (DATA0)\n"); + break; + + case RIG_PTT_RIG_MICDATA: + fprintf(fout, "Rig capable (Mic/Data)\n"); break; default: diff --git a/tests/dumpstate.c b/tests/dumpstate.c index cf725d412..9d1ee719d 100644 --- a/tests/dumpstate.c +++ b/tests/dumpstate.c @@ -122,28 +122,28 @@ int dumpstate(RIG *rig, FILE *fout) switch (rs->ptt_type) { + case RIG_PTT_NONE: + fprintf(fout, "None\n"); + break; + case RIG_PTT_RIG: fprintf(fout, "Rig capable\n"); break; - case RIG_PTT_RIG_MICDATA: - fprintf(fout, "Rig capable (Mic/Data)\n"); - break; - - case RIG_PTT_PARALLEL: - fprintf(fout, "Parallel port (DATA0)\n"); - break; - - case RIG_PTT_SERIAL_RTS: - fprintf(fout, "Serial port (CTS/RTS)\n"); - break; - case RIG_PTT_SERIAL_DTR: fprintf(fout, "Serial port (DTR/DSR)\n"); break; - case RIG_PTT_NONE: - fprintf(fout, "None\n"); + case RIG_PTT_SERIAL_RTS: + fprintf(fout, "Serial port (CTS/RTS)\n"); + break; + + case RIG_PTT_PARALLEL: + fprintf(fout, "Parallel port (DATA0)\n"); + break; + + case RIG_PTT_RIG_MICDATA: + fprintf(fout, "Rig capable (Mic/Data)\n"); break; default: From 55f575565c41ab9fb6dcab87cf8b4e4948880b8d Mon Sep 17 00:00:00 2001 From: Daniele Forsi IU5HKX Date: Mon, 18 Aug 2025 10:50:51 +0200 Subject: [PATCH 2/2] Handle missing enums --- tests/dumpcaps.c | 12 ++++++++++++ tests/dumpstate.c | 12 ++++++++++++ 2 files changed, 24 insertions(+) diff --git a/tests/dumpcaps.c b/tests/dumpcaps.c index 2fcd2dafc..4c5805730 100644 --- a/tests/dumpcaps.c +++ b/tests/dumpcaps.c @@ -148,6 +148,18 @@ int dumpcaps(RIG *rig, FILE *fout) fprintf(fout, "Rig capable (Mic/Data)\n"); break; + case RIG_PTT_CM108: + fprintf(fout, "CM108 GPIO pin\n"); + break; + + case RIG_PTT_GPIO: + fprintf(fout, "GPIO pin\n"); + break; + + case RIG_PTT_GPION: + fprintf(fout, "GPIO pin inverted\n"); + break; + default: fprintf(fout, "Unknown\n"); strcat(warnbuf, " PTT_TYPE"); diff --git a/tests/dumpstate.c b/tests/dumpstate.c index 9d1ee719d..ff66ce54a 100644 --- a/tests/dumpstate.c +++ b/tests/dumpstate.c @@ -146,6 +146,18 @@ int dumpstate(RIG *rig, FILE *fout) fprintf(fout, "Rig capable (Mic/Data)\n"); break; + case RIG_PTT_CM108: + fprintf(fout, "CM108 GPIO pin\n"); + break; + + case RIG_PTT_GPIO: + fprintf(fout, "GPIO pin\n"); + break; + + case RIG_PTT_GPION: + fprintf(fout, "GPIO pin inverted\n"); + break; + default: fprintf(fout, "Unknown\n"); strcat(warnbuf, " PTT_TYPE");