kopia lustrzana https://github.com/Hamlib/Hamlib
Quell gcc 8.2.0 warning of uninitialized value
On Debian Buster gcc ((Debian 8.2.0-8) 8.2.0) was throwing the following warnings: CC funcube.lo ../../hamlib/kit/funcube.c: In function ‘funcubepro_get_level’: ../../hamlib/kit/funcube.c:783:87: warning: ‘au8BufOut[3]’ may be used uninitialized in this function [-Wmaybe-uninitialized] __func__, au8BufOut[0] & 0xFF, au8BufOut[1] & 0xFF, au8BufOut[2] & 0xFF, au8BufOut[3] & 0xFF); ~~~~~~~~~^~~ ../../hamlib/kit/funcube.c:783:66: warning: ‘au8BufOut[2]’ may be used uninitialized in this function [-Wmaybe-uninitialized] __func__, au8BufOut[0] & 0xFF, au8BufOut[1] & 0xFF, au8BufOut[2] & 0xFF, au8BufOut[3] & 0xFF); ~~~~~~~~~^~~ ../../hamlib/kit/funcube.c:783:45: warning: ‘au8BufOut[1]’ may be used uninitialized in this function [-Wmaybe-uninitialized] __func__, au8BufOut[0] & 0xFF, au8BufOut[1] & 0xFF, au8BufOut[2] & 0xFF, au8BufOut[3] & 0xFF); ~~~~~~~~~^~~ ../../hamlib/kit/funcube.c: In function ‘funcubepro_set_level’: ../../hamlib/kit/funcube.c:730:87: warning: ‘au8BufOut[3]’ may be used uninitialized in this function [-Wmaybe-uninitialized] __func__, au8BufOut[0] & 0xFF, au8BufOut[1] & 0xFF, au8BufOut[2] & 0xFF, au8BufOut[3] & 0xFF); ~~~~~~~~~^~~ ../../hamlib/kit/funcube.c:730:66: warning: ‘au8BufOut[2]’ may be used uninitialized in this function [-Wmaybe-uninitialized] __func__, au8BufOut[0] & 0xFF, au8BufOut[1] & 0xFF, au8BufOut[2] & 0xFF, au8BufOut[3] & 0xFF); ~~~~~~~~~^~~ Initialize au8BufOut and au8BufIn to 0 to quell the warning.pull/58/head^2
rodzic
b0ebeaeda4
commit
82e31653a1
|
@ -174,12 +174,12 @@ const struct rig_caps funcubeplus_caps = {
|
||||||
.has_get_level = RIG_LEVEL_ATT | RIG_LEVEL_PREAMP | RIG_LEVEL_RF, // RIG_LEVEL_ATT: Mixer gain on/off
|
.has_get_level = RIG_LEVEL_ATT | RIG_LEVEL_PREAMP | RIG_LEVEL_RF, // RIG_LEVEL_ATT: Mixer gain on/off
|
||||||
// RIG_LEVEL_PREAMP: LNA gain on/off
|
// RIG_LEVEL_PREAMP: LNA gain on/off
|
||||||
// RIG_LEVEL_RF 0..1 : IF gain 0 .. 59 dB
|
// RIG_LEVEL_RF 0..1 : IF gain 0 .. 59 dB
|
||||||
|
|
||||||
|
|
||||||
.has_set_level = RIG_LEVEL_ATT | RIG_LEVEL_PREAMP | RIG_LEVEL_RF, // RIG_LEVEL_ATT: Mixer gain on/off
|
.has_set_level = RIG_LEVEL_ATT | RIG_LEVEL_PREAMP | RIG_LEVEL_RF, // RIG_LEVEL_ATT: Mixer gain on/off
|
||||||
// RIG_LEVEL_PREAMP: LNA gain on/off
|
// RIG_LEVEL_PREAMP: LNA gain on/off
|
||||||
// RIG_LEVEL_RF 0..1 : IF gain 0 .. 59 dB
|
// RIG_LEVEL_RF 0..1 : IF gain 0 .. 59 dB
|
||||||
// so values have to be mapped
|
// so values have to be mapped
|
||||||
.has_get_parm = RIG_PARM_NONE,
|
.has_get_parm = RIG_PARM_NONE,
|
||||||
.has_set_parm = RIG_PARM_NONE,
|
.has_set_parm = RIG_PARM_NONE,
|
||||||
.level_gran = {},
|
.level_gran = {},
|
||||||
|
@ -700,8 +700,8 @@ int funcubepro_set_level(RIG *rig, vfo_t vfo, setting_t level, value_t val)
|
||||||
libusb_device_handle *udh = rig->state.rigport.handle;
|
libusb_device_handle *udh = rig->state.rigport.handle;
|
||||||
int ret;
|
int ret;
|
||||||
int actual_length;
|
int actual_length;
|
||||||
unsigned char au8BufOut[64]; // endpoint size
|
unsigned char au8BufOut[64] = { 0 }; // endpoint size
|
||||||
unsigned char au8BufIn[64]; // endpoint size
|
unsigned char au8BufIn[64] = { 0 }; // endpoint size
|
||||||
|
|
||||||
switch (level) {
|
switch (level) {
|
||||||
case RIG_LEVEL_PREAMP:
|
case RIG_LEVEL_PREAMP:
|
||||||
|
@ -719,7 +719,7 @@ int funcubepro_set_level(RIG *rig, vfo_t vfo, setting_t level, value_t val)
|
||||||
if( au8BufOut[1] > 59 )
|
if( au8BufOut[1] > 59 )
|
||||||
au8BufOut[1]= 59;
|
au8BufOut[1]= 59;
|
||||||
break;
|
break;
|
||||||
|
|
||||||
|
|
||||||
default:
|
default:
|
||||||
rig_debug(RIG_DEBUG_ERR, "%s: Unsupported level %d\n", __func__, level);
|
rig_debug(RIG_DEBUG_ERR, "%s: Unsupported level %d\n", __func__, level);
|
||||||
|
@ -761,8 +761,8 @@ int funcubepro_get_level(RIG *rig, vfo_t vfo, setting_t level, value_t *val)
|
||||||
libusb_device_handle *udh = rig->state.rigport.handle;
|
libusb_device_handle *udh = rig->state.rigport.handle;
|
||||||
int ret;
|
int ret;
|
||||||
int actual_length;
|
int actual_length;
|
||||||
unsigned char au8BufOut[64]; // endpoint size
|
unsigned char au8BufOut[64] = { 0 }; // endpoint size
|
||||||
unsigned char au8BufIn[64]; // endpoint size
|
unsigned char au8BufIn[64] = { 0 }; // endpoint size
|
||||||
|
|
||||||
switch (level) {
|
switch (level) {
|
||||||
case RIG_LEVEL_ATT:
|
case RIG_LEVEL_ATT:
|
||||||
|
@ -773,7 +773,7 @@ int funcubepro_get_level(RIG *rig, vfo_t vfo, setting_t level, value_t *val)
|
||||||
break;
|
break;
|
||||||
case RIG_LEVEL_RF:
|
case RIG_LEVEL_RF:
|
||||||
au8BufOut[0] = REQUEST_GET_IF_GAIN;
|
au8BufOut[0] = REQUEST_GET_IF_GAIN;
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
rig_debug(RIG_DEBUG_ERR, "%s: Unsupported level %d\n", __func__, level);
|
rig_debug(RIG_DEBUG_ERR, "%s: Unsupported level %d\n", __func__, level);
|
||||||
return -RIG_EINVAL;
|
return -RIG_EINVAL;
|
||||||
|
@ -809,7 +809,7 @@ int funcubepro_get_level(RIG *rig, vfo_t vfo, setting_t level, value_t *val)
|
||||||
switch (level) {
|
switch (level) {
|
||||||
case RIG_LEVEL_PREAMP:
|
case RIG_LEVEL_PREAMP:
|
||||||
case RIG_LEVEL_ATT:
|
case RIG_LEVEL_ATT:
|
||||||
val->i = au8BufIn[2] &0x01;
|
val->i = au8BufIn[2] &0x01;
|
||||||
break;
|
break;
|
||||||
|
|
||||||
case RIG_LEVEL_RF:
|
case RIG_LEVEL_RF:
|
||||||
|
|
Ładowanie…
Reference in New Issue