From 6a700023abdec3c7ae021d7dc981b0cd5d5dbd29 Mon Sep 17 00:00:00 2001 From: Daniele Forsi IU5HKX Date: Sat, 23 Aug 2025 19:25:26 +0200 Subject: [PATCH] Remove duplicated custom debug output It has several issues: * these are trace messages so RIG_DEBUG_ERR is inappropriate * they are in a custom format which doesn't handle end of line chars * write_block() and read_string() print the same information when debug level is set to TRACE --- rotators/grbltrk/grbltrk.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/rotators/grbltrk/grbltrk.c b/rotators/grbltrk/grbltrk.c index b207f6a64..74e0778c7 100644 --- a/rotators/grbltrk/grbltrk.c +++ b/rotators/grbltrk/grbltrk.c @@ -116,8 +116,6 @@ grbl_request(ROT *rot, char *request, uint32_t req_size, char *response, static int fail_count = 0; hamlib_port_t *rotp = ROTPORT(rot); - rot_debug(RIG_DEBUG_ERR, "req: [%s][%d]\n", request, fail_count); - if (rot->caps->rot_model == ROT_MODEL_GRBLTRK_SER || rot->caps->rot_model == ROT_MODEL_GRBLTRK_NET) { @@ -162,11 +160,7 @@ grbl_request(ROT *rot, char *request, uint32_t req_size, char *response, rig_flush(rotp); - rot_debug(RIG_DEBUG_ERR, "rsp: [%s]\n", response); - //fprintf(stderr, "rsp: [%s]\n", response); - *resp_size = retval; - } return RIG_OK; @@ -194,7 +188,7 @@ grbl_init(ROT *rot) for (i = 0; i < init_count; i++) { int retval; - rot_debug(RIG_DEBUG_ERR, "grbl_request [%s] ", grbl_init_list[i]); + retval = grbl_request(rot, grbl_init_list[i], strlen(grbl_init_list[i]), rsp, &resp_size);