From 51b4e0966c56b4b8b1cfcef897b30e7a9bbc9752 Mon Sep 17 00:00:00 2001 From: Michael Black W9MDB Date: Sun, 1 Nov 2020 17:05:29 -0600 Subject: [PATCH] Remove bad targetable code from rigs https://github.com/Hamlib/Hamlib/issues/430 https://github.com/Hamlib/Hamlib/issues/414 --- rigs/icom/icom.c | 5 ----- rigs/kenwood/kenwood.c | 6 ------ rigs/yaesu/newcat.c | 8 -------- 3 files changed, 19 deletions(-) diff --git a/rigs/icom/icom.c b/rigs/icom/icom.c index 6cbe4c890..fadfd433a 100644 --- a/rigs/icom/icom.c +++ b/rigs/icom/icom.c @@ -814,11 +814,6 @@ icom_rig_open(RIG *rig) #if 0 // do not do this here -- needs to be done when ranges are requested instead as this is very slow icom_get_freq_range(rig); // try get to get rig range capability dyamically #endif - // All Icom rigs as of 20201031 do not need VFO switch for PTT and RITXIT - // They are non-VFO specific commands - // If they ever become VFO specific implement in the backend - //rig->caps->targetable_vfo |= RIG_TARGETABLE_PTT | RIG_TARGETABLE_RITXIT | - // RIG_TARGETABLE_MEM | RIG_TARGETABLE_BANK; return RIG_OK; } diff --git a/rigs/kenwood/kenwood.c b/rigs/kenwood/kenwood.c index 3ea19292a..0565508d1 100644 --- a/rigs/kenwood/kenwood.c +++ b/rigs/kenwood/kenwood.c @@ -938,12 +938,6 @@ int kenwood_open(RIG *rig) // mismatched IDs can still be tested rig->state.rigport.retry = retry_save; - // All Kenwood rigs as of 20201031 do not need VFO switch for PTT and RITXIT - // They are non-VFO specific commands - // If they ever become VFO specific implement in the backend - // newcat.c version is getting segfault here -- read only? - //rig->caps->targetable_vfo |= RIG_TARGETABLE_PTT | RIG_TARGETABLE_RITXIT | - // RIG_TARGETABLE_MEM | RIG_TARGETABLE_BANK; return RIG_OK; } diff --git a/rigs/yaesu/newcat.c b/rigs/yaesu/newcat.c index bec7b8a54..285bdef0f 100644 --- a/rigs/yaesu/newcat.c +++ b/rigs/yaesu/newcat.c @@ -529,14 +529,6 @@ int newcat_open(RIG *rig) /* Initialize rig_id in case any subsequent commands need it */ (void)newcat_get_rigid(rig); - // All Yaeus rigs as of 20201031 do not need VFO switch for PTT and RITXIT - // They are non-VFO specific commands - // A couple of rigs do have vfo-specific in the backends - // If they ever become VFO specific implement in the backend - // this is getting a segfault on Linux -- read only?? - //rig->caps->targetable_vfo |= RIG_TARGETABLE_PTT | RIG_TARGETABLE_RITXIT | - // RIG_TARGETABLE_MEM | RIG_TARGETABLE_BANK; - return RIG_OK; }