Small bug in configure.ac

Hi all,

just found a minor problem in the configure.ac file for hamlib 1.2.15.3.

Back in 2007 Stephane added some checks to make the build system
respect pthreads (see commit from 11 Sep 2007). In that he added some
line to modify CFLAGS and CXXFLAGS (see lines 87.. in configure.ac)

 ACX_PTHREAD
 if test x"$acx_pthread_ok" = xyes; then
        CFLAGS="${CFLAGS} ${PTHREAD_CFLAGS}"
        CXXFLAGS="${CFLAGS} ${PTHREAD_CFLAGS}"
 fi

These code let the build system ignore the CXXFLAGS setting by replacing
it by CFLAGS. I just checked that these error affects only the
building of the c++ bindings. So it shoudl be easy to fix.

Correct version should do

        CXXFLAGS="${CXXFLAGS} ${PTHREAD_CFLAGS}"

instead. See the attached patch.

73, de Tom DL1JBE.

Signed-off-by: Nate Bargmann <n0nb@n0nb.us>

Note that this bug that affected the Hamlib-1.2.15 and earlier branches
also has affected the master branch.  This is now corrected and CXXFLAGS
is preserved through configure.ac.
Hamlib-3.0
Thomas Beierlein 2013-01-26 17:06:03 +01:00 zatwierdzone przez Nate Bargmann
rodzic f6d464de38
commit 302d0b2ffe
1 zmienionych plików z 1 dodań i 1 usunięć

Wyświetl plik

@ -127,7 +127,7 @@ GR_PWIN32
AX_PTHREAD
AS_IF([test x"$ax_pthread_ok" = "xyes"], [
CFLAGS="${CFLAGS} ${PTHREAD_CFLAGS}"
CXXFLAGS="${CFLAGS} ${PTHREAD_CFLAGS}"
CXXFLAGS="${CXXFLAGS} ${PTHREAD_CFLAGS}"
])
AC_SYS_POSIX_TERMIOS()