From 18153de3b40c22e9fadbed9040a451ab58045d81 Mon Sep 17 00:00:00 2001
From: Malcolm Herring <malcolm.herring@btinternet.com>
Date: Thu, 13 Feb 2020 16:08:16 +0000
Subject: [PATCH] additional error checking for extended operations

---
 rigs/icom/icom.c | 90 ++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 84 insertions(+), 6 deletions(-)

diff --git a/rigs/icom/icom.c b/rigs/icom/icom.c
index 954566a5d..4a12595c0 100644
--- a/rigs/icom/icom.c
+++ b/rigs/icom/icom.c
@@ -2785,37 +2785,115 @@ int icom_get_level(RIG *rig, vfo_t vfo, setting_t level, value_t *val)
 int icom_set_ext_level(RIG *rig, vfo_t vfo, token_t token, value_t val)
 {
     rig_debug(RIG_DEBUG_VERBOSE, "%s called\n", __func__);
-    return icom_set_ext_cmd(rig, vfo, token, val);
+
+    const struct confparams *cfp = rig->caps->extlevels;
+    cfp = (cfp == NULL) ? icom_ext_levels : cfp;
+    int i;
+
+    for (i = 0; (cfp[i].token != RIG_CONF_END) || (cfp != icom_ext_levels);) {
+        if (cfp[i].token == RIG_CONF_END) {
+            cfp = icom_ext_levels;
+            i = 0;
+        } else if (cfp[i].token == token) {
+            return icom_set_ext_cmd(rig, vfo, token, val);
+        } else { i++; }
+    }
+    return -RIG_EINVAL;
 }
 
 int icom_get_ext_level(RIG *rig, vfo_t vfo, token_t token, value_t *val)
 {
     rig_debug(RIG_DEBUG_VERBOSE, "%s called\n", __func__);
-    return icom_get_ext_cmd(rig, vfo, token, val);
+
+    const struct confparams *cfp = rig->caps->extlevels;
+    cfp = (cfp == NULL) ? icom_ext_levels : cfp;
+    int i;
+
+    for (i = 0; (cfp[i].token != RIG_CONF_END) || (cfp != icom_ext_levels);) {
+        if (cfp[i].token == RIG_CONF_END) {
+            cfp = icom_ext_levels;
+            i = 0;
+        } else if (cfp[i].token == token) {
+            return icom_get_ext_cmd(rig, vfo, token, val);
+        } else { i++; }
+    }
+    return -RIG_EINVAL;
 }
 
 int icom_set_ext_func(RIG *rig, vfo_t vfo, token_t token, int status)
 {
     rig_debug(RIG_DEBUG_VERBOSE, "%s called\n", __func__);
-    return icom_set_ext_cmd(rig, vfo, token, (value_t)status);
+
+    const struct confparams *cfp = rig->caps->extfuncs;
+    cfp = (cfp == NULL) ? icom_ext_funcs : cfp;
+    int i;
+
+    for (i = 0; (cfp[i].token != RIG_CONF_END) || (cfp != icom_ext_funcs);) {
+        if (cfp[i].token == RIG_CONF_END) {
+            cfp = icom_ext_funcs;
+            i = 0;
+        } else if (cfp[i].token == token) {
+            return icom_set_ext_cmd(rig, vfo, token, (value_t)status);
+        } else { i++; }
+    }
+    return -RIG_EINVAL;
 }
 
 int icom_get_ext_func(RIG *rig, vfo_t vfo, token_t token, int *status)
 {
     rig_debug(RIG_DEBUG_VERBOSE, "%s called\n", __func__);
-    return icom_get_ext_cmd(rig, vfo, token, (value_t*)status);
+
+    const struct confparams *cfp = rig->caps->extfuncs;
+    cfp = (cfp == NULL) ? icom_ext_funcs : cfp;
+    int i;
+
+    for (i = 0; (cfp[i].token != RIG_CONF_END) || (cfp != icom_ext_funcs);) {
+        if (cfp[i].token == RIG_CONF_END) {
+            cfp = icom_ext_funcs;
+            i = 0;
+        } else if (cfp[i].token == token) {
+            return icom_get_ext_cmd(rig, vfo, token, (value_t*)status);
+        } else { i++; }
+    }
+    return -RIG_EINVAL;
 }
 
 int icom_set_ext_parm(RIG *rig, token_t token, value_t val)
 {
     rig_debug(RIG_DEBUG_VERBOSE, "%s called\n", __func__);
-    return icom_set_ext_cmd(rig, RIG_VFO_NONE, token, val);
+
+    const struct confparams *cfp = rig->caps->extparms;
+    cfp = (cfp == NULL) ? icom_ext_parms : cfp;
+    int i;
+
+    for (i = 0; (cfp[i].token != RIG_CONF_END) || (cfp != icom_ext_parms);) {
+        if (cfp[i].token == RIG_CONF_END) {
+            cfp = icom_ext_parms;
+            i = 0;
+        } else if (cfp[i].token == token) {
+            return icom_set_ext_cmd(rig, RIG_VFO_NONE, token, val);
+        } else { i++; }
+    }
+    return -RIG_EINVAL;
 }
 
 int icom_get_ext_parm(RIG *rig, token_t token, value_t *val)
 {
     rig_debug(RIG_DEBUG_VERBOSE, "%s called\n", __func__);
-    return icom_get_ext_cmd(rig, RIG_VFO_NONE, token, val);
+
+    const struct confparams *cfp = rig->caps->extparms;
+    cfp = (cfp == NULL) ? icom_ext_parms : cfp;
+    int i;
+
+    for (i = 0; (cfp[i].token != RIG_CONF_END) || (cfp != icom_ext_parms);) {
+        if (cfp[i].token == RIG_CONF_END) {
+            cfp = icom_ext_parms;
+            i = 0;
+        } else if (cfp[i].token == token) {
+            return icom_get_ext_cmd(rig, RIG_VFO_NONE, token, val);
+        } else { i++; }
+    }
+    return -RIG_EINVAL;
 }
 
 int icom_get_ext_cmd(RIG *rig, vfo_t vfo, token_t token, value_t *val)